Fix bugs of source gens found during main port v9 (#4670)

* Fix problems in auto serialization source gen

* Fix auto implement property source gen handling arrays and nullables correctly

* Fix nullable handling in auto property source gen

* Fix warning

Author: StefanOssendorf

Source/Csla.Generators/cs/AutoImplementProperties/Csla.Generator.AutoImplementProperties.CSharp.Tests/AutoImplementPropertiesGeneratorTests.cs

@@ -1,5 +1,4 @@
 using Csla.Generator.AutoImplementProperties.CSharp.AutoImplement;
-using Microsoft.VisualStudio.TestTools.UnitTesting;
 
 
 namespace Csla.Generator.Tests
@@ -162,5 +161,45 @@ public partial class BOTest : BusinessBase<BOTest>
         """;
       await TestHelper<IncrementalAutoImplementPropertiesPartialsGenerator>.Verify(source);
     }
+
+    public static IEnumerable<object[]> Case08TestData()
+    {
+      var nonNullableBuiltInTypes = new string[] { "bool", "byte", "sbyte", "char", "decimal", "double", "float", "int", "uint", "long", "ulong", "short", "ushort" };
+
+      foreach (var item in nonNullableBuiltInTypes)
+      {
+        yield return new object[] { item };
+        yield return new object[] { $"{item}?" };
+        yield return new object[] { $"{item}[]" };
+        yield return new object[] { $"{item}[]?" };
+      }
+
+      var nullableBuiltInTypes = new string[] { "string", "object" };
+
+      foreach (var item in nullableBuiltInTypes)
+      {
+        yield return new object[] { item };
+        yield return new object[] { $"{item}?" };
+        yield return new object[] { $"{item}[]" };
+        yield return new object[] { $"{item}[]?" };
+      }
+    }
+
+    [DataTestMethod]
+    [DynamicData(nameof(Case08TestData))]
+    public async Task Case08(string type)
+    {
+      var source = $$"""
+        namespace Test;
+
+        [Csla.CslaImplementProperties]
+        public partial class BusinessBaseTestClass : Csla.BusinessBase<BusinessBaseTestClass>
+        {
+          public partial {{type}} Name { get; private set; }
+        }
+        """;
+
+      await TestHelper<IncrementalAutoImplementPropertiesPartialsGenerator>.Verify(source);
+    }
   }
 }

Source/Csla.Generators/cs/AutoImplementProperties/Csla.Generator.AutoImplementProperties.CSharp.Tests/Snapshots/AutoImplementPropertiesGeneratorTests.Case01#ReadOnlyPOCO.g.verified.cs

@@ -11,7 +11,7 @@ public partial class ReadOnlyPOCO
 	public static readonly PropertyInfo<string> NameProperty = RegisterProperty<string>(nameof(Name));
 	public partial string Name
 	{
-		get => GetProperty(NameProperty);
+		get => GetProperty(NameProperty)!;
 		private set => LoadProperty(NameProperty, value);
 	}
 }

Source/Csla.Generators/cs/AutoImplementProperties/Csla.Generator.AutoImplementProperties.CSharp.Tests/Snapshots/AutoImplementPropertiesGeneratorTests.Case02#BusinessBaseTestClass.g.verified.cs

@@ -11,7 +11,7 @@ public partial class BusinessBaseTestClass
 	public static readonly PropertyInfo<string> NameProperty = RegisterProperty<string>(nameof(Name));
 	public partial string Name
 	{
-		get => GetProperty(NameProperty);
+		get => GetProperty(NameProperty)!;
 		private set => SetProperty(NameProperty, value);
 	}
 }

Source/Csla.Generators/cs/AutoImplementProperties/Csla.Generator.AutoImplementProperties.CSharp.Tests/Snapshots/AutoImplementPropertiesGeneratorTests.Case03#BusinessBaseTestClass.g.verified.cs

@@ -11,7 +11,7 @@ public partial class BusinessBaseTestClass
 	public static readonly PropertyInfo<global::Test2.GenericType<string>> NameProperty = RegisterProperty<global::Test2.GenericType<string>>(nameof(Name));
 	public partial global::Test2.GenericType<string> Name
 	{
-		get => GetProperty(NameProperty);
+		get => GetProperty(NameProperty)!;
 		private set => SetProperty(NameProperty, value);
 	}
 }

Source/Csla.Generators/cs/AutoImplementProperties/Csla.Generator.AutoImplementProperties.CSharp.Tests/Snapshots/AutoImplementPropertiesGeneratorTests.Case04#BusinessBaseTestClass.g.verified.cs

@@ -11,7 +11,7 @@ public partial class BusinessBaseTestClass
 	public static readonly PropertyInfo<string> NameProperty = RegisterProperty<string>(nameof(Name));
 	public partial string Name
 	{
-		get => GetProperty(NameProperty);
+		get => GetProperty(NameProperty)!;
 		private set => SetProperty(NameProperty, value);
 	}
 }

Source/Csla.Generators/cs/AutoImplementProperties/Csla.Generator.AutoImplementProperties.CSharp.Tests/Snapshots/AutoImplementPropertiesGeneratorTests.Case05#BusinessBaseTestClass.g.verified.cs

@@ -11,13 +11,13 @@ public partial class BusinessBaseTestClass
 	public static readonly PropertyInfo<global::Test2.UniqueType1> UniqueNameProperty = RegisterProperty<global::Test2.UniqueType1>(nameof(UniqueName));
 	public partial global::Test2.UniqueType1 UniqueName
 	{
-		get => GetProperty(UniqueNameProperty);
+		get => GetProperty(UniqueNameProperty)!;
 		private set => SetProperty(UniqueNameProperty, value);
 	}
 	public static readonly PropertyInfo<global::Test3.NonUniqueType> NonUniqueProperty = RegisterProperty<global::Test3.NonUniqueType>(nameof(NonUnique));
 	public partial global::Test3.NonUniqueType NonUnique
 	{
-		get => GetProperty(NonUniqueProperty);
+		get => GetProperty(NonUniqueProperty)!;
 		set => SetProperty(NonUniqueProperty, value);
 	}
 }

Source/Csla.Generators/cs/AutoImplementProperties/Csla.Generator.AutoImplementProperties.CSharp.Tests/Snapshots/AutoImplementPropertiesGeneratorTests.Case06#CommandTest.g.verified.cs

@@ -11,7 +11,7 @@ public partial class CommandTest
 	public static readonly PropertyInfo<string> NameProperty = RegisterProperty<string>(nameof(Name));
 	public partial string Name
 	{
-		get => ReadProperty(NameProperty);
+		get => ReadProperty(NameProperty)!;
 		private set => LoadProperty(NameProperty, value);
 	}
 }

Source/Csla.Generators/cs/AutoImplementProperties/Csla.Generator.AutoImplementProperties.CSharp.Tests/Snapshots/AutoImplementPropertiesGeneratorTests.Case07#BOTest.g.verified.cs

@@ -11,7 +11,7 @@ public partial class BOTest
 	public static readonly PropertyInfo<global::Test.GenericType<global::Csla.Core.MobileDictionary<string, int>>> NameProperty = RegisterProperty<global::Test.GenericType<global::Csla.Core.MobileDictionary<string, int>>>(nameof(Name));
 	public partial global::Test.GenericType<global::Csla.Core.MobileDictionary<string, int>> Name
 	{
-		get => GetProperty(NameProperty);
+		get => GetProperty(NameProperty)!;
 		private set => SetProperty(NameProperty, value);
 	}
 }

Source/Csla.Generators/cs/AutoImplementProperties/Csla.Generator.AutoImplementProperties.CSharp.Tests/Snapshots/AutoImplementPropertiesGeneratorTests.Case08_type=bool#BusinessBaseTestClass.g.verified.cs

@@ -0,0 +1,17 @@
+//HintName: BusinessBaseTestClass.g.cs
+//<auto-generated/>
+#nullable enable
+using System;
+using Csla;
+
+namespace Test;
+
+public partial class BusinessBaseTestClass
+{
+	public static readonly PropertyInfo<bool> NameProperty = RegisterProperty<bool>(nameof(Name));
+	public partial bool Name
+	{
+		get => GetProperty(NameProperty)!;
+		private set => SetProperty(NameProperty, value);
+	}
+}

Source/Csla.Generators/cs/AutoImplementProperties/Csla.Generator.AutoImplementProperties.CSharp.Tests/Snapshots/AutoImplementPropertiesGeneratorTests.Case08_type=bool-#BusinessBaseTestClass.g.verified.cs

@@ -0,0 +1,17 @@
+//HintName: BusinessBaseTestClass.g.cs
+//<auto-generated/>
+#nullable enable
+using System;
+using Csla;
+
+namespace Test;
+
+public partial class BusinessBaseTestClass
+{
+	public static readonly PropertyInfo<bool?> NameProperty = RegisterProperty<bool?>(nameof(Name));
+	public partial bool? Name
+	{
+		get => GetProperty(NameProperty);
+		private set => SetProperty(NameProperty, value);
+	}
+}