Backport #4761 to v9.X (#4771)

Author: StefanOssendorf

Source/Csla.test/Basic/Children.cs

@@ -7,6 +7,7 @@
 //-----------------------------------------------------------------------
 
 using System.Data;
+using Csla.Core;
 
 namespace Csla.Test.Basic
 {
@@ -37,6 +38,8 @@ public int DeletedCount
     {
       get { return DeletedList.Count; }
     }
+    
+    public MobileList<Child> DeletedItems => DeletedList;
 
     [Create]
     private void Create()

Source/Csla.test/BusinessListBase/BusinessBindingListBaseTests.cs

@@ -0,0 +1,65 @@
+//-----------------------------------------------------------------------
+// <copyright file="BusinessBindingListBaseTests.cs" company="Marimer LLC">
+//     Copyright (c) Marimer LLC. All rights reserved.
+//     Website: https://cslanet.com
+// </copyright>
+// <summary>no summary</summary>
+//-----------------------------------------------------------------------
+
+using Csla.Serialization;
+using Csla.TestHelpers;
+using FluentAssertions;
+using FluentAssertions.Execution;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+namespace Csla.Test.BusinessListBase
+{
+  [TestClass]
+  public class BusinessBindingListBaseTests
+  {
+    private static TestDIContext _testDIContext;
+
+    [ClassInitialize]
+    public static void ClassInitialize(TestContext context)
+    {
+      _testDIContext = TestDIContextFactory.CreateDefaultContext();
+    }
+
+    [TestMethod]
+    public async Task Parent_LocationTransferWithDeletedItemsMustSetParentOnDeletedItems()
+    {
+      var root = CreateRoot();
+
+      for (int i = 0; i < 5; i++)
+      {
+        root.Children.AddNew();
+      }
+
+      root = await root.SaveAsync();
+      root.Children.Clear();
+
+      var transferredGraph = SimulateLocationTransfer(root);
+
+      using (new AssertionScope())
+      {
+        transferredGraph.Children.Parent.Should().BeSameAs(transferredGraph);
+        transferredGraph.Children.DeletedItems.Should().AllSatisfy(c => c.Parent.Should().BeSameAs(transferredGraph.Children));
+      }
+
+
+      static Basic.Root SimulateLocationTransfer(Basic.Root original)
+      {
+        var serializer = _testDIContext.ServiceProvider.GetRequiredService<ISerializationFormatter>();
+        return (Basic.Root)serializer.Deserialize(serializer.Serialize(original));
+      }
+    }
+
+    private static Basic.Root CreateRoot()
+    {
+      var dataPortal = _testDIContext.CreateDataPortal<Basic.Root>();
+
+      return dataPortal.Create(new Basic.Root.Criteria("Random"));
+    }
+  }
+}

Source/Csla.test/BusinessListBase/BusinessListBaseTests.cs

@@ -6,9 +6,11 @@
 // <summary>no summary</summary>
 //-----------------------------------------------------------------------
 
+using Csla.Serialization;
 using Csla.TestHelpers;
 using FluentAssertions;
 using FluentAssertions.Execution;
+using Microsoft.Extensions.DependencyInjection;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
 namespace Csla.Test.BusinessListBase
@@ -234,6 +236,35 @@ public async Task WaitForIdle_WhenMultipleChildsAreBusyItShouldOnlyBeIdlingWhenA
         obj.IsBusy.Should().BeFalse();
       }
     }
+    
+    [TestMethod]
+    public async Task Parent_LocationTransferWithDeletedItemsMustSetParentOnDeletedItems()
+    {
+      var root = CreateRoot();
+
+      for (int i = 0; i < 5; i++)
+      {
+        root.Children.AddNew();
+      }
+
+      root = await root.SaveAsync();
+      root.Children.Clear();
+
+      var transferredGraph = SimulateLocationTransfer(root);
+
+      using (new AssertionScope())
+      {
+        transferredGraph.Children.Parent.Should().BeSameAs(transferredGraph);
+        transferredGraph.Children.DeletedItems.Should().AllSatisfy(c => c.Parent.Should().BeSameAs(transferredGraph.Children));
+      }
+
+
+      static Root SimulateLocationTransfer(Root original)
+      {
+        var serializer = _testDIContext.ServiceProvider.GetRequiredService<ISerializationFormatter>();
+        return (Root)serializer.Deserialize(serializer.Serialize(original));
+      }
+    }
 
     private Root CreateRoot()
     {

Source/Csla.test/BusinessListBase/ChildList.cs

@@ -6,8 +6,13 @@
 // <summary>no summary</summary>
 //-----------------------------------------------------------------------
 
+using Csla.Core;
+
 namespace Csla.Test.BusinessListBase
 {
   [Serializable]
-  public class ChildList : BusinessListBase<ChildList, Child>;
+  public class ChildList : BusinessListBase<ChildList, Child>
+  {
+    public MobileList<Child> DeletedItems => DeletedList;
+  }
 }

Source/Csla/BusinessBindingListBase.cs

@@ -669,7 +669,18 @@ protected override void OnSetChildren(Serialization.Mobile.SerializationInfo inf
       }
       base.OnSetChildren(info, formatter);
     }
+    
+    /// <inheritdoc/>
+    protected override void OnDeserialized()
+    {
+      base.OnDeserialized();
 
+      foreach (var item in DeletedList)
+      {
+        item.SetParent(this);
+      }
+    }
+    
     #endregion
 
     #region IsChild

Source/Csla/BusinessListBase.cs

@@ -704,6 +704,17 @@ protected override void OnSetChildren(SerializationInfo info, MobileFormatter fo
       base.OnSetChildren(info, formatter);
     }
 
+    /// <inheritdoc/>
+    protected override void OnDeserialized()
+    {
+      base.OnDeserialized();
+      
+      foreach (var item in DeletedList)
+      {
+        item.SetParent(this);
+      }
+    }
+
     #endregion
 
     #region IsChild

Source/Directory.Build.props

@@ -2,6 +2,7 @@
  <PropertyGroup>
    <LangVersion>latest</LangVersion>
    <ImplicitUsings>enable</ImplicitUsings>
+   <EnableWindowsTargeting>true</EnableWindowsTargeting>
  </PropertyGroup>
 
  <!-- Common Package Settings -->