Migrate database tests from SQL Server to SQLite (#4820)

* Migrate database tests from SQL Server LocalDB to SQLite for CI

Replace SQL Server LocalDB dependency with SQLite so database integration
tests can run in CI where no SQL Server instance is available.

Changes:
- Add SqliteTestDb.cs to create/manage a temporary SQLite database with
  the same schema and seed data as the original LocalDB test database
- Replace Microsoft.Data.SqlClient with Microsoft.Data.Sqlite package
- Simplify WellKnownValues.cs to serve the SQLite connection string
- Initialize/cleanup SQLite database in AssemblyInitialize/Cleanup
- Remove #if DEBUG guards and [TestCategory("SkipOnCIServer")] attributes
  from SafeDataReaderTests, DataPortalTests, and DataPortalExceptionTests
- Update exception message assertions for SQLite CHECK constraint errors
- Remove MDF/LDF file copy references from project file

https://claude.ai/code/session_0123tC2ciU58UgL8jR2d5PBt

* Fix transaction rollback in DataPortal_Insert for SQLite

SQLite's SqliteConnection does not automatically enlist in ambient
System.Transactions.TransactionScope the way SQL Server does. Replace
the [Transactional(TransactionalTypes.TransactionScope)] attribute with
an explicit SQLite transaction so the first INSERT is properly rolled
back when the second INSERT fails the CHECK constraint.

https://claude.ai/code/session_0123tC2ciU58UgL8jR2d5PBt

* Switch to System.Data.SQLite.Core for TransactionScope support

Microsoft.Data.Sqlite does not support System.Transactions.TransactionScope
(EnlistTransaction throws NotSupportedException). Switch to System.Data.SQLite
which properly enlists in ambient TransactionScope, so the
[Transactional(TransactionalTypes.TransactionScope)] attribute test remains
valid and the rollback behavior is tested end-to-end through CSLA.

https://claude.ai/code/session_0123tC2ciU58UgL8jR2d5PBt

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: rockfordlhotka

Source/tests/Csla.test/Csla.Tests.csproj

@@ -53,7 +53,7 @@
     <PackageReference Include="MSTest.TestAdapter" Version="3.9.1" />
     <PackageReference Include="MSTest.TestFramework" Version="3.9.1" />
     <PackageReference Include="System.Data.Common" Version="4.3.0" />
-    <PackageReference Include="Microsoft.Data.SqlClient" Version="5.2.2" />
+    <PackageReference Include="System.Data.SQLite.Core" Version="1.0.119" />
     <PackageReference Include="System.Resources.Extensions" Version="10.0.0" />
     <PackageReference Include="Microsoft.Extensions.Configuration" Version="10.0.0" />
     <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="10.0.0" />
@@ -81,12 +81,6 @@
   </ItemGroup>
 
   <ItemGroup>
-    <None Update="DataPortalTestDatabase.mdf">
-      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
-    </None>
-    <None Update="DataPortalTestDatabase_log.ldf">
-      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
-    </None>
     <None Update="Properties\Settings.settings">
       <Generator>SettingsSingleFileGenerator</Generator>
       <LastGenOutput>Settings.Designer.cs</LastGenOutput>

Source/tests/Csla.test/DPException/DataPortalExceptionTests.cs

@@ -28,9 +28,7 @@ public void Initialize()
       TestResults.Reinitialise();
     }
 
-#if DEBUG
     [TestMethod]
-    [TestCategory("SkipOnCIServer")]
     public void CheckInnerExceptionsOnSave()
     {
       IDataPortal<DataPortal.TransactionalRoot> dataPortal = _testDIContext.CreateDataPortal<DataPortal.TransactionalRoot>();
@@ -43,7 +41,6 @@ public void CheckInnerExceptionsOnSave()
       string baseException = string.Empty;
       string baseInnerException = string.Empty;
       string baseInnerInnerException = string.Empty;
-      string exceptionSource = string.Empty;
 
       try
       {
@@ -54,31 +51,23 @@ public void CheckInnerExceptionsOnSave()
         baseException = ex.Message;
         baseInnerException = ex.InnerException.Message;
         baseInnerInnerException = ex.InnerException.InnerException?.Message;
-        exceptionSource = ex.InnerException.InnerException?.Source;
         Assert.IsNull(ex.BusinessObject, "Business object shouldn't be returned");
       }
 
       //check base exception
       Assert.IsTrue(baseException.StartsWith("DataPortal.Update failed"), "Exception should start with 'DataPortal.Update failed'");
-      Assert.IsTrue(baseException.Contains("String or binary data would be truncated."),
-        "Exception should contain 'String or binary data would be truncated.'");
+      Assert.IsTrue(baseException.Contains("CHECK constraint failed"),
+        "Exception should contain 'CHECK constraint failed'");
       //check inner exception
       Assert.AreEqual("TransactionalRoot.DataPortal_Insert method call failed", baseInnerException);
-      //check inner exception of inner exception
-      Assert.AreEqual("String or binary data would be truncated.\r\nThe statement has been terminated.", baseInnerInnerException);
+      //check inner exception of inner exception (SQLite CHECK constraint violation)
+      Assert.IsTrue(baseInnerInnerException.Contains("CHECK constraint failed"),
+        "Inner inner exception should contain 'CHECK constraint failed'");
 
-      //check what caused inner exception's inner exception (i.e. the root exception)
-#if (NETFRAMEWORK)
-      Assert.AreEqual(".Net SqlClient Data Provider", exceptionSource);
-#else
-      Assert.AreEqual("Core Microsoft SqlClient Data Provider", exceptionSource);
-#endif
-
-      //verify that the implemented method, DataPortal_OnDataPortal 
+      //verify that the implemented method, DataPortal_OnDataPortal
       //was called for the business object that threw the exception
       Assert.AreEqual("Called", TestResults.GetResult("OnDataPortalException"));
     }
-#endif
 
     [TestMethod]
     public void CheckInnerExceptionsOnDelete()

Source/tests/Csla.test/DataPortal/DataPortalTests.cs

@@ -7,7 +7,7 @@
 //-----------------------------------------------------------------------
 
 using Csla.Test.DataBinding;
-using Microsoft.Data.SqlClient;
+using System.Data.SQLite;
 using Csla.TestHelpers;
 using Microsoft.Extensions.DependencyInjection;
 using Csla.Configuration;
@@ -19,7 +19,6 @@
 using Csla.Server;
 using System.Security.Principal;
 using FluentAssertions.Execution;
-using System.ComponentModel; // added
 
 namespace Csla.Test.DataPortal
 {
@@ -40,30 +39,17 @@ public void Initialize()
       TestResults.Reinitialise();
     }
 
-    private static string CONNECTION_STRING = WellKnownValues.DataPortalTestDatabase;
+    private static string CONNECTION_STRING => WellKnownValues.DataPortalTestDatabase;
     public void ClearDataBase()
     {
-      SqlConnection cn = new SqlConnection(CONNECTION_STRING);
-      SqlCommand cm = new SqlCommand("DELETE FROM Table2", cn);
-
-      try
-      {
-        cn.Open();
-        cm.ExecuteNonQuery();
-      }
-      catch (Exception)
-      {
-        //do nothing
-      }
-      finally
-      {
-        cn.Close();
-      }
+      using var cn = new SQLiteConnection(CONNECTION_STRING);
+      cn.Open();
+      using var cm = cn.CreateCommand();
+      cm.CommandText = "DELETE FROM Table2";
+      cm.ExecuteNonQuery();
     }
 
-#if DEBUG
     [TestMethod]
-    [TestCategory("SkipOnCIServer")]
     public void TestTransactionScopeUpdate()
     {
       IDataPortal<TransactionalRoot> dataPortal = _testDIContext.CreateDataPortal<TransactionalRoot>();
@@ -73,35 +59,17 @@ public void TestTransactionScopeUpdate()
       tr.LastName = "Johnson";
       tr.SmallColumn = "abc";
 
-      try
-      {
-        tr = tr.Save();
-      }
-      catch (Exception ex)
-      {
-        if (IsTransactionScopeEnvironmentUnavailable(ex))
-          Assert.Inconclusive("Skipping TransactionScope test: transactional infrastructure (MSDTC / distributed transactions) not available (0x89c5010a).");
-        throw;
-      }
-
-      SqlConnection cn = new SqlConnection(CONNECTION_STRING);
-      SqlCommand cm = new SqlCommand("SELECT * FROM Table2", cn);
+      tr = tr.Save();
 
-      try
+      using (var cn = new SQLiteConnection(CONNECTION_STRING))
       {
         cn.Open();
-        SqlDataReader dr = cm.ExecuteReader();
+        using var cm = cn.CreateCommand();
+        cm.CommandText = "SELECT * FROM Table2";
+        using var dr = cm.ExecuteReader();
 
+        //will have rows since no exception was thrown on the insert
         Assert.AreEqual(true, dr.HasRows);
-        dr.Close();
-      }
-      catch (Exception)
-      {
-        //do nothing
-      }
-      finally
-      {
-        cn.Close();
       }
 
       ClearDataBase();
@@ -117,47 +85,24 @@ public void TestTransactionScopeUpdate()
       }
       catch (Exception ex)
       {
-        if (IsTransactionScopeEnvironmentUnavailable(ex))
-          Assert.Inconclusive("Skipping TransactionScope test: transactional infrastructure (MSDTC / distributed transactions) not available (0x89c5010a).");
         Assert.IsTrue(ex.Message.StartsWith("DataPortal.Update failed"), "Invalid exception message");
       }
 
-      try
+      //within the DataPortal_Insert method, two commands are run to insert data into
+      //the database. Here we verify that both commands have been rolled back
+      using (var cn = new SQLiteConnection(CONNECTION_STRING))
       {
         cn.Open();
-        SqlDataReader dr = cm.ExecuteReader();
+        using var cm = cn.CreateCommand();
+        cm.CommandText = "SELECT * FROM Table2";
+        using var dr = cm.ExecuteReader();
 
+        //should not have rows since both commands were rolled back
         Assert.AreEqual(false, dr.HasRows);
-        dr.Close();
-      }
-      catch (Exception)
-      {
-        //do nothing
-      }
-      finally
-      {
-        cn.Close();
       }
 
       ClearDataBase();
     }
-#endif
-
-    private static bool IsTransactionScopeEnvironmentUnavailable(Exception ex)
-    {
-      // Walk inner exceptions to find Win32Exception 0x89c5010a
-      while (ex != null)
-      {
-        if (ex is Win32Exception w32)
-        {
-          if (w32.NativeErrorCode == unchecked((int)0x89c5010a) ||
-              w32.Message.Contains("0x89c5010a", StringComparison.OrdinalIgnoreCase))
-            return true;
-        }
-        ex = ex.InnerException;
-      }
-      return false;
-    }
 
     [TestMethod]
     public void StronglyTypedDataPortalMethods()

Source/tests/Csla.test/DataPortal/TransactionalRoot.cs

@@ -6,7 +6,7 @@
 // <summary>no summary</summary>
 //-----------------------------------------------------------------------
 
-using Microsoft.Data.SqlClient;
+using System.Data.SQLite;
 
 namespace Csla.Test.DataPortal
 {
@@ -119,33 +119,29 @@ protected void DataPortal_Fetch(object criteria)
     [Transactional(TransactionalTypes.TransactionScope)]
     [Insert]
     protected void DataPortal_Insert()
-    { 
-      SqlConnection cn = new SqlConnection(WellKnownValues.DataPortalTestDatabase);
+    {
+      using var cn = new SQLiteConnection(WellKnownValues.DataPortalTestDatabase);
       string firstName = FirstName;
       string lastName = LastName;
       string smallColumn = SmallColumn;
 
+      cn.Open();
+
       //this command will always execute successfully
       //since it inserts a string less than 5 characters
       //into SmallColumn
-      SqlCommand cm1 = new SqlCommand();
-      cm1.Connection = cn;
+      using var cm1 = cn.CreateCommand();
       cm1.CommandText = "INSERT INTO Table2(FirstName, LastName, SmallColumn) VALUES('Bill', 'Thompson', 'abc')";
 
       //this command will throw an exception
-      //if SmallColumn is set to a string longer than 
+      //if SmallColumn is set to a string longer than
       //5 characters
-      SqlCommand cm2 = new SqlCommand();
-      cm2.Connection = cn;
-      //use stringbuilder
-      cm2.CommandText = "INSERT INTO Table2(FirstName, LastName, SmallColumn) VALUES('";
-      cm2.CommandText += firstName;
-      cm2.CommandText += "', '" + lastName + "', '" + smallColumn + "')";
+      using var cm2 = cn.CreateCommand();
+      cm2.CommandText = "INSERT INTO Table2(FirstName, LastName, SmallColumn) VALUES('" +
+        firstName + "', '" + lastName + "', '" + smallColumn + "')";
 
-      cn.Open();
       cm1.ExecuteNonQuery();
       cm2.ExecuteNonQuery();
-      cn.Close();
 
       TestResults.Reinitialise();
       TestResults.Add("TransactionalRoot", "Inserted");