[DeleteSelfChild]() now requires same parameter as [InsertChild](...) and [UpdateChild](...)

[michaelcsikos]

Prior to version 5.x, Child_DeleteSelf() methods could be parameterless, and weren't required to match the parameters of the Child_Insert(...) and Child_Update(...) methods. I'm now having to add unused parameters like Guid parentId or object parent to fix the breaking change. Before I go and change 200+ classes just checking that there's no configuration option for this?

[rockfordlhotka]

I don't follow the problem? You can absolutely have a DeleteSelf data portal operation that requires no parameters, and that would be normal, unless you use the Inject attribute to inject dependencies.

[michaelcsikos]

If the parent is doing an update like this:

if (FieldManager.FieldExists(TheChildrenProperty))
    DataPortal.UpdateChild(ReadProperty(TheChildrenProperty), Id);

Then it won't find Child_DeleteSelf() and will throw. But it will find Child_DeleteSelf(Guid parentId). This is different to 4.11.2.

[michaelcsikos]

{"MyCompany.MyProduct.Business.TheChildClass.[DeleteSelfChild](Guid)"}
System.Exception {System.Reflection.TargetParameterCountException}

[michaelcsikos]

CslaDeleteSelfChildTest.zip

Hi @rockfordlhotka

Please see the attached sample, .NET 5.0 with CSLA 5.4.2.

In MyChild with the following it throws. Uncomment Guid parentId and it works.

[InsertChild]
private void InsertChild(Guid parentId)
{
}

[UpdateChild]
private void UpdateChild(Guid parentId)
{
}

[DeleteSelfChild]
private void DeleteSelfChild(/*Guid parentId*/)
{
}

Csla.DataPortalException: DataPortal.Update failed (MyChildren.Child_Update method call failed)
 ---> Csla.Reflection.CallMethodException: MyParent.Update method call failed
 ---> Csla.Reflection.CallMethodException: MyChildren.Child_Update method call failed
 ---> System.Reflection.TargetParameterCountException: CslaDeleteSelfChildTest.MyChild.[DeleteSelfChild](Guid)
 ---> System.Reflection.TargetParameterCountException: Csla.BusinessBase`1[[CslaDeleteSelfChildTest.MyChild, CslaDeleteSelfChildTest, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null]].[DeleteSelfChild](Guid)
 ---> System.Reflection.TargetParameterCountException: Csla.Core.BusinessBase.[DeleteSelfChild](Guid)
 ---> System.Reflection.TargetParameterCountException: Csla.Core.UndoableBase.[DeleteSelfChild](Guid)
 ---> System.Reflection.TargetParameterCountException: Csla.Core.BindableBase.[DeleteSelfChild](Guid)
 ---> System.Reflection.TargetParameterCountException: Csla.Core.MobileObject.[DeleteSelfChild](Guid)
 ---> System.Reflection.TargetParameterCountException: System.Object.[DeleteSelfChild](Guid)
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Type targetType, Object[] criteria, Boolean throwOnError)
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Type targetType, Object[] criteria, Boolean throwOnError)
   --- End of inner exception stack trace ---
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Type targetType, Object[] criteria, Boolean throwOnError)
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Type targetType, Object[] criteria, Boolean throwOnError)
   --- End of inner exception stack trace ---
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Type targetType, Object[] criteria, Boolean throwOnError)
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Type targetType, Object[] criteria, Boolean throwOnError)
   --- End of inner exception stack trace ---
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Type targetType, Object[] criteria, Boolean throwOnError)
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Type targetType, Object[] criteria, Boolean throwOnError)
   --- End of inner exception stack trace ---
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Type targetType, Object[] criteria, Boolean throwOnError)
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Type targetType, Object[] criteria, Boolean throwOnError)
   --- End of inner exception stack trace ---
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Type targetType, Object[] criteria, Boolean throwOnError)
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Type targetType, Object[] criteria, Boolean throwOnError)
   --- End of inner exception stack trace ---
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Type targetType, Object[] criteria, Boolean throwOnError)
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Object target, Object[] criteria)
   at Csla.Reflection.LateBoundObject.CallMethodTryAsyncDI[T](Boolean isSync, Object[] parameters)
   at Csla.Server.DataPortalTarget.UpdateChildAsync(Object[] parameters)
   at Csla.Server.ChildDataPortal.Update(Object obj, Boolean hasParameters, Boolean bypassIsDirtyTest, Object[] parameters)
   --- End of inner exception stack trace ---
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Type targetType, Object[] criteria, Boolean throwOnError)
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Object target, Object[] criteria)
   at Csla.Reflection.LateBoundObject.CallMethodTryAsyncDI[T](Boolean isSync, Object[] parameters)
   at Csla.Server.DataPortalTarget.UpdateChildAsync(Object[] parameters)
   at Csla.Server.ChildDataPortal.Update(Object obj, Boolean hasParameters, Boolean bypassIsDirtyTest, Object[] parameters)
   at Csla.Reflection.ServiceProviderMethodCaller.CallMethodTryAsync(Object obj, ServiceProviderMethodInfo method, Object[] parameters)
   at Csla.Reflection.LateBoundObject.CallMethodTryAsyncDI[T](Boolean isSync, Object[] parameters)
   at Csla.Server.DataPortalTarget.UpdateChildAsync(Object[] parameters)
   at Csla.Server.ChildDataPortal.Update(Object obj, Boolean hasParameters, Boolean bypassIsDirtyTest, Object[] parameters)
   --- End of inner exception stack trace ---
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Type targetType, Object[] criteria, Boolean throwOnError)
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Object target, Object[] criteria)
   at Csla.Reflection.LateBoundObject.CallMethodTryAsyncDI[T](Boolean isSync, Object[] parameters)
   at Csla.Server.DataPortalTarget.UpdateChildAsync(Object[] parameters)
   at Csla.Server.ChildDataPortal.Update(Object obj, Boolean hasParameters, Boolean bypassIsDirtyTest, Object[] parameters)
   at Csla.Reflection.ServiceProviderMethodCaller.CallMethodTryAsync(Object obj, ServiceProviderMethodInfo method, Object[] parameters)
   at Csla.Reflection.LateBoundObject.CallMethodTryAsyncDI[T](Boolean isSync, Object[] parameters)
   at Csla.Server.DataPortalTarget.UpdateChildAsync(Object[] parameters)
   at Csla.Server.ChildDataPortal.Update(Object obj, Boolean hasParameters, Boolean bypassIsDirtyTest, Object[] parameters)
   at Csla.Reflection.ServiceProviderMethodCaller.CallMethodTryAsync(Object obj, ServiceProviderMethodInfo method, Object[] parameters)
   at Csla.Reflection.LateBoundObject.CallMethodTryAsyncDI[T](Boolean isSync, Object[] parameters)
   at Csla.Server.DataPortalTarget.InvokeOperationAsync[T](Object criteria, Boolean isSync)
   at Csla.Server.DataPortalTarget.UpdateAsync(Boolean isSync)
   at Csla.Server.SimpleDataPortal.Update(Object obj, DataPortalContext context, Boolean isSync)
   --- End of inner exception stack trace ---
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Type targetType, Object[] criteria, Boolean throwOnError)
   at Csla.Reflection.ServiceProviderMethodCaller.FindDataPortalMethod[T](Object target, Object[] criteria)
   at Csla.Reflection.LateBoundObject.CallMethodTryAsyncDI[T](Boolean isSync, Object[] parameters)
   at Csla.Server.DataPortalTarget.UpdateChildAsync(Object[] parameters)
   at Csla.Server.ChildDataPortal.Update(Object obj, Boolean hasParameters, Boolean bypassIsDirtyTest, Object[] parameters)
   at Csla.Reflection.ServiceProviderMethodCaller.CallMethodTryAsync(Object obj, ServiceProviderMethodInfo method, Object[] parameters)
   at Csla.Reflection.LateBoundObject.CallMethodTryAsyncDI[T](Boolean isSync, Object[] parameters)
   at Csla.Server.DataPortalTarget.UpdateChildAsync(Object[] parameters)
   at Csla.Server.ChildDataPortal.Update(Object obj, Boolean hasParameters, Boolean bypassIsDirtyTest, Object[] parameters)
   at Csla.Reflection.ServiceProviderMethodCaller.CallMethodTryAsync(Object obj, ServiceProviderMethodInfo method, Object[] parameters)
   at Csla.Reflection.LateBoundObject.CallMethodTryAsyncDI[T](Boolean isSync, Object[] parameters)
   at Csla.Server.DataPortalTarget.InvokeOperationAsync[T](Object criteria, Boolean isSync)
   at Csla.Server.DataPortalTarget.UpdateAsync(Boolean isSync)
   at Csla.Server.SimpleDataPortal.Update(Object obj, DataPortalContext context, Boolean isSync)
   at Csla.BusinessBase`1.Save()
   at CslaDeleteSelfChildTest.Form1.TrySave() in D:\Temp\CslaDeleteSelfChildTest\CslaDeleteSelfChildTest\Form1.cs:line 44

[rockfordlhotka]

Got it, that is great. Can you please file this as an issue in the Issues tab?