Why doesn't BusinessBase implement INotifyDataErrorInfo?

[GreatBarrier86]

I was curious about why BusinessBase doesn't implement INotifyDataErrorInfo. I'm running into an issue with using CSLA with the DevExpress Xamarin control set and they've indicated that the reason errors aren't showing up in certain situations is because INotifyDataErrorInfo is not being implemented. I can implement it myself, but I'm curious why it is not already done. I can see in IBusinessBase that it's implemented when #if NETFX_CORE && !ANDROID && !IOS, but in the scenario of Xamarin, it's being excluded.

I could implement it like this which would be relatively simple, but it may be inappropriate

protected override void OnPropertyChanged(string propertyName)
        {
            base.OnPropertyChanged(propertyName);

            ErrorsChanged?.Invoke(this, new DataErrorsChangedEventArgs(propertyName));
        }

        public event EventHandler<DataErrorsChangedEventArgs> ErrorsChanged;

        public bool HasErrors => BrokenRulesCollection.ErrorCount > 0;

        public IEnumerable GetErrors(string propertyName)
        {
            return BrokenRulesCollection.Where(p => p.Property == propertyName && p.Severity == RuleSeverity.Error).Select(p => p.Description);
        }

Any insight would be appreciated.

[rockfordlhotka]

There's also the older IDataErrorInfo, and you can only implement one or the other, because some UI frameworks (WPF?) try to honor both and that causes issues.

In CSLA 6 (having just checked), I see that IDataErrorInfo is implemented. This is actually a conundrum now that you mention it. Certainly CSLA 6 should implement INotifyDataErrorInfo, but that will almost certainly be problematic for WinForms users.

[rockfordlhotka]

However, I did just update the repo so those classes are in a ns2.1 class library - that should make it easy.

[GreatBarrier86]

I'm pretty new to using Git since my company is currently using TFVC, but shouldn't there be other files here? Like your PersonEdit class and Library project?

[rockfordlhotka]

😳😳😳

Fixed. There was apparently an error in some biological system that was interacting with the keyboard.

[rockfordlhotka]

I did include a test for WPF, which appears to work fine with both turned on.

[GreatBarrier86]

I plan on doing the Xamarin and WinForms ones in the morning. Would be great to hammer this out.