is not disposing of CancellationTokenSource in ToCancellationToken a problem?

[SimonCropp]

given CancellationTokenSource is disposable. is it a problem to not have it being disposed?

public static class TimeSpanExtensions
{
  public static CancellationToken ToCancellationToken(this TimeSpan timeout)
  {
    var cts = new CancellationTokenSource(timeout);
    return cts.Token;
  }
}

https://learn.microsoft.com/en-us/dotnet/standard/threading/cancellation-in-managed-threads

You should be sure to call the CancellationTokenSource.Dispose method when you have finished using the cancellation token source to free any unmanaged resources it holds.

[rockfordlhotka]

It does sound like it should be disposed. This extension method can't do it, so it is the responsibility of any code using the token.

It will be interesting to see if all the places it is used are in code where dispose is an option. If not, we'll have to consider removing the option. Hopefully that's not an issue, as it should be fine in things like data portal proxies and other DI-provided services. My one concern is if this has crept into the async rules engine, as none of those things are currently disposable (afaik).

[StefanOssendorf]

The services don't have to be disposable to use the cts. But we should make sure to dispose it in our own code.
I think I'll take a look this weekend. So I'm assigning myself to it.