Test/tweets (#212)

* test(tweets): increased service cov

* feat(timeline): for-you v2 (under test)

* fix(timeline): circular dependency with bg module

* fix(timeline): bug

* test(explore): explore unit tests

* test(tweets): tweets unit test

* test(explore-job): explore job unit tests

* test(messages): messages unit test

* feat(timeline): v2 done with seen property and interests based

* fix(test): unit tests

* fix(ci): fix package-lock.json

---------

Co-authored-by: Mario Raafat <mariorafat10@gmail.com>
Co-authored-by: Mario Raafat <136023677+MarioRaafat@users.noreply.github.com>
Co-authored-by: Alyaa Ali <eissaalyaa@gmail.com>

Author: 3 people

.scannerwork/.sonar_lock

@@ -168,6 +168,10 @@
             "!**/enums/**",
             "!**/migrations/**",
             "!**/seeds/**",
+            "!**/*.module.ts",
+            "!**/*.config.ts",
+            "!**/config/**",
+            "!**/constants/**",
             "!main.ts",
             "!**/*.spec.ts",
             "!**/*-key.ts",
@@ -179,4 +183,4 @@
             "^src/(.*)$": "<rootDir>/$1"
         }
     }
-}
+}

package-lock.json

@@ -11,6 +11,9 @@ sonar.test.inclusions=**/*.spec.ts
 # Exclude files from analysis
 sonar.exclusions=**/node_modules/**,**/dist/**,**/coverage/**,**/*.spec.ts,**/migrations/**,**/seeds/**,**/databases/**,**/*.swagger.ts
 
+# Exclude infrastructure code from coverage (DTOs, Entities, Modules, Configs)
+sonar.coverage.exclusions=**/*.dto.ts,**/*.entity.ts,**/*.module.ts,**/config/**,**/migrations/**,**/seeds/**,**/databases/**,**/*.config.ts,**/constants/**,**/*.interface.ts,**/*.enum.ts
+
 # TypeScript specific settings
 sonar.typescript.lcov.reportPaths=coverage/lcov.info
 

package.json

@@ -18,6 +18,7 @@ import { FollowProcessor } from './notifications/follow/follow.processor';
 import { NotificationsModule } from 'src/notifications/notifications.module';
 import { NotificationsGateway } from 'src/notifications/notifications.gateway';
 import { User, UserFollows } from 'src/user/entities';
+import { UserInterests } from 'src/user/entities/user-interests.entity';
 import { TweetReply } from 'src/tweets/entities/tweet-reply.entity';
 import { TweetQuote } from 'src/tweets/entities/tweet-quote.entity';
 import { ReplyJobService } from './notifications/reply/reply.service';
@@ -52,6 +53,14 @@ import { TweetSummary } from 'src/tweets/entities/tweet-summary.entity';
 import { HashtagJobService } from './hashtag/hashtag.service';
 import { HashtagProcessor } from './hashtag/hashtag.processor';
 import { TrendModule } from 'src/trend/trend.module';
+import { TimelineModule } from '../timeline/timeline.module';
+import {
+    CleanupOldTweetsJobService,
+    InitTimelineQueueJobService,
+    RefillTimelineQueueJobService,
+} from './timeline/timeline.service';
+import { TimelineProcessor } from './timeline/timeline.processor';
+import { TimelineCron } from './timeline/timeline.cron';
 
 @Module({
     imports: [
@@ -144,18 +153,30 @@ import { TrendModule } from 'src/trend/trend.module';
                 },
             },
         }),
+        BullModule.registerQueue({
+            name: QUEUE_NAMES.TIMELINE,
+            defaultJobOptions: {
+                attempts: 3,
+                backoff: {
+                    type: 'exponential',
+                    delay: 2000,
+                },
+            },
+        }),
 
         TypeOrmModule.forFeature([User]),
         TypeOrmModule.forFeature([UserFollows]),
         TypeOrmModule.forFeature([Tweet]),
         TypeOrmModule.forFeature([TweetSummary]),
         TypeOrmModule.forFeature([TweetReply, TweetQuote]),
         TypeOrmModule.forFeature([Message]),
+        TypeOrmModule.forFeature([UserInterests, TweetCategory]),
         CommunicationModule,
         RedisModuleConfig,
         NotificationsModule,
         ElasticsearchModule,
         TrendModule,
+        forwardRef(() => TimelineModule),
     ],
     controllers: [ExploreController, EmailJobsController],
     providers: [
@@ -192,6 +213,11 @@ import { TrendModule } from 'src/trend/trend.module';
         AiSummaryProcessor,
         HashtagJobService,
         HashtagProcessor,
+        InitTimelineQueueJobService,
+        RefillTimelineQueueJobService,
+        CleanupOldTweetsJobService,
+        TimelineProcessor,
+        TimelineCron,
     ],
 
     exports: [
@@ -220,6 +246,9 @@ import { TrendModule } from 'src/trend/trend.module';
         EsFollowJobService,
         CompressVideoJobService,
         AiSummaryJobService,
+        InitTimelineQueueJobService,
+        RefillTimelineQueueJobService,
+        CleanupOldTweetsJobService,
     ],
 })
 export class BackgroundJobsModule {}

sonar-project.properties

@@ -15,9 +15,6 @@ export const JOB_NAMES = {
     EMAIL: {
         SEND_OTP: 'send-otp-email',
     },
-    TIMELINE: {
-        PREPARE_FEED: 'prepare-user-feed',
-    },
     FEED: {
         INDEX_TWEET: 'index-tweet-to-elastic',
     },
@@ -47,6 +44,11 @@ export const JOB_NAMES = {
     AI_SUMMARY: {
         GENERATE_TWEET_SUMMARY: 'generate-tweet-summary',
     },
+    TIMELINE: {
+        INIT_QUEUE: 'init-timeline-queue',
+        REFILL_QUEUE: 'refill-timeline-queue',
+        CLEANUP_OLD_TWEETS: 'cleanup-old-tweets',
+    },
     HASHTAG: {
         UPDATE_HASHTAG: 'update-hashtag',
     },

src/background-jobs/background-jobs.module.ts

@@ -62,5 +62,13 @@ describe('ExploreJobsCron', () => {
 
             expect(mock_explore_jobs_service.triggerScoreRecalculation).toHaveBeenCalled();
         });
+
+        it('should handle exceptions thrown during scheduling', async () => {
+            mock_explore_jobs_service.triggerScoreRecalculation.mockRejectedValue(
+                new Error('Unexpected error')
+            );
+
+            await expect(cron.scheduleExploreScoreUpdate()).resolves.not.toThrow();
+        });
     });
 });

src/background-jobs/constants/queue.constants.ts

@@ -12,6 +12,7 @@ import { ExploreJobsService } from './explore-jobs.service';
 export class ExploreJobsCron {
     private readonly logger = new Logger(ExploreJobsCron.name);
 
+    /* istanbul ignore next */
     constructor(private readonly explore_jobs_service: ExploreJobsService) {}
 
     // Schedule explore score update job every hour