Require Jenkins 2.504.3 or newer (jenkinsci#1796)

* Remove whatchanged references

Git 2.51 has deprecated whatchanged

https://github.blog/open-source/git/highlights-from-git-2-51/

https://issues.jenkins.io/browse/JENKINS-76004 describes the change.

Author: MarkEWaite

pom.xml

@@ -5,7 +5,7 @@
   <parent>
     <groupId>org.jenkins-ci.plugins</groupId>
     <artifactId>plugin</artifactId>
-    <version>5.23</version>
+    <version>5.24</version>
     <relativePath />
   </parent>
 
@@ -39,7 +39,7 @@
     <hpi.strictBundledArtifacts>true</hpi.strictBundledArtifacts>
     <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
     <jenkins.baseline>2.504</jenkins.baseline>
-    <jenkins.version>${jenkins.baseline}.1</jenkins.version>
+    <jenkins.version>${jenkins.baseline}.3</jenkins.version>
     <no-test-jar>false</no-test-jar>
     <!-- Do not run extra reporting for pmd -->
     <!-- https://stackoverflow.com/questions/12038238/unable-to-locate-source-xref-to-link-to -->

src/main/java/hudson/plugins/git/GitChangeSet.java

@@ -129,7 +129,7 @@ public GitChangeSet(List<String> lines, boolean authorOrCommitter, boolean retai
             parseCommit(lines);
         }
 
-        // Nearly ISO dates generated by git whatchanged --format=+ci
+        // Nearly ISO dates generated by git log --format=+%ci
         // Look like '2015-09-30 08:21:24 -0600'
         // ISO is    '2015-09-30T08:21:24-06:00'
         // Uses Builder rather than format pattern for more reliable parsing

src/test/java/hudson/plugins/git/GitChangeSetPluginHistoryTest.java

@@ -45,26 +45,6 @@ public class GitChangeSetPluginHistoryTest {
     @ClassRule
     public static GitSampleRepoRule sampleRepo = new GitSampleRepoRule();
 
-    /* git 1.7.1 on CentOS 6.7 "whatchanged" generates no output for
-     * the SHA1 hashes (from this repository) in this list. Rather
-     * than skip testing on that old git version, this exclusion list
-     * allows most tests to run. Debian 6 / git 1.7.2.5 also has the issue.
-     */
-    private static final String[] git171exceptions = {
-        "6e467b23",
-        "750b6806",
-        "7eeb070b",
-        "87988f4d",
-        "94d982c2",
-        "a571899e",
-        "b9e497b0",
-        "bc71cd2d",
-        "bca98ea9",
-        "c73b4ff3",
-        "dcd329f4",
-        "edf066f3",
-    };
-
     public GitChangeSetPluginHistoryTest(GitClient git, boolean authorOrCommitter, String sha1String) throws Exception {
         this.sha1 = ObjectId.fromString(sha1String);
         StringWriter stringWriter = new StringWriter();

src/test/java/hudson/plugins/git/GitChangeSetTimestampTest.java

@@ -14,7 +14,7 @@
 
 /**
  * JENKINS-30073 reports that the timestamp returns -1 for the typical timestamp
- * reported by the +%ci format to git log and git whatchanged. This test
+ * reported by the +%ci format to git log. This test
  * duplicates the bug and tests many other date formatting cases.
  * See JENKINS-55693 for more details on joda time replacement.
  *
@@ -37,7 +37,7 @@ public GitChangeSetTimestampTest(String timestamp, String normalizedTimestamp, l
     @Parameterized.Parameters(name = "{0}")
     public static Collection createSampleChangeSets() {
         Object[][] samples = {
-            /* git whatchanged dates from various time zones, months, & days */
+            /* git log dates from various time zones, months, & days */
             {"2015-10-06 19:29:47 +0300", null, 1444148987000L},
             {"2017-10-23 23:43:29 +0100", null, 1508798609000L},
             {"2017-09-21 17:35:24 -0400", null, 1506029724000L},