Faster and more accurate toolbarEffectView search (#112)

* Faster and more accurate toolbarEffectView search

* Fix comment

Author: cyanzhong

MarkEditMac/Modules/Sources/AppKitExtensions/UI/NSWindow+Extension.swift

@@ -12,17 +12,25 @@ public extension NSWindow {
   }
 
   var toolbarEffectView: NSVisualEffectView? {
-    var result: NSVisualEffectView?
-    rootView?.enumerateChildren { (view: NSVisualEffectView) in
-      // Blindly consider a full-width NSVisualEffectView the toolbar,
-      // a more accurate way would be relying on NSThemeFrame, which is private.
-      if abs(view.frame.width - frame.width) < .ulpOfOne {
-        result = view
+    guard let rootView else {
+      assertionFailure("Missing rootView from window to proceed")
+      return nil
+    }
+
+    var stack = [rootView]
+    while !stack.isEmpty {
+      let node = stack.removeLast()
+      if node is NSVisualEffectView && node.superview?.className.hasPrefix("NSTitlebar") == true {
+        // What we want is an NSVisualEffectView child of an NSTitlebarView
+        return node as? NSVisualEffectView
       }
+
+      // Depth-first search
+      stack.append(contentsOf: node.subviews)
     }
 
-    assert(result != nil, "Failed to find NSVisualEffectView in toolbar")
-    return result
+    assertionFailure("Failed to find NSVisualEffectView in toolbar")
+    return nil
   }
 
   /// Change the frame size, treat the top-left corner as the anchor point.

MarkEditMac/Sources/Editor/EditorWindow.swift

@@ -47,17 +47,11 @@ final class EditorWindow: NSWindow {
 
     // Slightly change the toolbar effect to match editor better
     if let view = toolbarEffectView {
-      // Blend the color of contents behind the window
-      view.blendingMode = .behindWindow
+      view.alphaValue = effectiveAppearance.isDarkMode ? 0.3 : 0.7
       view.isHidden = reduceTransparency == true
 
-      // When there's a dimmed view from save panel, always make it fully visible,
-      // otherwise, a layered background appears.
-      if NSApp.keyWindow is NSSavePanel {
-        view.alphaValue = 1.0
-      } else {
-        view.alphaValue = effectiveAppearance.isDarkMode ? 0.3 : 0.7
-      }
+      // Blend the color of contents behind the window
+      view.blendingMode = .behindWindow
     }
   }
 }