Improve pasteboard handling (#900)

Author: cyanzhong

.github/workflows/build-and-test.yml

@@ -14,7 +14,7 @@ jobs:
     if: github.event.pull_request.draft == false
     env:
       node-version: '20.x'
-      DEVELOPER_DIR: /Applications/Xcode_16.2.app/Contents/Developer
+      DEVELOPER_DIR: /Applications/Xcode_16.3.app/Contents/Developer
 
     defaults:
       run:

MarkEditMac/Modules/Sources/AppKitExtensions/Foundation/NSPasteboard+Extension.swift

@@ -7,20 +7,26 @@
 import AppKit
 
 public extension NSPasteboard {
-  var canPaste: Bool {
-    pasteboardItems?.isEmpty == false
+  var hasText: Bool {
+    pasteboardItems?.contains { $0.types.contains(.string) } == true
   }
 
   var string: String? {
     string(forType: .string)
   }
 
-  var url: String? {
-    guard let string else {
-      return string(forType: .URL)
+  func url() async -> String? {
+    guard #available(macOS 15.4, *) else {
+      guard let string else {
+        return string(forType: .URL)
+      }
+
+      return NSDataDetector.extractURL(from: string)
     }
 
-    return NSDataDetector.extractURL(from: string)
+    // This alerts the user only when the pasteboard really contains links
+    let values = try? await NSPasteboard.general.detectedValues(for: [\.links])
+    return values?.links.first?.url.absoluteString
   }
 
   func overwrite(string: String?) {

MarkEditMac/Sources/Editor/Controllers/EditorViewController+HyperLink.swift

@@ -22,7 +22,7 @@ extension EditorViewController {
       // Try our best to guess from selection and clipboard
       bridge.format.insertHyperLink(
         title: prefersURL ? defaultTitle : title,
-        url: prefersURL ? text : (NSPasteboard.general.url ?? "https://"),
+        url: prefersURL ? text : (await NSPasteboard.general.url() ?? "https://"),
         prefix: prefix
       )
     }

MarkEditMac/Sources/Editor/Views/EditorWebView.swift

@@ -134,7 +134,7 @@ private extension EditorWebView {
 
       // Disable paste for empty pasteboard
       if item.tag == WKContextMenuItemTag.paste.rawValue {
-        item.isEnabled = NSPasteboard.general.canPaste
+        item.isEnabled = NSPasteboard.general.hasText
       }
 
       // Hide native items that require text selection

MarkEditMac/Sources/Main/Application/AppDelegate+Menu.swift

@@ -39,7 +39,7 @@ private extension AppDelegate {
       $0?.superMenuItem?.isHidden = document?.fileURL == nil
     }
 
-    fileFromClipboardItem?.isHidden = !NSPasteboard.general.canPaste
+    fileFromClipboardItem?.isHidden = !NSPasteboard.general.hasText
   }
 
   func reconfigureMainEditMenu(document: EditorDocument?) {
@@ -50,7 +50,7 @@ private extension AppDelegate {
 
       editUndoItem?.isEnabled = await document.canUndo
       editRedoItem?.isEnabled = await document.canRedo
-      editPasteItem?.isEnabled = NSPasteboard.general.canPaste
+      editPasteItem?.isEnabled = NSPasteboard.general.hasText
     }
 
     // [macOS 15] The system one doesn't work for WKWebView