Skip to content

Commit 8ea6f75

Browse files
committed
Version 1.0.1 cleanup
1 parent 92807bd commit 8ea6f75

File tree

5 files changed

+14
-19
lines changed

5 files changed

+14
-19
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
*.so
22
*.o
3+
*.swp
34
dist/
45
build/
56
*egg*

src/enc.c

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88
//#define IS_NAN(x) std::isnan(x)
99
//#define IS_INF(x) std::isinf(x)
1010

11-
#define RESERVE_STRING(_len) (2 + ((_len) * 6))
12-
1311
static const char g_hexChars[] = "0123456789abcdef";
1412

1513
typedef struct _encoder
@@ -49,7 +47,7 @@ static int resizeBuffer(Encoder *e, size_t len)
4947
}
5048

5149
#define resizeBufferIfNeeded(__enc, __len) \
52-
if ( (size_t) ((__enc)->end - (__enc)->s) < (size_t) (__len)) { resizeBuffer((__enc), (__len)); }\
50+
if ( (size_t) ((__enc)->end - (__enc)->s) < (size_t) (__len)) { resizeBuffer((__enc), (__len)); }
5351

5452

5553
static inline void reverse(char* begin, char* end)
@@ -114,8 +112,7 @@ static int doStringNoEscapes (Encoder *e, const char *str, const char *end)
114112
break;
115113
//}
116114
}
117-
case 0x01:
118-
case 0x02:
115+
case 0x01: case 0x02:
119116
case 0x03:
120117
case 0x04:
121118
case 0x05:
@@ -367,7 +364,7 @@ int encode( PyObject *o, Encoder *e ) {
367364
if (PyObject_HasAttrString(o, "__json__"))
368365
{
369366
PyObject* func = PyObject_GetAttrString(o, "__json__");
370-
PyObject* res = PyObject_Call(func, NULL);
367+
PyObject* res = PyObject_CallFunctionObjArgs(func, NULL);
371368
Py_DECREF(func);
372369

373370
if (PyErr_Occurred()) {
@@ -404,7 +401,7 @@ int encode( PyObject *o, Encoder *e ) {
404401
PyObject* objectsRepresentation = PyObject_Repr(o);
405402
const char* msg;
406403
#if PY_MAJOR_VERSION >= 3
407-
size_t sz;
404+
Py_ssize_t sz;
408405
msg = PyUnicode_AsUTF8AndSize(objectsRepresentation, &sz);
409406
#else
410407
msg = PyString_AsString(objectsRepresentation);

src/mrjson.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ PyDoc_STRVAR(docstring,
1717
"Decode a JSON string into a Python object.");
1818

1919
static PyMethodDef mrjsonMethods[] = {
20-
{"encode", (PyCFunction) toJson, METH_VARARGS | METH_KEYWORDS, docstring },
21-
{"decode", (PyCFunction) fromJson, METH_VARARGS | METH_KEYWORDS, docstring },
2220
{"dumps", (PyCFunction) toJson, METH_VARARGS | METH_KEYWORDS, docstring },
2321
{"loads", (PyCFunction) fromJson, METH_VARARGS | METH_KEYWORDS, docstring },
2422
{"dump", (PyCFunction) toJsonFile, METH_VARARGS | METH_KEYWORDS, docstring },
@@ -55,9 +53,7 @@ static struct PyModuleDef moduledef = {
5553
PYMODINITFUNC
5654
{
5755
PyObject *m;
58-
PyObject *v;
5956

60-
//initObjToJSON();
6157
m = PYMODULE_CREATE();
6258

6359
if (m == NULL) { MODINITERROR; }

tests.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,15 @@ def eq( a, b ):
6060
except Exception as e:
6161
print( "ERROR",str(e), o )
6262

63-
raises( "NaNd", j.loads, ValueError, "JSON_BAD_IDENTIFIER" )
64-
raises( "[", j.loads, ValueError, "JSON_UNEXPECTED_END" )
65-
raises( "]", j.loads, ValueError, "JSON_STACK_UNDERFLOW" )
66-
raises( "{", j.loads, ValueError, "JSON_UNEXPECTED_END" )
67-
raises( "}", j.loads, ValueError, "JSON_STACK_UNDERFLOW" )
68-
raises( "[1,2,,]", j.loads, ValueError, "JSON_UNEXPECTED_CHARACTER," )
69-
raises( "[1,z]", j.loads, ValueError, "JSON_UNEXPECTED_CHARACTER" )
7063

64+
65+
raises( "NaNd", j.loads, ValueError, "JSON_BAD_IDENTIFIER" )
66+
raises( "[", j.loads, ValueError, "JSON_UNEXPECTED_END" )
67+
raises( "]", j.loads, ValueError, "JSON_STACK_UNDERFLOW" )
68+
raises( "{", j.loads, ValueError, "JSON_UNEXPECTED_END" )
69+
raises( "}", j.loads, ValueError, "JSON_STACK_UNDERFLOW" )
70+
raises( "[1,2,,]", j.loads, ValueError, "JSON_UNEXPECTED_CHARACTER," )
71+
raises( "[1,z]", j.loads, ValueError, "JSON_UNEXPECTED_CHARACTER" )
7172
raises( "["*(1024*1024), j.loads, ValueError, "JSON_STACK_OVERFLOW" )
7273

7374
class JSONTest:

version.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.0.0
1+
1.0.1

0 commit comments

Comments
 (0)