Fixed Haskell tester installation using ghcup to install stack system-wide

Author: david-yz-liu

Changelog.md

@@ -5,6 +5,7 @@ All notable changes to this project will be documented here.
 - Fixed Haskell test results to only include the function name (#687)
 - Improved robustness of tester installation scripts and Docker configuration (#688)
 - Moved tidyverse installation steps from server Dockerfile into R tester requirements.system (#688)
+- Fixed Haskell tester installation using ghcup to install stack system-wide (#688)
 
 ## [v2.9.0]
 - Install stack with GHCup (#626)

server/autotest_server/testers/haskell/haskell_tester.py

@@ -7,9 +7,6 @@
 from ..tester import Tester, Test, TestError
 from ..specs import TestSpecs
 
-home = os.getenv("HOME")
-os.environ["PATH"] = f"{home}/.cabal/bin:{home}/.ghcup/bin:" + os.environ["PATH"]
-
 
 class HaskellTest(Test):
     def __init__(

server/autotest_server/testers/haskell/requirements.system

@@ -1,16 +1,25 @@
 #!/usr/bin/env bash
 set -euxo pipefail
 
-apt-get -y update
-
+# Install a system-wide ghc, which can be used as a default version in the Haskell tester.
+# This should be synchronized with the LTS version and dependencies in setup.py
 if ! dpkg -l ghc cabal-install &> /dev/null; then
+  apt-get -y update
   DEBIAN_FRONTEND=noninteractive apt-get install -y -o 'Dpkg::Options::=--force-confdef' -o 'Dpkg::Options::=--force-confold' ghc cabal-install
 fi
 
-if [ ! -x "$HOME/.ghcup/bin/ghcup" ] && [ ! -x "/usr/local/bin/stack" ]; then
-  BOOTSTRAP_HASKELL_NONINTERACTIVE=1 BOOTSTRAP_HASKELL_INSTALL_NO_STACK=1 curl --proto '=https' --tlsv1.2 -sSf https://get-ghcup.haskell.org | sh
-  $HOME/.ghcup/bin/ghcup install stack recommended
-  if [ "$(id -u)" -eq 0 ]; then
-    cp $HOME/.ghcup/bin/stack /usr/local/bin/
-  fi
+if [ ! -x "/usr/local/bin/stack" ]; then
+  # We use ghcup to install stack rather than relying on system packages. This enables newer versions of Stack to be installed.
+  # Install ghcup dependencies: https://www.haskell.org/ghcup/install/#linux-ubuntu
+  apt-get -y update
+  DEBIAN_FRONTEND=noninteractive apt-get install -y -o 'Dpkg::Options::=--force-confdef' -o 'Dpkg::Options::=--force-confold' \
+    build-essential \
+    curl \
+    libffi-dev \
+    libffi8ubuntu1 \
+    libgmp-dev \
+    libgmp10 \
+    libncurses-dev
+  curl --proto '=https' --tlsv1.2 -sSf https://get-ghcup.haskell.org | BOOTSTRAP_HASKELL_NONINTERACTIVE=1 BOOTSTRAP_HASKELL_MINIMAL=1 sh
+  $HOME/.ghcup/bin/ghcup install stack recommended --isolate /usr/local/bin
 fi

server/autotest_server/testers/haskell/setup.py

@@ -5,9 +5,6 @@
 HASKELL_TEST_DEPS = ["tasty-discover", "tasty-quickcheck", "tasty-hunit"]
 STACK_RESOLVER = "lts-21.21"
 
-home = os.getenv("HOME")
-os.environ["PATH"] = f"{home}/.cabal/bin:{home}/.ghcup/bin:" + os.environ["PATH"]
-
 
 def create_environment(_settings, _env_dir, default_env_dir):
     env_data = _settings.get("env_data", {})