Partial credits not being awarded correctly

[gsaltintas]

Hello,

I am trying to setup tests with partial credits. The target function get_receptive_field_for_network3 returns a dictionary. Even though the total_earned is computed correctly Markus awards full points.

def test_get_parameters_of_network3(request):
    student_answer = student.get_parameters_of_network3()
    expected_answer = answer.get_parameters_of_network3()
    n = len(expected_answer)
    total_earned = 0
    wrong_keys = []
    for (key, value) in expected_answer.items():
        if student_answer[key] != value:
            wrong_keys.append(key)
        else:
            total_earned += 1
    if wrong_keys:
        request.node.add_marker(pytest.mark.markus_message(f"Keys with wrong values: {wrong_keys}"))
    request.node.add_marker(pytest.mark.markus_marks_earned(1. * total_earned/n * PARAM_RECEPTIVE))
    request.node.add_marker(pytest.mark.markus_marks_total(PARAM_RECEPTIVE))

Thank you!

[gsaltintas]

I believe the issue stems from this line, for my use case if all the keys are wrong in the dictionary this check fails and since the test doesn't raise an issue. For now I am going to add an assert statement at the end of the test assert total_earned > 0, "All values wrong." but I think making the check 0<= makes more sense.