feat: Variable type conversion - support non-local-variables-should-be-uppercase

Author: bhirsz

src/robocop/linter/rules/naming.py

@@ -1102,6 +1102,8 @@ def check_non_local_variable(self, variable_name: str, node, token) -> None:
         normalized_var_name = utils.remove_nested_variables(variable_name)
         if not normalized_var_name:
             return
+        if TYPE_SUPPORTED:
+            normalized_var_name, *_ = normalized_var_name.split(": ", 1)
         # a variable as a keyword argument can contain lowercase nested variable
         # because the actual value of it may be uppercase
         if not normalized_var_name.isupper():

tests/linter/rules/variables/non_local_variables_should_be_uppercase/expected_extended_var_typing.txt

@@ -0,0 +1,66 @@
+var_typing.robot:3:24 VAR07 Non local variable is not uppercase
+   |
+ 1 | *** Test Cases ***
+ 2 | Set report
+ 3 |     Set Task Variable  ${my_var: int}  0
+   |                        ^^^^^^^^^^^^^^ VAR07
+ 4 |     Set Suite Variable  ${my var: list[str]}  0
+ 5 |     Set Test Variable  ${My Var: Enum}  0
+   |
+
+var_typing.robot:4:25 VAR07 Non local variable is not uppercase
+   |
+ 2 | Set report
+ 3 |     Set Task Variable  ${my_var: int}  0
+ 4 |     Set Suite Variable  ${my var: list[str]}  0
+   |                         ^^^^^^^^^^^^^^^^^^^^ VAR07
+ 5 |     Set Test Variable  ${My Var: Enum}  0
+ 6 |     Set Global Variable  ${My_Var: str}  0
+   |
+
+var_typing.robot:5:24 VAR07 Non local variable is not uppercase
+   |
+ 3 |     Set Task Variable  ${my_var: int}  0
+ 4 |     Set Suite Variable  ${my var: list[str]}  0
+ 5 |     Set Test Variable  ${My Var: Enum}  0
+   |                        ^^^^^^^^^^^^^^^ VAR07
+ 6 |     Set Global Variable  ${My_Var: str}  0
+   |
+
+var_typing.robot:6:26 VAR07 Non local variable is not uppercase
+   |
+ 4 |     Set Suite Variable  ${my var: list[str]}  0
+ 5 |     Set Test Variable  ${My Var: Enum}  0
+ 6 |     Set Global Variable  ${My_Var: str}  0
+   |                          ^^^^^^^^^^^^^^ VAR07
+   |
+
+var_typing.robot:15:12 VAR07 Non local variable is not uppercase
+    |
+ 13 |
+ 14 | VAR report
+ 15 |     VAR    ${suite: int}    value    scope=SUITE
+    |            ^^^^^^^^^^^^^ VAR07
+ 16 |     VAR    ${global: list[str]}    value    scope=GLOBAL
+ 17 |     VAR    ${test: Enum}    value    scope=TEST
+    |
+
+var_typing.robot:16:12 VAR07 Non local variable is not uppercase
+    |
+ 14 | VAR report
+ 15 |     VAR    ${suite: int}    value    scope=SUITE
+ 16 |     VAR    ${global: list[str]}    value    scope=GLOBAL
+    |            ^^^^^^^^^^^^^^^^^^^^ VAR07
+ 17 |     VAR    ${test: Enum}    value    scope=TEST
+ 18 |     VAR    ${task: str}    value    scope=TASK
+    |
+
+var_typing.robot:18:12 VAR07 Non local variable is not uppercase
+    |
+ 16 |     VAR    ${global: list[str]}    value    scope=GLOBAL
+ 17 |     VAR    ${test: Enum}    value    scope=TEST
+ 18 |     VAR    ${task: str}    value    scope=TASK
+    |            ^^^^^^^^^^^^ VAR07
+    |
+
+Found 7 issues.

tests/linter/rules/variables/non_local_variables_should_be_uppercase/test_rule.py

@@ -10,3 +10,11 @@ def test_extended(self):
 
     def test_var(self):
         self.check_rule(src_files=["VAR_syntax.robot"], expected_file="expected_output_var.txt", test_on_version=">=7")
+
+    def test_var_typing(self):
+        self.check_rule(
+            src_files=["var_typing.robot"],
+            expected_file="expected_extended_var_typing.txt",
+            output_format="extended",
+            test_on_version=">=7.3",
+        )

tests/linter/rules/variables/non_local_variables_should_be_uppercase/var_typing.robot

@@ -0,0 +1,24 @@
+*** Test Cases ***
+Set report
+    Set Task Variable  ${my_var: int}  0
+    Set Suite Variable  ${my var: list[str]}  0
+    Set Test Variable  ${My Var: Enum}  0
+    Set Global Variable  ${My_Var: str}  0
+
+Set ignore
+    Set Task Variable  ${MY_VAR: int}  1
+    Set Suite Variable  ${MY VAR: list[str]}  1
+    Set Test Variable  ${MY_VAR: Enum}  1
+    Set Global Variable  ${MY VAR: str}  1
+
+VAR report
+    VAR    ${suite: int}    value    scope=SUITE
+    VAR    ${global: list[str]}    value    scope=GLOBAL
+    VAR    ${test: Enum}    value    scope=TEST
+    VAR    ${task: str}    value    scope=TASK
+
+VAR ignore
+    VAR    ${SUITE: int}    value    scope=SUITE
+    VAR    ${GLOBAL: list[str]}    value    scope=GLOBAL
+    VAR    ${TEST: Enum}    value    scope=TEST
+    VAR    ${TASK: str}    value    scope=TASK