Skip to content

Commit 35bb795

Browse files
committed
fixing pagination bug in new code
1 parent ec4220d commit 35bb795

File tree

4 files changed

+7
-20
lines changed

4 files changed

+7
-20
lines changed

marklogic-data-hub/src/main/java/com/marklogic/hub/deploy/commands/LoadUserModulesCommand.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import com.marklogic.appdeployer.AppConfig;
44
import com.marklogic.appdeployer.command.AbstractCommand;
55
import com.marklogic.appdeployer.command.CommandContext;
6+
import com.marklogic.appdeployer.command.SortOrderConstants;
67
import com.marklogic.appdeployer.command.modules.AllButAssetsModulesFinder;
78
import com.marklogic.appdeployer.command.modules.AssetModulesFinder;
89
import com.marklogic.client.DatabaseClient;
@@ -33,6 +34,7 @@ public void setForceLoad(boolean forceLoad) {
3334
private boolean forceLoad = false;
3435

3536
public LoadUserModulesCommand(HubConfig hubConfig) {
37+
setExecuteSortOrder(SortOrderConstants.LOAD_MODULES + 1);
3638
this.hubConfig = hubConfig;
3739
}
3840

quick-start/src/main/java/com/marklogic/quickstart/model/SearchQuery.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
public class SearchQuery {
2424
public String query;
2525
public String sort;
26-
public boolean entitiesOnly;
2726
public long start;
2827
public long count;
2928
public HubDatabase database;

quick-start/src/main/java/com/marklogic/quickstart/service/SearchService.java

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,11 @@
2929
import com.marklogic.hub.util.PerformanceLogger;
3030
import com.marklogic.quickstart.model.SearchQuery;
3131
import com.marklogic.quickstart.util.QueryHelper;
32-
import org.codehaus.jettison.json.JSONObject;
3332
import org.w3c.dom.Document;
3433
import org.w3c.dom.Element;
35-
import org.w3c.dom.Node;
3634

3735
import javax.xml.parsers.DocumentBuilder;
3836
import javax.xml.parsers.DocumentBuilderFactory;
39-
import java.io.ByteArrayInputStream;
40-
import java.nio.charset.StandardCharsets;
4137
import java.nio.file.Path;
4238
import java.nio.file.Paths;
4339
import java.util.ArrayList;
@@ -60,30 +56,20 @@ public SearchService(HubConfig hubConfig) {
6056
this.finalDocMgr = finalClient.newDocumentManager();
6157
}
6258

63-
private Element getOptions(boolean entitiesOnly) {
59+
private Element getOptions() {
6460
try {
6561
Path dir = Paths.get(hubConfig.projectDir, HubConfig.USER_CONFIG_DIR, HubConfig.SEARCH_OPTIONS_FILE);
6662
if (dir.toFile().exists()) {
6763
DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();
6864
DocumentBuilder db = dbf.newDocumentBuilder();
6965
Document doc = db.parse(dir.toFile());
70-
Element root = doc.getDocumentElement();
71-
72-
if (entitiesOnly) {
73-
String additionalQuery = "<additional-query xmlns=\"http://marklogic.com/appservices/search\">\n" +
74-
" <cts:element-query xmlns:cts=\"http://marklogic.com/cts\">\n" +
75-
" <cts:element xmlns:es=\"http://marklogic.com/entity-services\">es:instance</cts:element>\n" +
76-
" <cts:true-query/>\n" +
77-
" </cts:element-query>\n" +
78-
" </additional-query>";
79-
Node n = doc.importNode(db.parse(new ByteArrayInputStream(additionalQuery.getBytes(StandardCharsets.UTF_8))).getDocumentElement(), true);
80-
root.appendChild(n);
81-
}
66+
return doc.getDocumentElement();
8267
}
8368
}
8469
catch (Exception e) {
8570
throw new RuntimeException(e);
8671
}
72+
8773
return null;
8874
}
8975

@@ -118,7 +104,7 @@ public StringHandle search(SearchQuery searchQuery) {
118104

119105
StructuredQueryBuilder.AndQuery sqd = sb.and(queries.toArray(new StructuredQueryDefinition[0]));
120106

121-
String searchXml = QueryHelper.serializeQuery(sb, sqd, searchQuery.sort, getOptions(searchQuery.entitiesOnly));
107+
String searchXml = QueryHelper.serializeQuery(sb, sqd, searchQuery.sort, getOptions());
122108
logger.info(searchXml);
123109
RawCombinedQueryDefinition querydef = queryMgr.newRawCombinedQueryDefinitionAs(Format.XML, searchXml);
124110

quick-start/src/main/ui/app/search/search.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<div *ngIf="!loadingTraces" layout="column" flex layout-align="center center" class="full-width">
1616
<app-pagination [start]="searchResponse.start"
1717
[total]="searchResponse.total"
18-
[pageLength]="searchResponse.pageLength"
18+
[pageLength]="searchResponse['page-length']"
1919
(pageChanged)="pageChanged($event)"></app-pagination>
2020
<div *ngIf="!loadingTraces && (!searchResponse || searchResponse.total === 0)">No Data</div>
2121
<div class="mdl-grid results">

0 commit comments

Comments
 (0)