Skip to content
Discussion options

You must be logged in to vote

Hi, sorry for the long response. Guidelines are very simple and most covered by CI/CD pipelines and will punish you if something goes wrong.

Long story short:

  • You should just create PR to main.
  • You should implement both async and sync interfaces which will be native without huge hacks around running in executor etc.
  • You should type annotate the code. Each argument, each return type. The exclusion is only for things like *args and **kwargs; also we do not annotate self here. The linter will help you to not miss any type of annotation. You can go further and use pyright to verify your types
  • You should format code. We are using ruff. For linting and formatting. So just run it locally and fi…

Replies: 1 comment

Comment options

You must be logged in to vote
0 replies
Answer selected by ECAllen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants