feat(BREAKING): remove legacy variant

Due to Github removing support for the Ubuntu-20.04 os image,
I'm removing the legacy variant that was kept alive only for
backward compatibility. RQuickShare will sadly align with Tauri
v2 system requirements.

The previous release v0.11.5 will be the last one to include
the legacy binary. This version is still working and will be the
one people wanting to use RQuickShare on "older" system shall
default to.

Signed-off-by: Martichou <m@rtin.fyi>

Author: Martichou

.github/dependabot.yml

@@ -5,18 +5,6 @@
 
 version: 2
 updates:
-  # npm packages
-  - package-ecosystem: 'npm'
-    directory: '/app/legacy'
-    schedule:
-      interval: 'monthly'
-    commit-message:
-      prefix: 'deps(legacy-npm): '
-    groups:
-      dependencies:
-        patterns:
-          - '*'
-
   - package-ecosystem: 'npm'
     directory: '/app/main'
     schedule:
@@ -40,17 +28,6 @@ updates:
         patterns:
           - '*'
 
-  - package-ecosystem: 'cargo'
-    directory: '/app/legacy/src-tauri'
-    schedule:
-      interval: 'monthly'
-    commit-message:
-      prefix: 'deps(legacy-rust): '
-    groups:
-      dependencies:
-        patterns:
-          - '*'
-
   - package-ecosystem: 'cargo'
     directory: '/app/main/src-tauri'
     schedule:

.github/workflows/build.yml

@@ -46,12 +46,6 @@ jobs:
     strategy:
       matrix:
         include:
-          - os: ubuntu-20.04
-            name: legacy
-            target_path: app/legacy
-            dependencies: |
-              sudo apt-get install -y libjavascriptcoregtk-4.0-dev libwebkit2gtk-4.0-dev
-            cache_directory: app/legacy/src-tauri/target
           - os: ubuntu-24.04
             name: main
             target_path: app/main

.github/workflows/lint.yml

@@ -14,24 +14,18 @@ env:
   CARGO_TERM_COLOR: always
 
 jobs:
-  ensure_vue_lib_same:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - run: |
-          diff -qr app/legacy/src/vue_lib app/main/src/vue_lib
-
   style_rust:
     runs-on: ubuntu-latest
     strategy:
       matrix:
         include:
           - directory: ./core_lib
-          - directory: ./app/legacy/src-tauri
           - directory: ./app/main/src-tauri
     steps:
       - uses: actions/checkout@v4
-      - uses: dtolnay/rust-toolchain@stable
+      - uses: dtolnay/rust-toolchain@nightly
+        with:
+          components: rustfmt
       - run: |
           cd ${{ matrix.directory }}
           cargo fmt --all --check
@@ -41,7 +35,6 @@ jobs:
     strategy:
       matrix:
         include:
-          - directory: ./app/legacy
           - directory: ./app/main
     steps:
       - uses: actions/checkout@v4
@@ -66,18 +59,15 @@ jobs:
           - directory: core_lib
             clippy_args: "--all-features --all"
             os: ubuntu-latest
-          - directory: app/legacy/src-tauri
-            clippy_args: "--no-default-features"
-            os: ubuntu-20.04
           - directory: app/main/src-tauri
             clippy_args: "--no-default-features"
             os: ubuntu-24.04
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v4
-      - uses: dtolnay/rust-toolchain@stable
+      - uses: dtolnay/rust-toolchain@nightly
         with:
-          components: clippy, rustfmt
+          components: clippy
       - uses: Swatinem/rust-cache@v2
         with:
           cache-directories: "${{ github.workspace }}/${{ matrix.directory }}/target"

.github/workflows/release.yml

@@ -16,12 +16,6 @@ jobs:
     strategy:
       matrix:
         include:
-          - os: ubuntu-20.04
-            name: legacy
-            target_path: app/legacy
-            dependencies: |
-              sudo apt-get install -y libjavascriptcoregtk-4.0-dev libwebkit2gtk-4.0-dev
-            cache_directory: app/legacy/src-tauri/target
           - os: ubuntu-24.04
             name: main
             target_path: app/main
@@ -76,22 +70,12 @@ jobs:
           cd ${{ github.workspace }}
           ./rename_build.sh ${{ github.workspace }}/${{ matrix.target_path }}/src-tauri/target/release/bundle/ ${{ matrix.name }}
 
-      - uses: snapcore/action-build@v1
-        if: matrix.target_path == 'app/legacy'
-        id: build-snap
-      - run: sudo snap install --dangerous ${{ steps.build-snap.outputs.snap }}
-        if: matrix.target_path == 'app/legacy'
-      - name: Set Snap File Path
-        if: matrix.target_path == 'app/legacy'
-        run: echo "SNAP_FILE=${{ steps.build-snap.outputs.snap }}" >> $GITHUB_ENV
-
       - name: Add files to release
         if: github.event_name != 'workflow_dispatch'
         uses: softprops/action-gh-release@v2
         with:
           files: |
             ${{ github.workspace }}/${{ matrix.target_path }}/src-tauri/target/release/bundle/*/r-quick-share-${{ matrix.name }}*
-            ${{ env.SNAP_FILE }}
           fail_on_unmatched_files: true
 
       - name: Upload artifacts
@@ -101,4 +85,3 @@ jobs:
           name: artifact-debug-rquickshare-${{ matrix.os }}
           path: |
             ${{ github.workspace }}/${{ matrix.target_path }}/src-tauri/target/release/bundle/*/r-quick-share-${{ matrix.name }}*
-            ${{ env.SNAP_FILE }}

.vscode/settings.json

@@ -1,7 +1,6 @@
 {
 	"rust-analyzer.linkedProjects": [
 		"./core_lib/Cargo.toml",
-		"./app/legacy/src-tauri/Cargo.toml",
 		"./app/main/src-tauri/Cargo.toml",
 	],
 }

BUILD.md

@@ -1,7 +1,7 @@
 The project is divided into two parts:
 
 - **core_lib:** This is a Rust library that encompasses all the logic necessary for discovering, connecting to, and transferring files to QuickShare-compatible clients.
-- **app/legacy:** A Tauri application that utilizes core_lib to handle incoming requests and initiate outgoing ones.
+- **app/main:** A Tauri application that utilizes core_lib to handle incoming requests and initiate outgoing ones.
 
 How to build
 --------------------------
@@ -10,7 +10,7 @@ How to build
 
 Building the core_lib is straightforward because it is a basic Rust project.
 
-Install `protobuf-compiler` system package, and then simply run `cargo build` or `cargo build --release` from `core_lib` folder. 
+Install `protobuf-compiler` system package, and then simply run `cargo build` or `cargo build --release` from `core_lib` folder.
 
 ### app/main
 
@@ -36,9 +36,9 @@ pnpm dev
 pnpm build
 ```
 
-For more detailed information on building the app/legacy and understanding any potential limitations, it’s advised to consult the [Tauri documentation](https://v2.tauri.app/start).
+For more detailed information on building the app/main and understanding any potential limitations, it’s advised to consult the [Tauri documentation](https://v2.tauri.app/start).
 
-### app/legacy
+### app/main
 
 Everything is the same as the app/main one, except the output of the build :)
 
@@ -48,4 +48,4 @@ Everything is the same as the app/main one, except the output of the build :)
 pnpm build
 ```
 
-For more detailed information on building the app/legacy and understanding any potential limitations, it’s advised to consult the [Tauri documentation](https://tauri.app/v1/guides/building/linux).
+For more detailed information on building the app/main and understanding any potential limitations, it’s advised to consult the [Tauri documentation](https://tauri.app/v1/guides/building/linux).

README.md

@@ -22,8 +22,8 @@ You simply have to download the latest release.
 **Important notes:**
 - The minimum GLIBC version supported is included in the pkg name.
   - You can check yours with `ldd --version`.
-- RQuickShare is distributed with two version (main & legacy):
-  - Legacy is for compatibility with older Ubuntu versions.
+- RQuickShare was distributed with two version (main & legacy) up until v0.11.5:
+  - Legacy is for compatibility with older Ubuntu versions: [here](https://github.com/Martichou/rquickshare/releases/tag/v0.11.5).
   - Main is for future support of newer versions of Ubuntu.
 
 #### macOS
@@ -77,14 +77,6 @@ You can then either double click on it, or run it from the cmd line:
 ./r-quick-share_${VERSION}.AppImage
 ```
 
-#### Snap
-
-The snap is not yet on the store, but you can install it with the following (you may need sudo):
-
-```bash
-snap install --dangerous r-quick-share_${VERSION}.snap
-```
-
 ---
 
 <details>