Skip to content

Commit b892dcb

Browse files
wkingMa Shimiao
authored andcommitted
config: Explicitly put hooks in the runtime namespace
The language from 15dee2e (runtime: Add prestart/poststop hooks, 2015-08-03, opencontainers#34) landed well before we had glossary entries for the runtime and container namespaces (from 5dad125, config-linux: Specify host mount namespace for namespace paths, 2015-12-18, opencontainers#275). Now that we do have language to cover that concept, it's better to explicitly say that hooks run in the runtime namespace instead of leaving it to the reader to extrapolate from the filesystem requirement. With the new namespace wording, the "host's filesystem" wording is somewhat redundant. I've left it in though, because I think it helps to have a more gradual transition from hook paths to namespaces. Signed-off-by: W. Trevor King <[email protected]>
1 parent 4e51e24 commit b892dcb

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

config.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ Hooks allow one to run code before/after various lifecycle events of the contain
195195
Hooks MUST be called in the listed order.
196196
The state of the container is passed to the hooks over stdin, so the hooks could get the information they need to do their work.
197197

198-
Hook paths are absolute and are executed from the host's filesystem.
198+
Hook paths are absolute and are executed from the host's filesystem in the [runtime namespace][runtime-namespace].
199199

200200
### Prestart
201201

@@ -615,5 +615,5 @@ Here is a full example `config.json` for reference.
615615
}
616616
```
617617

618-
618+
[runtime-namespace]: glossary.md#runtime-namespace
619619
[uts-namespace]: http://man7.org/linux/man-pages/man7/namespaces.7.html

0 commit comments

Comments
 (0)