tests: fix

Author: Massolari

Makefile

@@ -1,28 +1,11 @@
 TESTS_INIT=tests/minimal_init.lua
 TESTS_DIR=tests/
 
-plugin_files = $(wildcard plugin/*.ts)
-plugin_out_files = $(plugin_files:plugin/%.ts=plugin/%.lua)
-test_init= $(wildcard tests/*.ts)
-test_files =$(wildcard tests/**/*.ts)
-test_out_files = $(test_files:tests/%.ts=tests/%.lua)
-test_out_init = $(test_init:tests/%.ts=tests/%.lua)
-
-
-compile: node_modules
-	mkdir -p lua/forem-nvim
-	npx tstl
-	npx tstl -p plugin/tsconfig.json
-	npx tstl -p tests/tsconfig.json
-
-node_modules: package.json
-	@test -d node_modules || npm clean-install
-
-test: compile
+test:
 	@nvim \
 		--headless \
 		--noplugin \
 		-u ${TESTS_INIT} \
 		-c "PlenaryBustedDirectory ${TESTS_DIR} { minimal_init = '${TESTS_INIT}' }"
 
-.PHONY: test compile
+.PHONY: test

tests/forem-nvim/setup_spec.lua

@@ -3,8 +3,13 @@ local stub = require("luassert.stub")
 local spy = require("luassert.spy")
 local match = require("luassert.match")
 local article = require("forem-nvim.article")
+local busted = require("plenary.busted")
+local describe = busted.describe
+local before_each = busted.before_each
+local after_each = busted.after_each
+local it = busted.it
 
-local function mockInternal(module)
+local function mock_internal(module)
   _G.package.loaded["forem-nvim"] = nil
   _G.package.loaded[module] = nil
   local mocked = require(module)
@@ -14,63 +19,68 @@ end
 describe(
   "Forem.nvim",
   function()
-    local foremNvim
+    local forem_nvim
     local snapshot
+
     before_each(function()
       vim.env.FOREM_API_KEY = "foo"
       _G.package.loaded["forem-nvim"] = nil
-      foremNvim = require("forem-nvim")
+      forem_nvim = require("forem-nvim")
       snapshot = assert:snapshot()
     end)
+
     after_each(function()
       snapshot:revert()
     end)
+
     it(
       "should show a notification when no api key is set",
       function()
         vim.env.FOREM_API_KEY = nil
         stub.new(vim, "notify")
-        foremNvim.my_articles()
+        forem_nvim.my_articles()
         assert.stub(vim.notify).was.called()
       end
     )
+
     it(
       "should call the api to get the articles",
       function()
-        local mockedApi = mockInternal("forem-nvim.api")
-        mockedApi.myArticles = spy.new(function()
+        local mocked_api = mock_internal("forem-nvim.api")
+        mocked_api.my_articles = spy.new(function()
         end)
-        local foremNvimMocked = require("forem-nvim")
-        foremNvimMocked.my_articles()
-        assert.spy(mockedApi.myArticles).was.called()
+        local forem_nvim_mocked = require("forem-nvim")
+        forem_nvim_mocked.my_articles()
+        assert.spy(mocked_api.my_articles).was.called()
       end
     )
+
     it(
       "should create a new article and open it",
       function()
         local input = stub.new(vim.fn, "input")
         input.returns("Title")
-        local api = mockInternal("forem-nvim.api")
-        local apiNewArticle = stub.new(api, "newArticle")
-        local newArticle = {
+        local api = mock_internal("forem-nvim.api")
+        local api_new_article = stub.new(api, "new_article")
+        local new_article = {
           id = 1,
           body_markdown = article.get_template("Title")
         }
-        apiNewArticle.returns({ status = 201, body = newArticle })
-        local buffer = mockInternal("forem-nvim.buffer")
-        local bufferOpenMyArticle = spy.on(buffer, "openMyArticle")
-        local foremNvimMocked = require("forem-nvim")
-        foremNvimMocked.new_article()
-        assert.stub(apiNewArticle).was.called_with("Title")
-        assert.spy(bufferOpenMyArticle).was_called_with(match.is_same(newArticle))
+        api_new_article.returns({ status = 201, body = new_article })
+        local buffer = mock_internal("forem-nvim.buffer")
+        local buffer_open_my_article = spy.on(buffer, "open_my_article")
+        local forem_nvim_mocked = require("forem-nvim")
+        forem_nvim_mocked.new_article()
+        assert.stub(api_new_article).was.called_with("Title")
+        assert.spy(buffer_open_my_article).was_called_with(match.is_same(new_article))
         assert.are.same(
-          "forem://my-article/" .. tostring(newArticle.id),
+          "forem://my-article/" .. tostring(new_article.id),
           vim.api.nvim_buf_get_name(0)
         )
-        local bufferContent = vim.api.nvim_buf_get_lines(0, 0, -1, true)
+        local buffer_content = vim.api.nvim_buf_get_lines(0, 0, -1, true)
         assert.are.same(
-          article.get_body_lines(newArticle),
-          bufferContent
+          article.get_body_lines(new_article),
+          buffer_content
         )
       end
     )