Skip to content

Commit 7c5f290

Browse files
committed
Fixed JweConfigBuilder interface
1 parent 9776a3b commit 7c5f290

File tree

3 files changed

+13
-10
lines changed

3 files changed

+13
-10
lines changed

Mastercard.Developer.ClientEncryption.Core/Encryption/JweConfigBuilder.cs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,13 @@ private JweConfigBuilder() { }
1515
/// <summary>
1616
/// Get an instance of the builder.
1717
/// </summary>
18-
public static JweConfigBuilder AJweConfigBuilder()
19-
{
20-
return new JweConfigBuilder();
21-
}
18+
public static JweConfigBuilder AJweEncryptionConfig() => new JweConfigBuilder();
19+
20+
/// <summary>
21+
/// Get an instance of the builder.
22+
/// </summary>
23+
[Obsolete("Use AJweEncryptionConfig instead.")]
24+
public static JweConfigBuilder AJweConfigBuilder() => new JweConfigBuilder();
2225

2326
/// <summary>
2427
/// See: <see cref="EncryptionConfig.EncryptionCertificate"/>

Mastercard.Developer.ClientEncryption.Tests/NetCore2/Encryption/JweConfigBuilderTest.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public class JweConfigBuilderTest
1313
[TestMethod]
1414
public void TestBuild_Nominal()
1515
{
16-
var config = JweConfigBuilder.AJweConfigBuilder()
16+
var config = JweConfigBuilder.AJweEncryptionConfig()
1717
.WithEncryptionPath("$.payload", "$.encryptedPayload")
1818
.WithEncryptionCertificate(TestUtils.GetTestEncryptionCertificate())
1919
.WithDecryptionPath("$.encryptedPayload", "$.payload")
@@ -57,7 +57,7 @@ public void TestBuild_ShouldThrowEncryptionException_WhenInvalidEncryptionCertif
5757
public void TestBuild_ShouldFallbackToDefaults()
5858
{
5959
// WHEN
60-
var config = JweConfigBuilder.AJweConfigBuilder()
60+
var config = JweConfigBuilder.AJweEncryptionConfig()
6161
.WithEncryptionCertificate(TestUtils.GetTestEncryptionCertificate())
6262
.Build();
6363

@@ -77,7 +77,7 @@ public void TestBuild_ShouldThrowArgumentException_WhenMissingDecryptionKey()
7777
{
7878
try
7979
{
80-
JweConfigBuilder.AJweConfigBuilder().Build();
80+
JweConfigBuilder.AJweEncryptionConfig().Build();
8181
}
8282
catch (Exception e)
8383
{
@@ -92,7 +92,7 @@ public void TestBuild_ShouldThrowArgumentException_WhenNotDefiniteDecryptionPath
9292
{
9393
try
9494
{
95-
JweConfigBuilder.AJweConfigBuilder()
95+
JweConfigBuilder.AJweEncryptionConfig()
9696
.WithDecryptionPath("$.encryptedPayloads[*]", "$.payload")
9797
.WithDecryptionKey(TestUtils.GetTestDecryptionKey())
9898
.Build();
@@ -110,7 +110,7 @@ public void TestBuild_ShouldThrowArgumentException_WhenNotDefiniteEncryptionPath
110110
{
111111
try
112112
{
113-
JweConfigBuilder.AJweConfigBuilder()
113+
JweConfigBuilder.AJweEncryptionConfig()
114114
.WithEncryptionPath("$.payloads[*]", "$.encryptedPayload")
115115
.WithEncryptionCertificate(TestUtils.GetTestEncryptionCertificate())
116116
.Build();

Mastercard.Developer.ClientEncryption.Tests/NetCore2/Test/TestUtils.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ internal static void AssertPayloadEquals(string expectedPayload, string payload)
5555

5656
internal static JweConfigBuilder GetTestJweConfigBuilder()
5757
{
58-
return JweConfigBuilder.AJweConfigBuilder()
58+
return JweConfigBuilder.AJweEncryptionConfig()
5959
.WithEncryptionCertificate(TestUtils.GetTestEncryptionCertificate())
6060
.WithDecryptionKey(TestUtils.GetTestDecryptionKey());
6161
}

0 commit comments

Comments
 (0)