Merge pull request #3 from Mastercard/feature/fixing-code-smells

Re adding private constructors

Author: danny-gallagher

src/Developer/Encryption/FieldLevelEncryption.php

@@ -12,6 +12,10 @@
  */
 class FieldLevelEncryption {
 
+    private function __construct() {
+        // This class can't be instantiated
+    }
+
     /**
      * Encrypt parts of a JSON payload using the given parameters and configuration.
      * @param $payload A JSON string

src/Developer/Encryption/FieldLevelEncryptionConfigBuilder.php

@@ -13,6 +13,10 @@
  */
 class FieldLevelEncryptionConfigBuilder {
 
+    private function __construct() {
+        // This class can't be instantiated
+    }
+
     private $encryptionCertificate;
     private $encryptionCertificateFingerprint;
     private $encryptionKeyFingerprint;

src/Developer/Json/JsonPath.php

@@ -16,6 +16,10 @@ class JsonPath {
     const FIRST_CHILD_KEY = "/(?:\[')([^\[\]]*)(?:'\])/"; // Returns "obj1" for "$['obj1']['obj2']"
     const FIRST_TOKEN_IN_PATH = "/(\['[^\[\]]*'\])/";     // Returns "['obj1']" for "$['obj1']['obj2']"
 
+    private function __construct() {
+        // This class can't be instantiated
+    }
+
     /**
      * Convert the given JSON path to the following form: $['path']['to']['object'].
      * @throws \InvalidArgumentException
@@ -53,7 +57,7 @@ static function find($jsonObject, $path) {
         $currentElement = $jsonObject;
         while ($currentPath !== '$') {
             preg_match(self::FIRST_CHILD_KEY, $currentPath, $matches);
-            if (sizeof($matches).isEmpty()) {
+            if (empty($matches)) {
                 return null;
             }
             $childKey = $matches[1];

src/Developer/Utils/EncodingUtils.php

@@ -5,6 +5,10 @@
 
 class EncodingUtils {
 
+    private function __construct() {
+        // This class can't be instantiated
+    }
+
     static function encodeBytes($bytes, $encoding) {
         return $encoding === FieldValueEncoding::HEX ? self::hexEncode($bytes) : base64_encode($bytes);
     }

src/Developer/Utils/EncryptionUtils.php

@@ -14,6 +14,10 @@ class EncryptionUtils {
     const PKCS_8_PEM_HEADER = '-----BEGIN PRIVATE KEY-----';
     const PKCS_8_PEM_FOOTER = '-----END PRIVATE KEY-----';
 
+    private function __construct() {
+        // This class can't be instantiated
+    }
+
     /**
      * Create an X.509 resource from the certificate data at the given file path.
      * @throws \InvalidArgumentException