Added Python 3.9, migrated workflow to SonarSource/sonarcloud-github-action, fixed warning with shallow clones

Author: jaaufauvre

.github/workflows/sonar.yml

@@ -1,45 +1,39 @@
 name: Sonar
-
-on:
+'on':
   push:
-    branches: [ master ]
-  pull_request:
-    branches: [ master ]
-
+    branches:
+      - master
+  pull_request_target:
+    types:
+      - opened
+      - synchronize
+      - reopened
+  schedule:
+    - cron: 0 16 * * *
 jobs:
-  build:
-    env:
-      SONAR_SCANNER_VERSION: 3.3.0.1492
+  sonarcloud:
+    name: Sonar
     runs-on: ubuntu-latest
-
     steps:
-    - uses: actions/checkout@v2
-    - name: Set up Python 3.8
-      uses: actions/setup-python@v2
-      with:
-        python-version: 3.8
-    - name: Install dependencies
-      run: |
-        pip3 install -r requirements.txt
-        pip3 install .
-        pip3 install coverage
-        wget https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-$SONAR_SCANNER_VERSION.zip
-        unzip sonar-scanner-cli-$SONAR_SCANNER_VERSION.zip
-    - name: Run Tests
-      run: |
-        coverage run setup.py test
-        coverage xml
-    - name: Sonar
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
-      run: |
-        sonar-scanner-$SONAR_SCANNER_VERSION/bin/sonar-scanner \
-          -Dsonar.projectName=client-encryption-python \
-          -Dsonar.projectKey=Mastercard_client-encryption-python \
-          -Dsonar.organization=mastercard  \
-          -Dsonar.sources=./client_encryption \
-          -Dsonar.tests=./tests \
-          -Dsonar.python.coverage.reportPaths=coverage.xml \
-          -Dsonar.host.url=https://sonarcloud.io \
-          -Dsonar.login=$SONAR_TOKEN
+      - uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+      - name: Set up Python 3.8
+        uses: actions/setup-python@v2
+        with:
+          python-version: 3.8
+      - name: Install dependencies
+        run: |
+          pip3 install -r requirements.txt
+          pip3 install .
+          pip3 install coverage
+      - name: Run Tests
+        run: |
+          coverage run setup.py test
+          coverage xml
+      - name: SonarCloud Scan
+        uses: SonarSource/sonarcloud-github-action@master
+        env:
+          GITHUB_TOKEN: '${{ secrets.GITHUB_TOKEN }}'
+          SONAR_TOKEN: '${{ secrets.SONAR_TOKEN }}'
+          

.github/workflows/test.yml

@@ -4,19 +4,20 @@ on:
   push:
     branches: [ master ]
   pull_request:
-    branches: [ master ]
+    types: [opened, synchronize, reopened]
+  schedule:
+    - cron: "0 16 * * *"
 
 jobs:
   build:
-    env:
-      SONAR_SCANNER_VERSION: 3.3.0.1492
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.6, 3.7, 3.8]
-
+        python-version: [3.6, 3.7, 3.8, 3.9]
     steps:
     - uses: actions/checkout@v2
+      with:
+        fetch-depth: 0
     - name: Set up Python ${{ matrix.python-version }}
       uses: actions/setup-python@v2
       with:

sonar-project.properties

@@ -0,0 +1,7 @@
+sonar.projectKey=Mastercard_client-encryption-python
+sonar.organization=mastercard
+sonar.projectName=client-encryption-python
+sonar.sources=./client_encryption
+sonar.tests=./tests
+sonar.python.coverage.reportPaths=coverage.xml
+sonar.host.url=https://sonarcloud.io