Skip to content

Commit 24b3af1

Browse files
Fixing the secrity issuesi
Updating to Spring 6.2.8 Fixing unit tests
1 parent 4ce29ef commit 24b3af1

File tree

2 files changed

+33
-5
lines changed

2 files changed

+33
-5
lines changed

pom.xml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<name>oauth1-signer</name>
1414

1515
<properties>
16-
<spring-version>5.3.33</spring-version>
16+
<spring-version>6.2.8</spring-version>
1717
<spring-webflux-version>3.5.3</spring-webflux-version>
1818
<okhttp2-version>2.7.5</okhttp2-version>
1919
<okhttp3-version>4.12.0</okhttp3-version>
@@ -224,6 +224,14 @@
224224
<publishingServerId>central</publishingServerId>
225225
</configuration>
226226
</plugin>
227+
<plugin>
228+
<groupId>org.apache.maven.plugins</groupId>
229+
<artifactId>maven-compiler-plugin</artifactId>
230+
<configuration>
231+
<source>9</source>
232+
<target>9</target>
233+
</configuration>
234+
</plugin>
227235
</plugins>
228236
</build>
229237
</project>

src/test/java/com/mastercard/developer/signers/SpringHttpRequestSignerTest.java

Lines changed: 24 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import org.junit.Test;
1515

1616
import java.security.PrivateKey;
17+
import java.util.Map;
1718

1819
public class SpringHttpRequestSignerTest {
1920

@@ -38,14 +39,19 @@ public void initialize() throws Exception {
3839
public HttpMethod getMethod(){
3940
return POST_METHOD;
4041
}
41-
@Override
4242
public String getMethodValue(){
4343
return getMethod().toString();
4444
}
4545
@Override
4646
public URI getURI(){
4747
return uri;
4848
}
49+
50+
@Override
51+
public Map<String, Object> getAttributes() {
52+
return Map.of();
53+
}
54+
4955
@Override
5056
public HttpHeaders getHeaders(){
5157
return headers;
@@ -104,14 +110,19 @@ public void testSignShouldAddOAuth1HeaderToGetRequestNullBody() {
104110
public HttpMethod getMethod(){
105111
return GET_METHOD;
106112
}
107-
@Override
108113
public String getMethodValue(){
109114
return getMethod().toString();
110115
}
111116
@Override
112117
public URI getURI(){
113118
return uri;
114119
}
120+
121+
@Override
122+
public Map<String, Object> getAttributes() {
123+
return Map.of();
124+
}
125+
115126
@Override
116127
public HttpHeaders getHeaders(){
117128
return headers;
@@ -136,14 +147,19 @@ public void testSignShouldAddOAuth1HeaderToGetRequestEmptyBody() {
136147
public HttpMethod getMethod(){
137148
return GET_METHOD;
138149
}
139-
@Override
140150
public String getMethodValue(){
141151
return getMethod().toString();
142152
}
143153
@Override
144154
public URI getURI(){
145155
return uri;
146156
}
157+
158+
@Override
159+
public Map<String, Object> getAttributes() {
160+
return Map.of();
161+
}
162+
147163
@Override
148164
public HttpHeaders getHeaders(){
149165
return headers;
@@ -164,11 +180,15 @@ public void testSign_ShouldThrowIllegalStateException_WhenNullHttpMethod() {
164180

165181
// GIVEN
166182
request = new HttpRequest() {
183+
@Override
184+
public Map<String, Object> getAttributes() {
185+
return Map.of();
186+
}
187+
167188
@Override
168189
public HttpMethod getMethod(){
169190
return null;
170191
}
171-
@Override
172192
public String getMethodValue(){
173193
return "something";
174194
}

0 commit comments

Comments
 (0)