Skip to content

Commit dcc2b00

Browse files
Merge pull request #11 from MastercardDevs/master
Fix encoding error for post, increment version to 1.1.1
2 parents 1d4da98 + 1c28a35 commit dcc2b00

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

oauth1/coreutils.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -120,11 +120,7 @@ def uri_rfc3986_encode(value):
120120
"""
121121
RFC 3986 encodes the value
122122
"""
123-
encoded = quote_plus(value)
124-
encoded = str.replace(encoded, ':', '%3A')
125-
encoded = str.replace(encoded, '+', '%2B')
126-
encoded = str.replace(encoded, '*', '%2A')
127-
return encoded
123+
return quote(value, safe='%')
128124

129125

130126
def sha256_encode(text):

oauth1/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
#!/usr/bin/env python
22
# -*- coding: utf-8 -*-
3-
__version__ = '1.0.1'
3+
__version__ = '1.1.1'

tests/test_oauth.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ def test_signature_base_string2(self):
226226

227227
base_string = OAuth.get_base_string(url, method, oauth_parameters, oauth_parameters.get_base_parameters_dict())
228228

229-
expected = "POST&https%3A%2F%2Fsandbox.api.mastercard.com%2Ffraud%2Fmerchant%2Fv1%2Ftermination-inquiry&Format%3DXML%26PageLength%3D10%26PageOffset%3D0%26oauth_body_hash%3Dh2Pd7zlzEZjZVIKB4j94UZn%2FxxoR3RoCjYQ9%2FJdadGQ%253D%26oauth_consumer_key%3Dxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx%26oauth_nonce%3D1111111111111111111%26oauth_timestamp%3D1111111111%26oauth_version%3D1.0"
229+
expected = "POST&https%3A%2F%2Fsandbox.api.mastercard.com%2Ffraud%2Fmerchant%2Fv1%2Ftermination-inquiry&Format%3DXML%26PageLength%3D10%26PageOffset%3D0%26oauth_body_hash%3Dh2Pd7zlzEZjZVIKB4j94UZn%2FxxoR3RoCjYQ9%2FJdadGQ%3D%26oauth_consumer_key%3Dxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx%26oauth_nonce%3D1111111111111111111%26oauth_timestamp%3D1111111111%26oauth_version%3D1.0"
230230

231231
self.maxDiff = None
232232
self.assertEqual(expected, base_string);

0 commit comments

Comments
 (0)