Merge pull request #142 from Masterminds/audio-tag

goetas · web-flow · commit 7c2568570431 · 2018-10-22T07:50:38.000+02:00
[bugfix] Audio is not a block tag
diff --git a/src/HTML5/Elements.php b/src/HTML5/Elements.php
@@ -83,7 +83,7 @@ class Elements
         "area" => 9, // NORMAL | VOID_TAG
         "article" => 81, // NORMAL | AUTOCLOSE_P | BLOCK_TAG
         "aside" => 81, // NORMAL | AUTOCLOSE_P | BLOCK_TAG
-        "audio" => 65, // NORMAL | BLOCK_TAG
+        "audio" => 1, // NORMAL
         "b" => 1,
         "base" => 9, // NORMAL | VOID_TAG
         "bdi" => 1,
diff --git a/test/HTML5/ElementsTest.php b/test/HTML5/ElementsTest.php
@@ -393,7 +393,6 @@ public function testIsA()
             'address',
             'article',
             'aside',
-            'audio',
             'blockquote',
             'canvas',
             'dd',
diff --git a/test/HTML5/Parser/DOMTreeBuilderTest.php b/test/HTML5/Parser/DOMTreeBuilderTest.php
@@ -679,4 +679,30 @@ public function testIgnoreSelfClosingTag() {
         $dom = $this->parse($html);
         $this->assertSame(1, $dom->getElementsByTagName('div')->item(0)->childNodes->length);
     }
+
+    public function testIAudioInParagraph() {
+        $html = <<<EOM
+<!DOCTYPE html>
+<html>
+    <head>
+        <title>testIllegalSelfClosingTag</title>
+    </head>
+    <body>
+    <p>
+        <audio preload="none" controls="controls">
+            <source src="https://example.com/test.mp3" type="audio/mpeg" />
+            Your browser does not support the audio element.
+        </audio>
+     </p>
+    </body>
+</html>>
+</html>
+EOM;
+
+        $dom = $this->parse($html);
+        $audio = $dom->getElementsByTagName('audio')->item(0);
+
+        $this->assertSame('p', $audio->parentNode->nodeName);
+        $this->assertSame(3, $audio->childNodes->length);
+    }
 }
