Fixed memory leak in HTML5::saveHTML()

lyrixx · lyrixx · commit be8e9cdf2d33 · 2020-06-30T18:00:52.000+02:00
diff --git a/src/HTML5.php b/src/HTML5.php
@@ -234,6 +234,10 @@ public function saveHTML($dom, $options = array())
         $stream = fopen('php://temp', 'wb');
         $this->save($dom, $stream, array_merge($this->defaultOptions, $options));
 
-        return stream_get_contents($stream, -1, 0);
+        $html = stream_get_contents($stream, -1, 0);
+
+        fclose($stream);
+
+        return $html;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -234,6 +234,10 @@ public function saveHTML($dom, $options = array())`
`234`	`234`	`$stream = fopen('php://temp', 'wb');`
`235`	`235`	`$this->save($dom, $stream, array_merge($this->defaultOptions, $options));`
`236`	`236`
`237`		`- return stream_get_contents($stream, -1, 0);`
	`237`	`+ $html = stream_get_contents($stream, -1, 0);`
	`238`	`+`
	`239`	`+ fclose($stream);`
	`240`	`+`
	`241`	`+ return $html;`
`238`	`242`	`}`
`239`	`243`	`}`