Merge pull request #119 from Masterminds/vkunz-fix_empty_optgroup-2x

goetas · web-flow · commit dea4bab6675b · 2016-09-22T12:43:04.000+02:00
fix parsing of options of an optgroup
diff --git a/src/HTML5/Parser/TreeBuildingRules.php b/src/HTML5/Parser/TreeBuildingRules.php
@@ -76,7 +76,6 @@ public function evaluate($new, $current)
             case 'option':
                 return $this->closeIfCurrentMatches($new, $current, array(
                     'option',
-                    'optgroup'
                 ));
             case 'tr':
                 return $this->closeIfCurrentMatches($new, $current, array(
diff --git a/test/HTML5/Parser/DOMTreeBuilderTest.php b/test/HTML5/Parser/DOMTreeBuilderTest.php
@@ -540,4 +540,33 @@ public function testInstructionProcessor()
         $this->assertEquals('div', $div->tagName);
         $this->assertEquals('foo', $div->textContent);
     }
+
+    public function testSelectGroupedOptions()
+    {
+        $html = <<<EOM
+<!DOCTYPE html>
+<html>
+    <head>
+        <title>testSelectGroupedOptions</title>
+    </head>
+    <body>
+        <select>
+            <optgroup id="first" label="first">
+                <option value="foo">foo</option>
+                <option value="bar">bar</option>
+                <option value="baz">baz</option>
+            </optgroup>
+            <optgroup id="second" label="second">
+                <option value="lorem">lorem</option>
+                <option value="ipsum">ipsum</option>
+            </optgroup>
+         </select>
+    </body>
+</html>
+EOM;
+        $dom  = $this->parse($html);
+
+        $this->assertSame(3, $dom->getElementById('first')->getElementsByTagName('option')->length);
+        $this->assertSame(2, $dom->getElementById('second')->getElementsByTagName('option')->length);
+    }
 }
diff --git a/test/HTML5/Parser/TreeBuildingRulesTest.php b/test/HTML5/Parser/TreeBuildingRulesTest.php
@@ -90,6 +90,19 @@ public function testHandleDT()
         $this->assertEquals('dd', $list->lastChild->tagName);
     }
 
+    public function testHandleOptionGroupAndOption()
+    {
+        $html = sprintf(self::HTML_STUB, '<optgroup id="foo" label="foo" ><option value="foo">bar</option></optgroup>');
+        $doc = $this->parse($html);
+
+        $list = $doc->getElementById('foo');
+
+        $this->assertEquals(1, $list->childNodes->length);
+
+        $option = $list->childNodes->item(0);
+        $this->assertEquals('option', $option->tagName);
+    }
+
     public function testTable()
     {
         $html = sprintf(self::HTML_STUB, '<table><thead id="a"><th>foo<td>bar<td>baz');
