Merge pull request #861 from Mastermindzh/master

update from master

Author: Mastermindzh

.github/workflows/build.yml

@@ -30,3 +30,18 @@ jobs:
       #   with:
       #     name: linux-builds
       #     path: dist/
+
+  build_on_mac:
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@master
+      - uses: actions/setup-node@master
+        with:
+          node-version: 24.12.0
+      - run: npm install
+      - run: npm run lint
+      - run: npm run build-mac
+      # - uses: actions/upload-artifact@master
+      #   with:
+      #     name: mac-builds
+      #     path: dist/

.github/workflows/release.yml

@@ -26,3 +26,39 @@ jobs:
         with:
           name: linux-builds
           path: dist/
+
+  build_on_mac:
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@master
+      - uses: actions/setup-node@master
+        with:
+          node-version: 24.12.0
+      - run: npm install
+      - run: npm run build-mac
+      - uses: actions/upload-artifact@master
+        with:
+          name: mac-builds
+          path: dist/
+
+  build_and_publish_snap:
+    runs-on: ubuntu-latest
+    if: github.ref == 'refs/heads/master'
+    steps:
+      - name: update apt
+        run: sudo apt-get update
+      - name: Install libarchive-tools
+        run: sudo apt-get install -y libarchive-tools
+      - uses: actions/checkout@master
+      - uses: actions/setup-node@master
+        with:
+          node-version: 24.12.0
+      - run: npm install
+      - run: npm run build-snap
+      - name: Publish to Snap Store
+        uses: canonical/action-publish@v1
+        env:
+          SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.SNAPCRAFT_STORE_CREDENTIALS }}
+        with:
+          snap: dist/tidal-hifi_*.snap
+          release: stable

.vscode/settings.json

@@ -37,6 +37,7 @@
     "seekbackward",
     "seekforward",
     "seekto",
+    "SNAPCRAFT",
     "throughs",
     "trackid",
     "tracklist",

CHANGELOG.md

@@ -4,6 +4,30 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [6.2.0]
+
+### Added
+
+- Added configurable sandbox disable flag to fix login white screen issues
+  - Defaults to enabled (sandbox disabled) to prevent login issues for new users
+  - Applies the `--no-sandbox` Electron flag when enabled
+
+### Changed
+
+- Upgraded to widevine 40.
+- Transparency of the window is disabled on Mac to better facilitate the menu bar
+  - [pr](https://github.com/Mastermindzh/tidal-hifi/pull/839) by [Ghoelian](https://github.com/Ghoelian)
+  - Ghoelian also verified that mac builds are working again so I've re-enabled those too.
+
+### Fixed
+
+- Fixed white screen issue during login process caused by sandbox restrictions
+- Improved flag system logging and early Logger initialization
+
+- **TEMP** When playing videos or uploaded songs the mpris integration broke.
+  - I have temporarily implemented a workaround that allows it to *restart* after crashing on songs it does support
+  - Mpris breaks on "syscall -> write" which is now logged and can be looked into at a later date.
+
 ## [6.1.0]
 
 ### Added

README.md

@@ -159,7 +159,7 @@ Integrations with other projects that are not included natively:
 
 ## Known bugs
 
-Please check the [Knows issues file](./docs/known-issues.md).
+Please check the [Known issues file](./docs/known-issues.md).
 
 ## Special thanks to
 

biome.json

@@ -1,5 +1,5 @@
 {
-  "$schema": "https://biomejs.dev/schemas/2.3.11/schema.json",
+  "$schema": "https://biomejs.dev/schemas/2.4.4/schema.json",
   "vcs": {
     "enabled": true,
     "clientKind": "git",

build/electron-builder.base.yml

@@ -1,7 +1,7 @@
 appId: com.rickvanlieshout.tidal-hifi
-electronVersion: 39.2.4
+electronVersion: 40.1.0
 electronDownload:
-  version: 39.2.4+wvcus
+  version: v40.1.0+wvcus
   mirror: https://github.com/castlabs/electron-releases/releases/download/v
 snap:
   plugs:

docs/images/disable-sandbox.png

@@ -9,6 +9,7 @@ This document lists known bugs and issues with Tidal Hi-Fi along with workaround
 - [Known Issues](#known-issues)
   - [Table of Contents](#table-of-contents)
   - [White screen on login/launch](#white-screen-on-loginlaunch)
+    - [Advanced setting](#advanced-setting)
   - [Subscribe button showing and/or account details not working](#subscribe-button-showing-andor-account-details-not-working)
   - [DRM not working on Windows (error S6007)](#drm-not-working-on-windows-error-s6007)
   - [Discord RPC not working with Flatpak and native Discord](#discord-rpc-not-working-with-flatpak-and-native-discord)
@@ -18,9 +19,9 @@ This document lists known bugs and issues with Tidal Hi-Fi along with workaround
 
 ## White screen on login/launch
 
-Some users may experience a white screen when launching Tidal Hi-Fi or during the login process. This is typically caused by security restrictions in the underlying Chromium engine.
+Some users may experience a white screen when launching Tidal Hi-Fi or during the login process. This is typically caused by security restrictions in the underlying Chromium engine. You can disable it permanently in the settings or following the steps below:
 
-**Fix**: Run Tidal Hi-Fi from the command line with the `--no-sandbox` flag:
+**Fix**: Run Tidal Hi-Fi from the command line with the `--no-sandbox` or `--disable-seccomp-filter-sandbox` flag:
 
 ```bash
 tidal-hifi --no-sandbox
@@ -32,6 +33,13 @@ For different installation methods:
 - **Flatpak**: `flatpak run com.mastermindzh.tidal-hifi --no-sandbox`
 - **From source**: `npm start -- --no-sandbox`
 
+### Advanced setting
+
+Under "Advanced" in the settings menu you'll find a section to toggle flags, there you can also toggle the sandbox flag.
+The default value of this flag is "true", which means the sandbox is disabled.
+
+![The flag as shown in the settings window](./images/disable-sandbox.png)
+
 ## Subscribe button showing and/or account details not working
 
 If you see a "Subscribe" button or notice that account-related features aren't working properly, this is likely due to the built-in ad blocker being too aggressive.