Fix flaky test (#3381)

Also fixes some tests that were always outputting screenshots on success.

Author: Keboo

MaterialDesignThemes.UITests/AllStyles.cs

@@ -83,5 +83,7 @@ await App.Initialize(applicationResourceXaml,
             """);
 
         Assert.True(await window.GetIsVisible());
+
+        recorder.Success();
     }
 }

MaterialDesignThemes.UITests/WPF/AutoSuggestBoxes/AutoSuggestTextBoxTests.cs

@@ -60,10 +60,23 @@ public async Task CanChoiceItem_FromTheSuggestions_AssertTheTextUpdated()
         Assert.True(await suggestBox.GetIsSuggestionOpen());
         Assert.True(await popup.GetIsOpen());
 
+        double? lastHeight = null;
+        await Wait.For(async () =>
+        {
+            double currentHeight = await suggestionListBox.GetActualHeight();
+
+            bool rv = currentHeight == lastHeight && currentHeight > 50;
+            lastHeight = currentHeight;
+            if (!rv)
+            {
+                await Task.Delay(100);
+            }
+            return rv;
+        });
+
         //Choose Item from the list
-        await Task.Delay(200);
         var bananas = await suggestionListBox.GetElement<ListBoxItem>("/ListBoxItem[0]");
-        await Wait.For(async () => await bananas.GetIsVisible());
+        await recorder.SaveScreenshot("BeforeClick");
         await bananas.LeftClick();
         var suggestBoxText = await suggestBox.GetText();
         //Validate that the current text is the same as the selected item

MaterialDesignThemes.UITests/WPF/TextBoxes/TextBoxTests.cs

@@ -610,6 +610,8 @@ await Wait.For(async() =>
 
             Assert.Equal("Some error + more", await textBlock.GetText());
         });
+
+        recorder.Success();
     }
 }
 

MaterialDesignThemes.Wpf/AutoSuggestBox.cs

@@ -10,12 +10,8 @@ public class AutoSuggestBox : TextBox
 {
     private const string AutoSuggestBoxListPart = "PART_AutoSuggestBoxList";
 
-    #region Properties
-
     protected ListBox? _autoSuggestBoxList;
 
-    #endregion
-
     #region Dependency Properties
 
     public IEnumerable Suggestions