Skip to content

Commit 28c6a8d

Browse files
authored
Fix code style issues (#3626)
MaterialDesignThemes.Wpf/Automation /Behaviours /Converters/CircularProgressBar
1 parent 9ef05e0 commit 28c6a8d

File tree

7 files changed

+28
-67
lines changed

7 files changed

+28
-67
lines changed

src/MaterialDesignThemes.Wpf/Automation/Peers/TreeListViewItemAutomationPeer.cs

Lines changed: 5 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,16 @@
11
using System.Windows.Automation.Peers;
2-
using System.Windows.Automation.Provider;
32

43
namespace MaterialDesignThemes.Wpf.Automation.Peers;
54

6-
public class TreeListViewAutomationPeer : ListViewAutomationPeer
5+
public class TreeListViewAutomationPeer(TreeListView owner) : ListViewAutomationPeer(owner)
76
{
8-
public TreeListViewAutomationPeer(TreeListView owner) : base(owner)
9-
{
10-
}
11-
127
protected override AutomationControlType GetAutomationControlTypeCore() => AutomationControlType.Tree;
138

149
protected override string GetClassNameCore() => "TreeListView";
1510

1611
protected override List<AutomationPeer>? GetChildrenCore()
1712
{
18-
ItemsControl owner = (ItemsControl)Owner;
13+
var owner = (ItemsControl)Owner;
1914
ItemCollection items = owner.Items;
2015
List<AutomationPeer>? children = null;
2116

@@ -24,7 +19,7 @@ public TreeListViewAutomationPeer(TreeListView owner) : base(owner)
2419
children = new List<AutomationPeer>(items.Count);
2520
for (int i = 0; i < items.Count; i++)
2621
{
27-
TreeListViewItem? treeViewItem = owner.ItemContainerGenerator.ContainerFromIndex(i) as TreeListViewItem;
22+
var treeViewItem = owner.ItemContainerGenerator.ContainerFromIndex(i) as TreeListViewItem;
2823
//We grab top level items only
2924
if (treeViewItem is { Level: 0 })
3025
{
@@ -35,20 +30,11 @@ public TreeListViewAutomationPeer(TreeListView owner) : base(owner)
3530
return children;
3631
}
3732

38-
protected override ItemAutomationPeer CreateItemAutomationPeer(object item)
39-
{
40-
return new TreeListViewItemAutomationPeer(item, this);
41-
}
33+
protected override ItemAutomationPeer CreateItemAutomationPeer(object item) => new TreeListViewItemAutomationPeer(item, this);
4234
}
4335

44-
public class TreeListViewItemAutomationPeer : ListBoxItemAutomationPeer
36+
public class TreeListViewItemAutomationPeer(object owner, SelectorAutomationPeer selectorAutomationPeer) : ListBoxItemAutomationPeer(owner, selectorAutomationPeer)
4537
{
46-
public TreeListViewItemAutomationPeer(object owner, SelectorAutomationPeer selectorAutomationPeer)
47-
: base(owner, selectorAutomationPeer)
48-
{
49-
50-
}
51-
5238
protected override List<AutomationPeer> GetChildrenCore()
5339
{
5440
List<AutomationPeer> rv = base.GetChildrenCore();

src/MaterialDesignThemes.Wpf/Behaviors/PasswordBoxBehavior.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ private void PasswordBoxPreviewGotKeyboardFocus(object sender, KeyboardFocusChan
1414
if (ReferenceEquals(e.OldFocus, revealPasswordTextBox) && ReferenceEquals(e.NewFocus, AssociatedObject))
1515
{
1616
// When password box receives keyboard focus, but it came from the nested reveal TextBox. We request focus transfer to the previous element from the password box's POV
17-
TraversalRequest request = new TraversalRequest(FocusNavigationDirection.Previous);
17+
TraversalRequest request = new(FocusNavigationDirection.Previous);
1818
AssociatedObject.MoveFocus(request);
1919
e.Handled = true;
2020
}

src/MaterialDesignThemes.Wpf/Converters/CircularProgressBar/ArcEndPointConverter.cs

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -15,41 +15,38 @@ public class ArcEndPointConverter : IMultiValueConverter
1515

1616
public object Convert(object[] values, Type targetType, object parameter, CultureInfo culture)
1717
{
18-
var actualWidth = values[0].ExtractDouble();
19-
var value = values[1].ExtractDouble();
20-
var minimum = values[2].ExtractDouble();
21-
var maximum = values[3].ExtractDouble();
18+
double actualWidth = values[0].ExtractDouble();
19+
double value = values[1].ExtractDouble();
20+
double minimum = values[2].ExtractDouble();
21+
double maximum = values[3].ExtractDouble();
2222

2323
if (new[] { actualWidth, value, minimum, maximum }.AnyNan())
2424
return Binding.DoNothing;
2525

2626
if (values.Length == 5)
2727
{
28-
var fullIndeterminateScaling = values[4].ExtractDouble();
28+
double fullIndeterminateScaling = values[4].ExtractDouble();
2929
if (!double.IsNaN(fullIndeterminateScaling) && fullIndeterminateScaling > 0.0)
3030
{
3131
value = (maximum - minimum) * fullIndeterminateScaling;
3232
}
3333
}
3434

35-
var percent = maximum <= minimum ? 1.0 : (value - minimum) / (maximum - minimum);
35+
double percent = maximum <= minimum ? 1.0 : (value - minimum) / (maximum - minimum);
3636
if (Equals(parameter, ParameterMidPoint))
3737
percent /= 2;
3838

39-
var degrees = 360 * percent;
40-
var radians = degrees * (Math.PI / 180);
39+
double degrees = 360 * percent;
40+
double radians = degrees * (Math.PI / 180);
4141

4242
var centre = new Point(actualWidth / 2, actualWidth / 2);
43-
var hypotenuseRadius = (actualWidth / 2);
43+
double hypotenuseRadius = (actualWidth / 2);
4444

45-
var adjacent = Math.Cos(radians) * hypotenuseRadius;
46-
var opposite = Math.Sin(radians) * hypotenuseRadius;
45+
double adjacent = Math.Cos(radians) * hypotenuseRadius;
46+
double opposite = Math.Sin(radians) * hypotenuseRadius;
4747

4848
return new Point(centre.X + opposite, centre.Y - adjacent);
4949
}
5050

51-
public object[] ConvertBack(object value, Type[] targetTypes, object parameter, CultureInfo culture)
52-
{
53-
throw new NotImplementedException();
54-
}
51+
public object[] ConvertBack(object value, Type[] targetTypes, object parameter, CultureInfo culture) => throw new NotImplementedException();
5552
}

src/MaterialDesignThemes.Wpf/Converters/CircularProgressBar/ArcSizeConverter.cs

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,7 @@ namespace MaterialDesignThemes.Wpf.Converters.CircularProgressBar;
66
public class ArcSizeConverter : IValueConverter
77
{
88
public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
9-
{
10-
if (value is double && ((double)value > 0.0))
11-
{
12-
return new Size((double)value / 2, (double)value / 2);
13-
}
9+
=> value is double v && (v > 0.0) ? new Size(v / 2, v / 2) : new Point();
1410

15-
return new Point();
16-
}
17-
18-
public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
19-
{
20-
return Binding.DoNothing;
21-
}
11+
public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture) => Binding.DoNothing;
2212
}

src/MaterialDesignThemes.Wpf/Converters/CircularProgressBar/LocalEx.cs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,10 @@ internal static class LocalEx
44
{
55
public static double ExtractDouble(this object value)
66
{
7-
var d = value as double? ?? double.NaN;
7+
double d = value as double? ?? double.NaN;
88
return double.IsInfinity(d) ? double.NaN : d;
99
}
1010

1111

12-
public static bool AnyNan(this IEnumerable<double> values)
13-
{
14-
return values.Any(double.IsNaN);
15-
}
12+
public static bool AnyNan(this IEnumerable<double> values) => values.Any(double.IsNaN);
1613
}

src/MaterialDesignThemes.Wpf/Converters/CircularProgressBar/RotateTransformCentreConverter.cs

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,8 @@ namespace MaterialDesignThemes.Wpf.Converters.CircularProgressBar;
55

66
public class RotateTransformCentreConverter : IValueConverter
77
{
8-
public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
9-
{
10-
//value == actual width
11-
return (double)value / 2;
12-
}
8+
public object Convert(object value, Type targetType, object parameter, CultureInfo culture) =>
9+
(double)value / 2; //value == actual width
1310

14-
public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
15-
{
16-
return Binding.DoNothing;
17-
}
11+
public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture) => Binding.DoNothing;
1812
}

src/MaterialDesignThemes.Wpf/Converters/CircularProgressBar/StartPointConverter.cs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,15 @@ public class StartPointConverter : IValueConverter
88
[Obsolete]
99
public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
1010
{
11-
if (value is double && ((double)value > 0.0))
11+
if (value is double v && (v > 0.0))
1212
{
13-
return new Point((double)value / 2, 0);
13+
return new Point(v / 2, 0);
1414
}
1515

1616
return new Point();
1717
}
1818

1919
[Obsolete]
20-
public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
21-
{
22-
return Binding.DoNothing;
23-
}
20+
public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture) => Binding.DoNothing;
2421

2522
}

0 commit comments

Comments
 (0)