Another run at flaky tests (#3389)

Also rev'ing NuGets

Author: Keboo

Directory.packages.props

@@ -9,8 +9,8 @@
     <PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" PrivateAssets="all" />
     <PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="4.8.0" />
     <PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.8.0" />
-    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0" />
-    <PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.7.0" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.8.0" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.8.0" />
     <PackageVersion Include="Microsoft.Composition" Version="1.0.31" />
     <PackageVersion Include="Microsoft.CSharp" Version="4.7.0" />
     <PackageVersion Include="Microsoft.NETCore.Platforms" Version="7.0.4" />

MaterialDesignThemes.UITests/WPF/AutoSuggestBoxes/AutoSuggestTextBoxTests.cs

@@ -9,6 +9,7 @@ public class AutoSuggestBoxTests : TestBase
     public AutoSuggestBoxTests(ITestOutputHelper output)
         : base(output)
     {
+        AttachedDebuggerToRemoteProcess = true;
     }
 
     [Fact]
@@ -76,6 +77,7 @@ await Wait.For(async () =>
 
         //Choose Item from the list
         var bananas = await suggestionListBox.GetElement<ListBoxItem>("/ListBoxItem[0]");
+        await bananas.MoveCursorTo();
         await recorder.SaveScreenshot("BeforeClick");
         await bananas.LeftClick();
         var suggestBoxText = await suggestBox.GetText();

MaterialDesignThemes.Wpf/AutoSuggestBox.cs

@@ -132,12 +132,15 @@ public event RoutedPropertyChangedEventHandler<object> SuggestionChosen
 
     public override void OnApplyTemplate()
     {
+        if (_autoSuggestBoxList is not null)
+        {
+            _autoSuggestBoxList.PreviewMouseDown -= AutoSuggestionListBox_PreviewMouseDown;
+        }
+
         if (GetTemplateChild(AutoSuggestBoxListPart) is ListBox listBox)
         {
             _autoSuggestBoxList = listBox;
 
-            listBox.PreviewMouseDown -= AutoSuggestionListBox_PreviewMouseDown;
-
             base.OnApplyTemplate();
 
             listBox.PreviewMouseDown += AutoSuggestionListBox_PreviewMouseDown;
@@ -195,39 +198,57 @@ private void AutoSuggestionListBox_PreviewMouseDown(object sender, MouseButtonEv
     {
         if (_autoSuggestBoxList is not null && e.OriginalSource is FrameworkElement element)
         {
-            if (!_autoSuggestBoxList.Items.Contains(element.DataContext))
+            var selectedItem = element.DataContext;
+            if (!_autoSuggestBoxList.Items.Contains(selectedItem))
                 return;
-            _autoSuggestBoxList.SelectedItem = element.DataContext;
-            CommitValueSelection();
+            if (_autoSuggestBoxList.SelectedItem != selectedItem)
+            {
+                _autoSuggestBoxList.SelectionChanged += OnSelectionChanged;
+                _autoSuggestBoxList.SelectedItem = selectedItem;
+            }
+            else
+            {
+                _autoSuggestBoxList.SelectedItem = selectedItem;
+                CommitValueSelection();
+            }
+
+            void OnSelectionChanged(object sender, SelectionChangedEventArgs e)
+            {
+                _autoSuggestBoxList.SelectionChanged -= OnSelectionChanged;
+                CommitValueSelection();
+            }
+            e.Handled = true;
         }
     }
 
+
+
     #endregion
 
-    #region Methods    
+    #region Methods
 
     private void CloseAutoSuggestionPopUp()
     {
         IsSuggestionOpen = false;
     }
 
     private void CommitValueSelection()
+        => CommitValueSelection(_autoSuggestBoxList?.SelectedValue);
+
+    private void CommitValueSelection(object? selectedValue)
     {
-        if (_autoSuggestBoxList?.SelectedValue is { } selectedValue)
+        string oldValue = Text;
+        Text = selectedValue?.ToString();
+        if (Text != null)
         {
-            var oldValue = Text;
-            Text = selectedValue.ToString();
-            if (Text != null)
-            {
-                CaretIndex = Text.Length;
-            }
-            CloseAutoSuggestionPopUp();
-            var args = new RoutedPropertyChangedEventArgs<object?>(oldValue, Text)
-            {
-                RoutedEvent = SuggestionChosenEvent
-            };
-            RaiseEvent(args);
+            CaretIndex = Text.Length;
         }
+        CloseAutoSuggestionPopUp();
+        var args = new RoutedPropertyChangedEventArgs<object?>(oldValue, Text)
+        {
+            RoutedEvent = SuggestionChosenEvent
+        };
+        RaiseEvent(args);
     }
 
     private void DecrementSelection()