Code Suggestion for #3736

#3736

I added some suggestions as a cloud patch (let me know if you have any trouble viewing it).

Some key changes here:
1. You can access the environment variables to get the versions. I left some code showing how to do this.
2. You can setup a string property in the view model and bind that in the XAML rather than the code behind.
3. There are several TODO items I left in the cloud patch, let me know if you have any questions on them.
4. If you want to see my review of this, I did it it live on twitch. It is at the beginning of this stream. https://www.twitch.tv/videos/2318667161

Author: Keboo

src/MainDemo.Wpf/Domain/MainWindowViewModel.cs

@@ -72,6 +72,7 @@ public MainWindowViewModel(ISnackbarMessageQueue snackbarMessageQueue, string? s
     private DemoItem? _selectedItem;
     private int _selectedIndex;
     private string? _searchKeyword;
+    private string? _nugetVersions;
     private bool _controlsEnabled = true;
 
     public string? SearchKeyword
@@ -86,6 +87,13 @@ public string? SearchKeyword
         }
     }
 
+    //TODO Set this property with the string for the version
+    public string NugetVersions
+    {
+        get => _nugetVersions;
+        set => SetProperty(ref _nugetVersions, value);
+    }
+
     public ObservableCollection<DemoItem> DemoItems { get; }
 
     public DemoItem? SelectedItem

src/MainDemo.Wpf/MainWindow.xaml

@@ -189,6 +189,7 @@
 
                 <Separator />
 
+                <!-- TODO: Bind the text of this TextBlock to the NugetVersions property of the MainWindowViewModel -->
                 <TextBlock x:Name="VersionText" HorizontalAlignment="Left" VerticalAlignment="Bottom" Margin="10" />
 
               </StackPanel>

src/MainDemo.Wpf/MainWindow.xaml.cs

@@ -1,4 +1,5 @@
 using System.Diagnostics;
+using System.Reflection;
 using System.Threading;
 using System.Windows.Media;
 using MaterialDesignDemo.Domain;
@@ -120,16 +121,17 @@ private void LoadVersion()
     {
         try
         {
-            string versionFilePath = Path.Combine(Directory.GetCurrentDirectory(), "version.txt");
-            if (File.Exists(versionFilePath))
-            {
-                string version = File.ReadAllText(versionFilePath).Trim();
-                VersionText.Text = $"Version: {version}";
-            }
-            else
-            {
-                VersionText.Text = "Version file not found";
-            }
+            //TODO: This should occur in the MainWindowViewModel
+            var attributes = Assembly.GetAssembly(typeof(Theme))!
+                .GetCustomAttributes<AssemblyMetadataAttribute>()
+                .ToList();
+
+            var mdixVersion = attributes
+                .SingleOrDefault(x => x.Key == "MDIXVersion")?.Value;
+
+            var mdixColorsVersion = attributes
+                .SingleOrDefault(x => x.Key == "MDIXColorsVersion")?.Value;
+
         }
         catch (Exception ex)
         {

src/MainDemo.Wpf/MaterialDesignDemo.csproj

@@ -49,4 +49,16 @@
     <PackageReference Include="ShowMeTheXAML.AvalonEdit" />
     <PackageReference Include="ShowMeTheXAML.MSBuild" />
   </ItemGroup>
+
+  <!-- This passes the environment variable values into assembly attributes that can be read in code -->
+  <ItemGroup>
+    <AssemblyAttribute Include="System.Reflection.AssemblyMetadataAttribute">
+      <_Parameter1>MDIXVersion</_Parameter1>
+      <_Parameter2>$(MDIXVersion)</_Parameter2>
+    </AssemblyAttribute>
+    <AssemblyAttribute Include="System.Reflection.AssemblyMetadataAttribute">
+      <_Parameter1>MDIXColorsVersion</_Parameter1>
+      <_Parameter2>$(MDIXColorsVersion)</_Parameter2>
+    </AssemblyAttribute>
+  </ItemGroup>
 </Project>