Fix code style issues (#3730)

* Fix code style issues

Converters N => V

* Delete Obsolete

Marked to be deleted in 5.0

Author: JLdgu

src/MaterialDesignThemes.Wpf/Converters/NotZeroToVisibilityConverter.cs

@@ -14,7 +14,5 @@ public object Convert(object value, Type targetType, object parameter, CultureIn
     }
 
     public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
-    {
-        return Binding.DoNothing;
-    }
+        => Binding.DoNothing;
 }

src/MaterialDesignThemes.Wpf/Converters/NullableDateTimeToCurrentDateConverter.cs

@@ -13,7 +13,5 @@ public object Convert(object value, Type targetType, object parameter, CultureIn
     }
 
     public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
-    {
-        return value;
-    }
+        => value;
 }

src/MaterialDesignThemes.Wpf/Converters/NullableToVisibilityConverter.cs

@@ -9,12 +9,8 @@ public class NullableToVisibilityConverter : IValueConverter
     public Visibility NotNullValue { get; set; } = Visibility.Visible;
 
     public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
-    {
-        return value == null ? NullValue : NotNullValue;
-    }
+        => value == null ? NullValue : NotNullValue;
 
     public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
-    {
-        return Binding.DoNothing;
-    }
+        => Binding.DoNothing;
 }

src/MaterialDesignThemes.Wpf/Converters/PointValueConverter.cs

@@ -21,12 +21,11 @@ public object Convert(object[] values, Type targetType, object parameter, Cultur
 
     public object[] ConvertBack(object value, Type[] targetTypes, object parameter, CultureInfo culture)
     {
-        if (value is Point)
+        if (value is Point point)
         {
-            var point = (Point)value;
-            return new object[] { point.X, point.Y };
+            return [point.X, point.Y];
         }
 
-        return new object[0];
+        return [];
     }
 }

src/MaterialDesignThemes.Wpf/Converters/RangeLengthConverter.cs

@@ -17,14 +17,12 @@ public object Convert(object[] values, Type targetType, object parameter, Cultur
 
             return Binding.DoNothing;
 
-        var percent = (value - min) / (max - min);
-        var length = percent * containerLength;
+        double percent = (value - min) / (max - min);
+        double length = percent * containerLength;
 
         return length > containerLength ? containerLength : length;
     }
 
     public object[] ConvertBack(object value, Type[] targetTypes, object parameter, CultureInfo culture)
-    {
-        throw new NotImplementedException();
-    }
+        => throw new NotImplementedException();
 }

src/MaterialDesignThemes.Wpf/Converters/RemoveAlphaBrushConverter.cs

@@ -25,8 +25,8 @@ private static Color RgbaToRgb(Color rgba, object background)
             _ => Colors.White
         };
 
-        var alpha = (double)rgba.A / byte.MaxValue;
-        var alphaReverse = 1 - alpha;
+        double alpha = (double)rgba.A / byte.MaxValue;
+        double alphaReverse = 1 - alpha;
 
         return Color.FromRgb(
             (byte)(alpha * rgba.R + alphaReverse * backgroundColor.R),

src/MaterialDesignThemes.Wpf/Converters/ShadowOpacityMaskConverter.cs

@@ -29,7 +29,7 @@ public class ShadowOpacityMaskConverter : IMultiValueConverter
 
         double blurRadius = dropShadow.BlurRadius;
 
-        Rect rect = new Rect(
+        var rect = new Rect(
                 -blurRadius,
                 -blurRadius,
                 width + blurRadius + blurRadius,

src/MaterialDesignThemes.Wpf/Converters/SizeToRectConverter.cs

@@ -16,7 +16,7 @@ public object Convert(object value, Type targetType, object parameter, CultureIn
             {
                 Orientation.Horizontal => (-width * 0.5) + halfGripWidth,
                 Orientation.Vertical => -width - margin,
-                _ => throw new ArgumentOutOfRangeException()
+                _ => throw new ArgumentOutOfRangeException(nameof(parameter))
             };
         }
 

src/MaterialDesignThemes.Wpf/Converters/SliderValueLabelPositionConverter.cs

@@ -6,9 +6,7 @@ namespace MaterialDesignThemes.Wpf.Converters;
 public class SnackbarMessageTypeConverter : TypeConverter
 {
     public override bool CanConvertFrom(ITypeDescriptorContext? context, Type sourceType)
-    {
-        return sourceType == typeof(string) || base.CanConvertFrom(context, sourceType);
-    }
+        => sourceType == typeof(string) || base.CanConvertFrom(context, sourceType);
 
     public override object? ConvertFrom(ITypeDescriptorContext? context, CultureInfo? culture, object value)
     {