[SmartHint] Follow up - make behavior and supporting APs public (#3689)

* Ensure behavior triggers AP change on initial binding

* Make helper APs public

* Apply renamed APs

Author: nicolaihenriksen

src/MaterialDesignThemes.Wpf/Behaviors/TextBoxLineCountBehavior.cs

@@ -3,27 +3,32 @@
 namespace MaterialDesignThemes.Wpf.Behaviors;
 
 /// <summary>
-/// Internal behavior exposing the <see cref="TextBox.LineCount"/> (non-DP) as an attached property which we can bind to
+/// Behavior exposing the <see cref="TextBox.LineCount"/> (non-DP) as attached properties which are bindable from XAML.
 /// </summary>
-internal class TextBoxLineCountBehavior : Behavior<TextBox>
+public class TextBoxLineCountBehavior : Behavior<TextBox>
 {
-    private void AssociatedObjectOnTextChanged(object sender, TextChangedEventArgs e)
+    private void AssociatedObjectOnTextChanged(object sender, TextChangedEventArgs e) => UpdateAttachedProperties();
+    private void AssociatedObjectOnLayoutUpdated(object? sender, EventArgs e) => UpdateAttachedProperties();
+
+    private void UpdateAttachedProperties()
     {
-        AssociatedObject.SetCurrentValue(TextFieldAssist.LineCountProperty, AssociatedObject.LineCount);
-        AssociatedObject.SetCurrentValue(TextFieldAssist.IsMultiLineProperty, AssociatedObject.LineCount > 1);
+        AssociatedObject.SetCurrentValue(TextFieldAssist.TextBoxLineCountProperty, AssociatedObject.LineCount);
+        AssociatedObject.SetCurrentValue(TextFieldAssist.TextBoxIsMultiLineProperty, AssociatedObject.LineCount > 1);
     }
 
     protected override void OnAttached()
     {
         base.OnAttached();
         AssociatedObject.TextChanged += AssociatedObjectOnTextChanged;
+        AssociatedObject.LayoutUpdated += AssociatedObjectOnLayoutUpdated;
     }
 
     protected override void OnDetaching()
     {
         if (AssociatedObject != null)
         {
             AssociatedObject.TextChanged -= AssociatedObjectOnTextChanged;
+            AssociatedObject.LayoutUpdated -= AssociatedObjectOnLayoutUpdated;
         }
         base.OnDetaching();
     }

src/MaterialDesignThemes.Wpf/TextFieldAssist.cs

@@ -368,19 +368,19 @@ public static void SetOutlinedBorderActiveThickness(DependencyObject element, Th
     public static Thickness GetOutlinedBorderActiveThickness(DependencyObject element)
         => (Thickness)element.GetValue(OutlinedBorderActiveThicknessProperty);
 
-    internal static readonly DependencyProperty LineCountProperty = DependencyProperty.RegisterAttached(
-        "LineCount", typeof(int), typeof(TextFieldAssist), new PropertyMetadata(0));
-    internal static void SetLineCount(DependencyObject element, int value)
-        => element.SetValue(LineCountProperty, value);
-    internal static int GetLineCount(DependencyObject element)
-        => (int) element.GetValue(LineCountProperty);
-
-    internal static readonly DependencyProperty IsMultiLineProperty = DependencyProperty.RegisterAttached(
-        "IsMultiLine", typeof(bool), typeof(TextFieldAssist), new PropertyMetadata(false));
-    internal static void SetIsMultiLine(DependencyObject element, bool value)
-        => element.SetValue(IsMultiLineProperty, value);
-    internal static bool GetIsMultiLine(DependencyObject element)
-        => (bool) element.GetValue(IsMultiLineProperty);
+    public static readonly DependencyProperty TextBoxLineCountProperty = DependencyProperty.RegisterAttached(
+        "TextBoxLineCount", typeof(int), typeof(TextFieldAssist), new PropertyMetadata(0));
+    public static void SetTextBoxLineCount(DependencyObject element, int value)
+        => element.SetValue(TextBoxLineCountProperty, value);
+    public static int GetTextBoxLineCount(DependencyObject element)
+        => (int) element.GetValue(TextBoxLineCountProperty);
+
+    public static readonly DependencyProperty TextBoxIsMultiLineProperty = DependencyProperty.RegisterAttached(
+        "TextBoxIsMultiLine", typeof(bool), typeof(TextFieldAssist), new PropertyMetadata(false));
+    public static void SetTextBoxIsMultiLine(DependencyObject element, bool value)
+        => element.SetValue(TextBoxIsMultiLineProperty, value);
+    public static bool GetTextBoxIsMultiLine(DependencyObject element)
+        => (bool) element.GetValue(TextBoxIsMultiLineProperty);
 
     #region Methods
 

src/MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.AutoSuggestBox.xaml

@@ -328,7 +328,7 @@
             <MultiTrigger>
               <MultiTrigger.Conditions>
                 <Condition Property="VerticalContentAlignment" Value="Stretch" />
-                <Condition Property="wpf:TextFieldAssist.IsMultiLine" Value="True" />
+                <Condition Property="wpf:TextFieldAssist.TextBoxIsMultiLine" Value="True" />
               </MultiTrigger.Conditions>
               <Setter TargetName="PrefixTextBlock" Property="VerticalAlignment" Value="Stretch" />
               <Setter TargetName="SuffixTextBlock" Property="VerticalAlignment" Value="Stretch" />
@@ -516,7 +516,7 @@
                   <MultiBinding Converter="{StaticResource FloatingHintInitialVerticalOffsetConverter}">
                     <Binding ElementName="PART_ContentHost" Path="ActualHeight" />
                     <Binding ElementName="Hint" Path="ActualHeight" />
-                    <Binding RelativeSource="{RelativeSource TemplatedParent}" Path="(wpf:TextFieldAssist.LineCount)" />
+                    <Binding RelativeSource="{RelativeSource TemplatedParent}" Path="(wpf:TextFieldAssist.TextBoxLineCount)" />
                   </MultiBinding>
                 </Setter.Value>
               </Setter>

src/MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.TextBox.xaml

@@ -340,7 +340,7 @@
             <MultiTrigger>
               <MultiTrigger.Conditions>
                 <Condition Property="VerticalContentAlignment" Value="Stretch" />
-                <Condition Property="wpf:TextFieldAssist.IsMultiLine" Value="True" />
+                <Condition Property="wpf:TextFieldAssist.TextBoxIsMultiLine" Value="True" />
               </MultiTrigger.Conditions>
               <Setter TargetName="PrefixTextBlock" Property="VerticalAlignment" Value="Stretch" />
               <Setter TargetName="SuffixTextBlock" Property="VerticalAlignment" Value="Stretch" />
@@ -522,7 +522,7 @@
                   <MultiBinding Converter="{StaticResource FloatingHintInitialVerticalOffsetConverter}">
                     <Binding ElementName="PART_ContentHost" Path="ActualHeight" />
                     <Binding ElementName="Hint" Path="ActualHeight" />
-                    <Binding RelativeSource="{RelativeSource TemplatedParent}" Path="(wpf:TextFieldAssist.LineCount)" />
+                    <Binding RelativeSource="{RelativeSource TemplatedParent}" Path="(wpf:TextFieldAssist.TextBoxLineCount)" />
                   </MultiBinding>
                 </Setter.Value>
               </Setter>