Fix code style issues

F to M Converters

Author: JLdgu

src/MaterialDesignThemes.Wpf/Converters/GridLinesVisibilityBorderToThicknessConverter.cs

@@ -9,10 +9,10 @@ internal class GridLinesVisibilityBorderToThicknessConverter : IValueConverter
 
     public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
     {
-        if (!(value is DataGridGridLinesVisibility visibility))
+        if (value is not DataGridGridLinesVisibility visibility)
             return Binding.DoNothing;
 
-        var thickness = parameter as double? ?? GridLinesThickness;
+        double thickness = parameter as double? ?? GridLinesThickness;
 
         return visibility switch
         {

src/MaterialDesignThemes.Wpf/Converters/HorizontalThicknessConverter.cs

@@ -15,7 +15,5 @@ public object Convert(object value, Type targetType, object parameter, CultureIn
     }
 
     public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
-    {
-        throw new NotImplementedException();
-    }
+        => throw new NotImplementedException();
 }

src/MaterialDesignThemes.Wpf/Converters/HsbLinearGradientConverter.cs

@@ -15,7 +15,5 @@ public object Convert(object value, Type targetType, object parameter, CultureIn
     }
 
     public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
-    {
-        throw new NotImplementedException();
-    }
+        => throw new NotImplementedException();
 }

src/MaterialDesignThemes.Wpf/Converters/HsbToColorConverter.cs

@@ -29,7 +29,5 @@ public object Convert(object[] values, Type targetType, object parameter, Cultur
     }
 
     public object[] ConvertBack(object value, Type[] targetTypes, object parameter, CultureInfo culture)
-    {
-        throw new NotImplementedException();
-    }
+        => throw new NotImplementedException();
 }

src/MaterialDesignThemes.Wpf/Converters/IsDarkConverter.cs

@@ -20,7 +20,5 @@ public object Convert(object value, Type targetType, object parameter, CultureIn
     }
 
     public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
-    {
-        throw new NotImplementedException();
-    }
+        => throw new NotImplementedException();
 }

src/MaterialDesignThemes.Wpf/Converters/MathConverter.cs

@@ -14,21 +14,15 @@ public sealed class MathConverter : IValueConverter
         {
             double value1 = System.Convert.ToDouble(value, CultureInfo.InvariantCulture);
             double value2 = System.Convert.ToDouble(parameter, CultureInfo.InvariantCulture);
-            switch (Operation)
+            return Operation switch
             {
-                case MathOperation.Add:
-                    return value1 + value2 + Offset;
-                case MathOperation.Divide:
-                    return value1 / value2 + Offset;
-                case MathOperation.Multiply:
-                    return value1 * value2 + Offset;
-                case MathOperation.Subtract:
-                    return value1 - value2 + Offset;
-                case MathOperation.Pow:
-                    return Math.Pow(value1, value2) + Offset;
-                default:
-                    return Binding.DoNothing;
-            }
+                MathOperation.Add => value1 + value2 + Offset,
+                MathOperation.Divide => value1 / value2 + Offset,
+                MathOperation.Multiply => value1 * value2 + Offset,
+                MathOperation.Subtract => value1 - value2 + Offset,
+                MathOperation.Pow => Math.Pow(value1, value2) + Offset,
+                _ => Binding.DoNothing,
+            };
         }
         catch (FormatException)
         {

src/MaterialDesignThemes.Wpf/Converters/MathMultipleConverter.cs

@@ -14,21 +14,15 @@ public sealed class MathMultipleConverter : IMultiValueConverter
         if (!double.TryParse(value[0]!.ToString(), out double value1) || !double.TryParse(value[1]!.ToString(), out double value2))
             return 0;
 
-        switch (Operation)
+        return Operation switch
         {
-            default:
-                // (case MathOperation.Add:)
-                return value1 + value2;
-            case MathOperation.Divide:
-                return value1 / value2;
-            case MathOperation.Multiply:
-                return value1 * value2;
-            case MathOperation.Subtract:
-                return value1 - value2;
-            case MathOperation.Pow:
-                return Math.Pow(value1, value2);
-        }
-
+            MathOperation.Add => value1 + value2,
+            MathOperation.Divide => value1 / value2,
+            MathOperation.Multiply => value1 * value2,
+            MathOperation.Subtract => value1 - value2,
+            MathOperation.Pow => Math.Pow(value1, value2),
+            _ => Binding.DoNothing
+        };
     }
 
     public object?[]? ConvertBack(object? value, Type[]? targetTypes, object? parameter, CultureInfo? culture)

tests/MaterialDesignThemes.Wpf.Tests/Converters/MathConverterTests.cs

@@ -1,4 +1,5 @@
 using System.Globalization;
+using System.Windows.Data;
 using MaterialDesignThemes.Wpf.Converters;
 
 namespace MaterialDesignThemes.Wpf.Tests.Converters;
@@ -16,4 +17,14 @@ public void EnumValues_AreAllHandled(MathOperation operation)
 
         Assert.True(converter.Convert(1.0, null, 1.0, CultureInfo.CurrentUICulture) is double);
     }
+
+    [Fact]
+    public void NoneDoubleArguments_ShouldReturnDoNothing()
+    {
+        MathConverter converter = new();
+        object? actual1 = converter.Convert("", null, 1.0, CultureInfo.CurrentUICulture);
+        Assert.Equal(Binding.DoNothing, actual1);
+        object? actual2 = converter.Convert(1.0, null, "", CultureInfo.CurrentUICulture);
+        Assert.Equal(Binding.DoNothing, actual2);
+    }
 }