Skip to content

Commit 6717120

Browse files
committed
Fix not using IsActive
Add IsActive property to all using of ripple
1 parent 69e94dc commit 6717120

File tree

4 files changed

+32
-10
lines changed

4 files changed

+32
-10
lines changed

MaterialDesignThemes.Wpf/Ripple.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,11 @@ public Ripple()
3737

3838
private void OnSizeChanged(object sender, SizeChangedEventArgs sizeChangedEventArgs)
3939
{
40-
double radius = Math.Sqrt(Math.Pow(sizeChangedEventArgs.NewSize.Width, 2) + Math.Pow(sizeChangedEventArgs.NewSize.Height, 2));
40+
double width = sizeChangedEventArgs.NewSize.Width;
41+
double height = sizeChangedEventArgs.NewSize.Height;
42+
double radius = Math.Sqrt(Math.Pow(width, 2) + Math.Pow(height, 2));
43+
44+
Debug.WriteLine("Width: {0} Height: {1} Radius: {2}", width, height, radius);
4145
RippleSize = 2 * radius * RippleSizeMultiplier;
4246
}
4347

MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.Calendar.xaml

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -295,12 +295,17 @@
295295
</VisualState>
296296
</VisualStateGroup>
297297
</VisualStateManager.VisualStateGroups>
298-
<wpf:Ripple HorizontalAlignment="Center" VerticalAlignment="Center">
298+
<wpf:Ripple x:Name="RippleWrapper" HorizontalAlignment="Center" VerticalAlignment="Center">
299299
<Viewbox Height="12" Margin="8">
300300
<Path x:Name="path" Data="M288.75,232.25 L288.75,240.625 L283,236.625 z" Fill="{TemplateBinding Foreground}" Stretch="Fill" />
301301
</Viewbox>
302302
</wpf:Ripple>
303303
</Grid>
304+
<ControlTemplate.Triggers>
305+
<Trigger Property="IsPressed" Value="True">
306+
<Setter TargetName="RippleWrapper" Property="IsActive" Value="True"/>
307+
</Trigger>
308+
</ControlTemplate.Triggers>
304309
</ControlTemplate>
305310
<ControlTemplate x:Key="NextButtonTemplate" TargetType="{x:Type Button}">
306311
<Grid Cursor="Hand">
@@ -315,12 +320,17 @@
315320
</VisualState>
316321
</VisualStateGroup>
317322
</VisualStateManager.VisualStateGroups>
318-
<wpf:Ripple HorizontalAlignment="Center" VerticalAlignment="Center">
323+
<wpf:Ripple x:Name="RippleWrapper" HorizontalAlignment="Center" VerticalAlignment="Center">
319324
<Viewbox Height="12" Margin="8">
320325
<Path x:Name="path" Data="M282.875,231.875 L282.875,240.375 L288.625,236 z" Fill="{TemplateBinding Foreground}" Stretch="Fill" />
321326
</Viewbox>
322327
</wpf:Ripple>
323328
</Grid>
329+
<ControlTemplate.Triggers>
330+
<Trigger Property="IsPressed" Value="True">
331+
<Setter TargetName="RippleWrapper" Property="IsActive" Value="True"/>
332+
</Trigger>
333+
</ControlTemplate.Triggers>
324334
</ControlTemplate>
325335
<ControlTemplate x:Key="HeaderButtonTemplate" TargetType="{x:Type Button}">
326336
<Grid Cursor="Hand">

MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.RatingBar.xaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@
2828
<Setter Property="Template">
2929
<Setter.Value>
3030
<ControlTemplate TargetType="wpf:RatingBarButton">
31-
<wpf:Ripple Content="{TemplateBinding Content}" ContentTemplate="{TemplateBinding ContentTemplate}" Focusable="False"
31+
<wpf:Ripple Content="{TemplateBinding Content}" ContentTemplate="{TemplateBinding ContentTemplate}" Focusable="False"
32+
x:Name="RippleWrapper"
3233
Feedback="{DynamicResource MaterialDesignFlatButtonRipple}"
3334
HorizontalContentAlignment="{TemplateBinding HorizontalContentAlignment}"
3435
VerticalContentAlignment="{TemplateBinding VerticalContentAlignment}"
@@ -40,6 +41,9 @@
4041
</wpf:Ripple.RenderTransform>
4142
</wpf:Ripple>
4243
<ControlTemplate.Triggers>
44+
<Trigger Property="IsPressed" Value="True">
45+
<Setter TargetName="RippleWrapper" Property="IsActive" Value="True"/>
46+
</Trigger>
4347
<EventTrigger RoutedEvent="Click">
4448
<EventTrigger.Actions>
4549
<BeginStoryboard>

MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.ToolBar.xaml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -227,16 +227,20 @@
227227
<Setter.Value>
228228
<ControlTemplate TargetType="{x:Type Button}">
229229
<wpf:Ripple Content="{TemplateBinding Content}" ContentTemplate="{TemplateBinding ContentTemplate}" Focusable="False"
230-
Feedback="{TemplateBinding Foreground}"
231-
ClipToBounds="False"
232-
HorizontalContentAlignment="{TemplateBinding HorizontalContentAlignment}"
233-
VerticalContentAlignment="{TemplateBinding VerticalContentAlignment}"
234-
Padding="{TemplateBinding Padding}"
235-
SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}" />
230+
x:Name="RippleWrapper"
231+
Feedback="{TemplateBinding Foreground}"
232+
ClipToBounds="False"
233+
HorizontalContentAlignment="{TemplateBinding HorizontalContentAlignment}"
234+
VerticalContentAlignment="{TemplateBinding VerticalContentAlignment}"
235+
Padding="{TemplateBinding Padding}"
236+
SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}" />
236237
<ControlTemplate.Triggers>
237238
<Trigger Property="IsEnabled" Value="false">
238239
<Setter Property="Opacity" Value=".56"/>
239240
</Trigger>
241+
<Trigger Property="IsPressed" Value="True">
242+
<Setter TargetName="RippleWrapper" Property="IsActive" Value="True"/>
243+
</Trigger>
240244
</ControlTemplate.Triggers>
241245
</ControlTemplate>
242246
</Setter.Value>

0 commit comments

Comments
 (0)