Bump xunit from 2.4.2 to 2.5.0 (#3265)

* Bump xunit from 2.4.2 to 2.5.0

Bumps [xunit](https://github.com/xunit/xunit) from 2.4.2 to 2.5.0.
- [Commits](xunit/xunit@2.4.2...2.5.0)

---
updated-dependencies:
- dependency-name: xunit
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fixing warnings from new analyzers

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin Bost <[email protected]>

Author: dependabot[bot]

Directory.packages.props

@@ -23,7 +23,7 @@
     <PackageVersion Include="ShowMeTheXAML.MSBuild" Version="2.0.0" />
     <PackageVersion Include="VirtualizingWrapPanel" Version="1.5.7" />
     <PackageVersion Include="XAMLTest" Version="1.0.0-ci417" />
-    <PackageVersion Include="xunit" Version="2.4.2" />
+    <PackageVersion Include="xunit" Version="2.5.0" />
     <PackageVersion Include="xunit.runner.visualstudio" Version="2.5.0" />
     <PackageVersion Include="Xunit.StaFact" Version="1.1.11" />
   </ItemGroup>

MaterialDesignThemes.UITests/WPF/DrawerHosts/DrawerHostTests.cs

@@ -43,7 +43,7 @@ public async Task DrawerHost_OpenAndClose_RaisesEvents()
         await Wait.For(async () =>
         {
             var invocations = await openedEvent.GetInvocations();
-            Assert.Equal(1, invocations.Count);
+            Assert.Single(invocations);
         });
 
         await Wait.For(async () =>
@@ -61,7 +61,7 @@ await Wait.For(async () =>
         await Wait.For(async () =>
         {
             var invocations = await closingEvent.GetInvocations();
-            Assert.Equal(1, invocations.Count);
+            Assert.Single(invocations);
         });
 
         await showButton.LeftClick();
@@ -169,7 +169,7 @@ public async Task DrawerHost_ShouldInvokeCustomContentTemplateSelector_WhenSetEx
             }
             catch
             {
-                throw new FailException($"Failed to find 'TextBlock' content in '{drawerElementKey}'. ContentTemplateSelector not properly applied.");
+                throw FailException.ForFailure($"Failed to find 'TextBlock' content in '{drawerElementKey}'. ContentTemplateSelector not properly applied.");
             }
         }
 

MaterialDesignThemes.Wpf.Tests/SnackbarMessageQueueTests.cs

@@ -27,7 +27,7 @@ public void GetSnackbarMessageNullValues()
         }
 
         [StaFact]
-        [Description("Ensures that GetSnackbaMessage behaves correctly if the queue should discard duplicate items")]
+        [Description("Ensures that GetSnackbarMessage behaves correctly if the queue should discard duplicate items")]
         public void GetSnackbarMessageDiscardDuplicatesQueue()
         {
             _snackbarMessageQueue.DiscardDuplicates = true;
@@ -51,7 +51,7 @@ public void GetSnackbarMessageDiscardDuplicatesQueue()
         }
 
         [StaTheory]
-        [Description("Ensures that GetSnackbaMessage behaves correctly if the queue simply outputs items")]
+        [Description("Ensures that GetSnackbarMessage behaves correctly if the queue simply outputs items")]
         [InlineData("String & Action content", "Action content")]
         [InlineData("Different String & Action content", "Action content")]
         [InlineData("", "")]
@@ -63,7 +63,7 @@ public void GetSnackbarMessageSimpleQueue(object content, object actionContent)
 
             IReadOnlyList<SnackbarMessageQueueItem> messages = _snackbarMessageQueue.QueuedMessages;
 
-            Assert.Equal(1, messages.Count);
+            Assert.Single(messages);
 
             Assert.Equal(content, messages[0].Content);
             Assert.Equal(actionContent, messages[0].ActionContent);
@@ -76,7 +76,7 @@ public void Enqueue_ProperlySetsPromote()
             _snackbarMessageQueue.Enqueue("Content", "Action Content", actionHandler: null, promote: true);
 
             IReadOnlyList<SnackbarMessageQueueItem> messages = _snackbarMessageQueue.QueuedMessages;
-            Assert.Equal(1, messages.Count);
+            Assert.Single(messages);
             Assert.Equal("Content", messages[0].Content);
             Assert.Equal("Action Content", messages[0].ActionContent);
             Assert.True(messages[0].IsPromoted);