Updates default behavior for ComboBoxAssist.ShowSelectedItem to display the selected in the ComboBox drop down list by default (#2459)

Author: guptaanmol184

MaterialDesignThemes.Wpf/ComboBoxAssist.cs

@@ -25,15 +25,14 @@ public static void SetClassicMode(DependencyObject element, bool value)
             => element.SetValue(ClassicModeProperty, value);
 
         /// <summary>
-        /// By default the selected item is hidden from the drop down list, as per Material Design specifications. 
-        /// To revert to a more classic Windows desktop behaviour, and show the currently selected item again in the drop
-        /// down, set this attached propety to true.
+        /// By default the selected item is displayed in the drop down list, as per Material Design specifications.
+        /// To change this to a behavior of hiding the selected item from the drop down list, set this attached property to false.
         /// </summary>
         public static readonly DependencyProperty ShowSelectedItemProperty = DependencyProperty.RegisterAttached(
             "ShowSelectedItem",
             typeof(bool),
             typeof(ComboBoxAssist),
-            new FrameworkPropertyMetadata(false,
+            new FrameworkPropertyMetadata(true,
                 FrameworkPropertyMetadataOptions.AffectsRender | FrameworkPropertyMetadataOptions.Inherits));
 
         public static bool GetShowSelectedItem(DependencyObject element)

MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.ComboBox.xaml

@@ -843,13 +843,13 @@
     </ControlTemplate>
 
     <Style x:Key="MaterialDesignComboBox" TargetType="{x:Type ComboBox}">
-        <Setter Property="wpf:ComboBoxAssist.ShowSelectedItem" Value="False" />
+        <Setter Property="wpf:ComboBoxAssist.ShowSelectedItem" Value="True"/>
         <Setter Property="Background" Value="Transparent"/>
         <Setter Property="BorderBrush" Value="{DynamicResource MaterialDesignTextBoxBorder}"/>
         <Setter Property="BorderThickness" Value="0 0 0 1"/>
         <Setter Property="FocusVisualStyle" Value="{x:Null}"/>
         <Setter Property="Foreground" Value="{Binding RelativeSource={RelativeSource AncestorType={x:Type FrameworkElement}}, Path=(TextElement.Foreground)}"/>
-        <Setter Property="ItemContainerStyle" Value="{StaticResource MaterialDesignComboBoxItemSelectedCollapsedStyle}" />
+        <Setter Property="ItemContainerStyle" Value="{StaticResource MaterialDesignComboBoxItemStyle}" />
         <Setter Property="ScrollViewer.HorizontalScrollBarVisibility" Value="Auto" />
         <Setter Property="ScrollViewer.VerticalScrollBarVisibility" Value="Auto" />
         <Setter Property="Padding" Value="{x:Static wpf:Constants.TextBoxDefaultPadding}" />
@@ -873,8 +873,8 @@
                 <Setter Property="wpf:ComboBoxAssist.ShowSelectedItem" Value="{StaticResource TrueValue}" />
             </Trigger>
             <!-- designer prefers hard bool -->
-            <Trigger Property="wpf:ComboBoxAssist.ShowSelectedItem" Value="{StaticResource TrueValue}" >
-                <Setter Property="ItemContainerStyle" Value="{StaticResource MaterialDesignComboBoxItemStyle}" />
+            <Trigger Property="wpf:ComboBoxAssist.ShowSelectedItem" Value="{StaticResource FalseValue}" >
+                <Setter Property="ItemContainerStyle" Value="{StaticResource MaterialDesignComboBoxItemSelectedCollapsedStyle}" />
             </Trigger>
         </Style.Triggers>
     </Style>
@@ -887,7 +887,7 @@
 
     <Style x:Key="MaterialDesignFilledComboBox" TargetType="{x:Type ComboBox}" BasedOn="{StaticResource MaterialDesignFloatingHintComboBox}">
         <Setter Property="wpf:TextFieldAssist.TextFieldCornerRadius" Value="4,4,0,0" />
-        <Setter Property="wpf:ComboBoxAssist.ShowSelectedItem" Value="False" />
+        <Setter Property="wpf:ComboBoxAssist.ShowSelectedItem" Value="True"/>
         <Setter Property="VerticalContentAlignment" Value="Stretch" />
         <Setter Property="VerticalAlignment" Value="Stretch" />
         <Setter Property="Padding" Value="12,8,8,8" />