Skip to content

Commit 8df86b4

Browse files
authored
No longer setting IsOpen to false on unloaded (#1682)
It does not appear to be needed as the popup will close itself when it is unloaded.
1 parent 2e1631c commit 8df86b4

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

MaterialDesignThemes.Wpf.Tests/DialogHostTests.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,16 @@ public async Task WhenDoubleClickAwayDialogCloses()
198198
Assert.Equal(1, closingCount);
199199
}
200200

201+
[StaFact]
202+
[Description("Issue 1618")]
203+
public void WhenDialogHostIsUnloadedIsOpenRemainsTrue()
204+
{
205+
_dialogHost.IsOpen = true;
206+
_dialogHost.RaiseEvent(new RoutedEventArgs(FrameworkElement.UnloadedEvent));
207+
208+
Assert.True(_dialogHost.IsOpen);
209+
}
210+
201211
private class TestDialog : Control
202212
{
203213
public void CloseDialog() => DialogHost.CloseDialogCommand.Execute(null, this);

MaterialDesignThemes.Wpf/DialogHost.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -705,7 +705,6 @@ private string SelectState()
705705
private void OnUnloaded(object sender, RoutedEventArgs routedEventArgs)
706706
{
707707
LoadedInstances.Remove(this);
708-
SetCurrentValue(IsOpenProperty, false);
709708
}
710709

711710
private void OnLoaded(object sender, RoutedEventArgs routedEventArgs)

0 commit comments

Comments
 (0)