Updating to xUnit v3 1.x

Keboo · Keboo · commit 9345bbb227e4 · 2025-06-13T00:53:09.000-07:00
diff --git a/Directory.packages.props b/Directory.packages.props
@@ -1,9 +1,9 @@
 <Project>
   <ItemGroup>
     <PackageVersion Include="BluwolfIcons" Version="1.0.1" />
-    <PackageVersion Include="CommunityToolkit.Mvvm" Version="8.2.2" />
+    <PackageVersion Include="CommunityToolkit.Mvvm" Version="8.4.0" />
     <PackageVersion Include="Dragablz" Version="0.0.3.234" />
-    <PackageVersion Include="GitHubActionsTestLogger" Version="2.3.3" />
+    <PackageVersion Include="GitHubActionsTestLogger" Version="2.4.1" />
     <PackageVersion Include="Humanizer" Version="2.14.1" />
     <PackageVersion Include="MahApps.Metro" Version="2.4.10" />
     <PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" PrivateAssets="all" />
@@ -24,11 +24,12 @@
     <PackageVersion Include="ShowMeTheXAML.MSBuild" Version="2.0.0" />
     <PackageVersion Include="System.CommandLine" Version="2.0.0-beta4.22272.1" />
     <PackageVersion Include="System.Net.Http" Version="4.3.4" />
+    <PackageVersion Include="System.Private.Uri" Version="4.3.2" />
     <PackageVersion Include="System.Text.RegularExpressions" Version="4.3.1" />
     <PackageVersion Include="VirtualizingWrapPanel" Version="1.5.8" />
     <PackageVersion Include="XAMLTest" Version="1.3.0-ci602" />
-    <PackageVersion Include="xunit" Version="2.6.2" />
-    <PackageVersion Include="xunit.runner.visualstudio" Version="2.5.4" />
-    <PackageVersion Include="Xunit.StaFact" Version="1.1.11" />
+    <PackageVersion Include="xunit.runner.visualstudio" Version="3.0.2" />
+    <PackageVersion Include="Xunit.StaFact" Version="2.0.36-alpha" />
+    <PackageVersion Include="xunit.v3" Version="1.1.0" />
   </ItemGroup>
 </Project>
diff --git a/tests/MaterialDesignColors.Wpf.Tests/MaterialDesignColors.Wpf.Tests.csproj b/tests/MaterialDesignColors.Wpf.Tests/MaterialDesignColors.Wpf.Tests.csproj
@@ -4,6 +4,7 @@
     <TargetFrameworks>net472;net8.0-windows</TargetFrameworks>
     <AssemblyTitle>MaterialDesignColors.Wpf.Tests</AssemblyTitle>
     <Product>MaterialDesignColors.Wpf.Tests</Product>
+    <OutputType>Exe</OutputType>
   </PropertyGroup>
   <ItemGroup Condition="'$(TargetFramework)'=='net472'">
     <Reference Include="PresentationCore" />
@@ -25,9 +26,15 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="xunit" />
-    <PackageReference Include="xunit.runner.visualstudio" />
+    <PackageReference Include="System.Net.Http" />
+    <PackageReference Include="System.Private.Uri" />
+    <PackageReference Include="System.Text.RegularExpressions" />
     <PackageReference Include="Shouldly" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" />
+    <PackageReference Include="xunit.runner.visualstudio">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
+    <PackageReference Include="xunit.v3" />
   </ItemGroup>
 </Project>
diff --git a/tests/MaterialDesignColors.Wpf.Tests/ResourceProviderFixture.cs b/tests/MaterialDesignColors.Wpf.Tests/ResourceProviderFixture.cs
@@ -1,7 +1,7 @@
 ﻿using Shouldly;
 using Xunit;
 
-namespace MaterialDesignColors.Wpf.Fixture;
+namespace MaterialDesignColors.Wpf.Tests;
 
 public class ResourceProviderFixture
 {
diff --git a/tests/MaterialDesignThemes.UITests/MaterialDesignThemes.UITests.csproj b/tests/MaterialDesignThemes.UITests/MaterialDesignThemes.UITests.csproj
@@ -6,6 +6,7 @@
     <UseWPF>true</UseWPF>
     <NoWarn>$(NoWarn);CA1707</NoWarn>
     <IncludePackageReferencesDuringMarkupCompilation>true</IncludePackageReferencesDuringMarkupCompilation>
+    <OutputType>Exe</OutputType>
     <!--<EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles>-->
   </PropertyGroup>
 
@@ -19,18 +20,17 @@
     <PackageReference Include="System.Net.Http" />
     <PackageReference Include="System.Text.RegularExpressions" />
     <PackageReference Include="XAMLTest" />
-    <PackageReference Include="xunit" />
     <PackageReference Include="xunit.runner.visualstudio">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
+    <PackageReference Include="xunit.v3" />
   </ItemGroup>
 
   <ItemGroup>
     <Using Include="MaterialDesignThemes.Wpf" />
     <Using Include="XamlTest" />
     <Using Include="Xunit" />
-    <Using Include="Xunit.Abstractions" />
   </ItemGroup>
 
   <ItemGroup>
diff --git a/tests/MaterialDesignThemes.UITests/TestBase.cs b/tests/MaterialDesignThemes.UITests/TestBase.cs
@@ -46,7 +46,7 @@ protected async Task<IVisualElement> LoadUserControl(Type userControlType)
         return await App.CreateWindowWithUserControl(userControlType);
     }
 
-    public async Task InitializeAsync() =>
+    public async ValueTask InitializeAsync() =>
         App = await XamlTest.App.StartRemote(new AppOptions
         {
 #if !DEBUG
@@ -55,5 +55,6 @@ public async Task InitializeAsync() =>
             AllowVisualStudioDebuggerAttach = AttachedDebuggerToRemoteProcess,
             LogMessage = Output.WriteLine
         });
-    public async Task DisposeAsync() => await App.DisposeAsync();
+
+    public async ValueTask DisposeAsync() => await App.DisposeAsync();
 }
diff --git a/tests/MaterialDesignThemes.UITests/WPF/TreeListViews/TreeListViewTests.cs b/tests/MaterialDesignThemes.UITests/WPF/TreeListViews/TreeListViewTests.cs
@@ -862,24 +862,24 @@ public async Task TopLevelItemWithNestedExpandedChild_MovesChildrenMaintainingEx
         await item1.LeftClickExpander();
 
         //NB: Needs to be long enough delay so the next click does not register as a double click
-        await Task.Delay(1000);
+        await Task.Delay(1000, TestContext.Current.CancellationToken);
 
         // Add children to item "1_1" and expand
         IVisualElement<TreeListViewItem> item11 = await treeListView.GetElement<TreeListViewItem>("/TreeListViewItem[3]");
         await AddChildren(item11, 3, addButton);
         await item11.LeftClickExpander();
 
         //NB: Needs to be long enough delay so the next click does not register as a double click
-        await Task.Delay(1000);
+        await Task.Delay(1000, TestContext.Current.CancellationToken);
 
         //Move parent item down
         await item1.LeftClick();
         await upButton.LeftClick();
 
-        await Task.Delay(1000);
+        await Task.Delay(1000, TestContext.Current.CancellationToken);
 
         await downButton.LeftClick();
-        await Task.Delay(1000);
+        await Task.Delay(1000, TestContext.Current.CancellationToken);
 
         //Assert the child was successfully moved
         await AssertTreeItemContent(treeListView, 0, "0");
diff --git a/tests/MaterialDesignThemes.Wpf.Tests/DialogHostTests.cs b/tests/MaterialDesignThemes.Wpf.Tests/DialogHostTests.cs
@@ -1,7 +1,6 @@
 ﻿using System.ComponentModel;
 using System.Threading;
 using System.Windows.Threading;
-using Xunit;
 
 namespace MaterialDesignThemes.Wpf.Tests;
 
diff --git a/tests/MaterialDesignThemes.Wpf.Tests/EnumDataAttribute.cs b/tests/MaterialDesignThemes.Wpf.Tests/EnumDataAttribute.cs
@@ -1,11 +1,12 @@
 ﻿using System.Reflection;
 using Xunit.Sdk;
+using Xunit.v3;
 
 namespace MaterialDesignThemes.Wpf.Tests;
 
 public class EnumDataAttribute : DataAttribute
 {
-    public override IEnumerable<object[]> GetData(MethodInfo testMethod)
+    public override ValueTask<IReadOnlyCollection<ITheoryDataRow>> GetData(MethodInfo testMethod, DisposalTracker disposalTracker)
     {
         ParameterInfo[] parameters = testMethod.GetParameters();
         if (parameters.Length != 1 ||
@@ -14,14 +15,15 @@ public override IEnumerable<object[]> GetData(MethodInfo testMethod)
             throw new Exception($"{testMethod.DeclaringType?.FullName}.{testMethod.Name} must have a single enum parameter");
         }
 
-        return GetDataImplementation(parameters[0].ParameterType);
+        return new([..GetDataImplementation(parameters[0].ParameterType)]);
 
-        static IEnumerable<object[]> GetDataImplementation(Type parameterType)
+        static IEnumerable<ITheoryDataRow> GetDataImplementation(Type parameterType)
         {
             foreach (object enumValue in Enum.GetValues(parameterType).OfType<object>())
             {
-                yield return new[] { enumValue };
+                yield return new TheoryDataRow(enumValue);
             }
         }
     }
+    public override bool SupportsDiscoveryEnumeration() => true;
 }
diff --git a/tests/MaterialDesignThemes.Wpf.Tests/MaterialDesignThemes.Wpf.Tests.csproj b/tests/MaterialDesignThemes.Wpf.Tests/MaterialDesignThemes.Wpf.Tests.csproj
@@ -4,6 +4,8 @@
     <TargetFrameworks>net472;net8.0-windows</TargetFrameworks>
     <AssemblyTitle>MaterialDesignThemes.Wpf.Tests</AssemblyTitle>
     <Product>MaterialDesignThemes.Wpf.Tests</Product>
+    <OutputType>Exe</OutputType>
+    <UseWPF>true</UseWPF>
   </PropertyGroup>
   <ItemGroup Condition="'$(TargetFramework)'=='net472'">
     <Reference Include="PresentationCore" />
@@ -26,8 +28,13 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="xunit" />
-    <PackageReference Include="xunit.runner.visualstudio" />
+    <PackageReference Include="System.Net.Http" />
+    <PackageReference Include="System.Text.RegularExpressions" />
+    <PackageReference Include="xunit.runner.visualstudio">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
+    <PackageReference Include="xunit.v3" />
     <PackageReference Include="Xunit.StaFact" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" />
   </ItemGroup>

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`using Shouldly;`
`2`	`2`	`using Xunit;`
`3`	`3`
`4`		`-namespace MaterialDesignColors.Wpf.Fixture;`
	`4`	`+namespace MaterialDesignColors.Wpf.Tests;`
`5`	`5`
`6`	`6`	`public class ResourceProviderFixture`
`7`	`7`	`{`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ protected async Task<IVisualElement> LoadUserControl(Type userControlType)`
`46`	`46`	`return await App.CreateWindowWithUserControl(userControlType);`
`47`	`47`	`}`
`48`	`48`
`49`		`- public async Task InitializeAsync() =>`
	`49`	`+ public async ValueTask InitializeAsync() =>`
`50`	`50`	`App = await XamlTest.App.StartRemote(new AppOptions`
`51`	`51`	`{`
`52`	`52`	`#if !DEBUG`
`@@ -55,5 +55,6 @@ public async Task InitializeAsync() =>`
`55`	`55`	`AllowVisualStudioDebuggerAttach = AttachedDebuggerToRemoteProcess,`
`56`	`56`	`LogMessage = Output.WriteLine`
`57`	`57`	`});`
`58`		`- public async Task DisposeAsync() => await App.DisposeAsync();`
	`58`	`+`
	`59`	`+ public async ValueTask DisposeAsync() => await App.DisposeAsync();`
`59`	`60`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,11 +1,12 @@`
`1`	`1`	`using System.Reflection;`
`2`	`2`	`using Xunit.Sdk;`
	`3`	`+using Xunit.v3;`
`3`	`4`
`4`	`5`	`namespace MaterialDesignThemes.Wpf.Tests;`
`5`	`6`
`6`	`7`	`public class EnumDataAttribute : DataAttribute`
`7`	`8`	`{`
`8`		`- public override IEnumerable<object[]> GetData(MethodInfo testMethod)`
	`9`	`+ public override ValueTask<IReadOnlyCollection<ITheoryDataRow>> GetData(MethodInfo testMethod, DisposalTracker disposalTracker)`
`9`	`10`	`{`
`10`	`11`	`ParameterInfo[] parameters = testMethod.GetParameters();`
`11`	`12`	`if (parameters.Length != 1 \|\|`
`@@ -14,14 +15,15 @@ public override IEnumerable<object[]> GetData(MethodInfo testMethod)`
`14`	`15`	`throw new Exception($"{testMethod.DeclaringType?.FullName}.{testMethod.Name} must have a single enum parameter");`
`15`	`16`	`}`
`16`	`17`
`17`		`- return GetDataImplementation(parameters[0].ParameterType);`
	`18`	`+ return new([..GetDataImplementation(parameters[0].ParameterType)]);`
`18`	`19`
`19`		`- static IEnumerable<object[]> GetDataImplementation(Type parameterType)`
	`20`	`+ static IEnumerable<ITheoryDataRow> GetDataImplementation(Type parameterType)`
`20`	`21`	`{`
`21`	`22`	`foreach (object enumValue in Enum.GetValues(parameterType).OfType<object>())`
`22`	`23`	`{`
`23`		`- yield return new[] { enumValue };`
	`24`	`+ yield return new TheoryDataRow(enumValue);`
`24`	`25`	`}`
`25`	`26`	`}`
`26`	`27`	`}`
	`28`	`+ public override bool SupportsDiscoveryEnumeration() => true;`
`27`	`29`	`}`