Open URLs in default browser (#1481)

Fixes #1480

Author: Keboo

MainDemo.Wpf/Domain/DocumentationLink.cs

@@ -2,6 +2,7 @@
 using System.Configuration;
 using System.Windows.Controls;
 using System.Windows.Input;
+using MaterialDesignDemo.Domain;
 
 namespace MaterialDesignColors.WpfExample.Domain
 {
@@ -17,7 +18,7 @@ public DocumentationLink(DocumentationLinkType type, string url, string label)
             Url = url;
             Type = type;
             Open = new AnotherCommandImplementation(Execute);
-        }        
+        }
 
         public static DocumentationLink WikiLink(string page, string label)
         {
@@ -26,7 +27,7 @@ public static DocumentationLink WikiLink(string page, string label)
         }
 
         public static DocumentationLink StyleLink(string nameChunk)
-        {            
+        {
             return new DocumentationLink(
                 DocumentationLinkType.StyleSource,
                 $"{ConfigurationManager.AppSettings["GitHub"]}/blob/master/MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.{nameChunk}.xaml",
@@ -78,21 +79,21 @@ public static DocumentationLink DemoPageLink<TDemoPage>(string label, string nam
 
             return new DocumentationLink(
                 DocumentationLinkType.DemoPageSource,
-                $"{ConfigurationManager.AppSettings["GitHub"]}/blob/master/MainDemo.Wpf/{(string.IsNullOrWhiteSpace(nameSpace) ? "" : ("/" + nameSpace + "/" ))}{typeof(TDemoPage).Name}.{ext}",
+                $"{ConfigurationManager.AppSettings["GitHub"]}/blob/master/MainDemo.Wpf/{(string.IsNullOrWhiteSpace(nameSpace) ? "" : ("/" + nameSpace + "/"))}{typeof(TDemoPage).Name}.{ext}",
                 label ?? typeof(TDemoPage).Name);
         }
 
         public string Label { get; }
 
         public string Url { get; }
 
-        public DocumentationLinkType Type { get; }        
+        public DocumentationLinkType Type { get; }
 
         public ICommand Open { get; }
 
         private void Execute(object o)
         {
-            System.Diagnostics.Process.Start(Url);
+            Link.OpenInBrowser(Url);
         }
     }
 }

MainDemo.Wpf/Domain/Link.cs

@@ -0,0 +1,18 @@
+using System.Diagnostics;
+using System.Runtime.InteropServices;
+
+namespace MaterialDesignDemo.Domain
+{
+    public static class Link
+    {
+        public static void OpenInBrowser(string url)
+        {
+            //https://github.com/dotnet/corefx/issues/10361
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+            {
+                url = url.Replace("&", "^&");
+                Process.Start(new ProcessStartInfo("cmd", $"/c start {url}") { CreateNoWindow = true });
+            }
+        }
+    }
+}

MainDemo.Wpf/Home.xaml.cs

@@ -2,6 +2,7 @@
 using System.Diagnostics;
 using System.Windows;
 using System.Windows.Controls;
+using MaterialDesignDemo.Domain;
 
 namespace MaterialDesignColors.WpfExample
 {
@@ -17,27 +18,27 @@ public Home()
 
         private void GitHubButton_OnClick(object sender, RoutedEventArgs e)
         {
-            Process.Start(ConfigurationManager.AppSettings["GitHub"]);
+            Link.OpenInBrowser(ConfigurationManager.AppSettings["GitHub"]);
         }
 
         private void TwitterButton_OnClick(object sender, RoutedEventArgs e)
         {
-            Process.Start("https://twitter.com/James_Willock");
+            Link.OpenInBrowser("https://twitter.com/James_Willock");
         }
 
         private void ChatButton_OnClick(object sender, RoutedEventArgs e)
         {
-            Process.Start("https://gitter.im/ButchersBoy/MaterialDesignInXamlToolkit");
+            Link.OpenInBrowser("https://gitter.im/ButchersBoy/MaterialDesignInXamlToolkit");
         }
 
         private void EmailButton_OnClick(object sender, RoutedEventArgs e)
         {
-            Process.Start("mailto://[email protected]");
+            Link.OpenInBrowser("mailto://[email protected]");
         }
 
         private void DonateButton_OnClick(object sender, RoutedEventArgs e)
         {
-            Process.Start("https://opencollective.com/materialdesigninxaml");
+            Link.OpenInBrowser("https://opencollective.com/materialdesigninxaml");
         }
     }
 }

MainDemo.Wpf/IconPackViewModel.cs

@@ -7,6 +7,7 @@
 using System.Windows;
 using System.Windows.Input;
 using MaterialDesignColors.WpfExample.Domain;
+using MaterialDesignDemo.Domain;
 using MaterialDesignThemes.Wpf;
 
 namespace MaterialDesignDemo
@@ -48,7 +49,7 @@ public IEnumerable<PackIconKind> Kinds
 
         private void OpenDotCom(object obj)
         {
-            Process.Start("https://materialdesignicons.com/");
+            Link.OpenInBrowser("https://materialdesignicons.com/");
         }
 
         private void Search(object obj)

MainDemo.Wpf/MenusAndToolBars.xaml.cs

@@ -1,6 +1,6 @@
-using System.Diagnostics;
-using System.Windows;
+using System.Windows;
 using System.Windows.Controls;
+using MaterialDesignDemo.Domain;
 
 namespace MaterialDesignColors.WpfExample
 {
@@ -16,7 +16,7 @@ public MenusAndToolBars()
 
         private void TwitterButton_OnClick(object sender, RoutedEventArgs e)
         {
-            Process.Start("https://twitter.com/James_Willock");
+            Link.OpenInBrowser("https://twitter.com/James_Willock");
         }
     }
 }

MainDemo.Wpf/TextFields.xaml.cs

@@ -1,8 +1,8 @@
 using System.Windows;
 using System.Windows.Controls;
-using System.Windows.Documents;
 using System.Windows.Navigation;
 using MaterialDesignColors.WpfExample.Domain;
+using MaterialDesignDemo.Domain;
 
 namespace MaterialDesignColors.WpfExample
 {
@@ -23,7 +23,7 @@ private void UserControl_Loaded(object sender, RoutedEventArgs e)
 
         private void Hyperlink_OnRequestNavigate(object sender, RequestNavigateEventArgs e)
         {
-            System.Diagnostics.Process.Start(e.Uri.AbsoluteUri);
+            Link.OpenInBrowser(e.Uri.AbsoluteUri);
         }
     }
 }