move dialog popup IsOpen animation into code; WPF throwing sporadic errors. re. issue #545

Author: ButchersBoy

MaterialDesignThemes.Wpf/DialogHost.cs

@@ -9,6 +9,7 @@
 using System.Windows.Data;
 using System.Windows.Input;
 using System.Windows.Threading;
+using ControlzEx;
 using MaterialDesignThemes.Wpf.Transitions;
 
 namespace MaterialDesignThemes.Wpf
@@ -246,6 +247,7 @@ private static void IsOpenPropertyChangedCallback(DependencyObject dependencyObj
 
             if (dialogHost.IsOpen)
             {
+                dialogHost._popup.SetCurrentValue(Popup.IsOpenProperty, true);                
                 WatchWindowActivation(dialogHost);
                 dialogHost._currentSnackbarMessageQueueUnPauseAction = dialogHost.SnackbarMessageQueue?.Pause();
             }
@@ -266,7 +268,13 @@ private static void IsOpenPropertyChangedCallback(DependencyObject dependencyObj
                 // if the MainWindow has started up minimized. Even when Show() has been called, this doesn't
                 // seem to have been set.
 
-                dialogHost.Dispatcher.InvokeAsync(() => dialogHost._restoreFocusDialogClose?.Focus(), DispatcherPriority.Input);
+                //close popup in code (previously was in a storyboard)....WPF was throwing sporadic errors in some cases
+
+                Task.Delay(TimeSpan.FromMilliseconds(300)).ContinueWith(t =>
+                {
+                    dialogHost._popup.SetCurrentValue(Popup.IsOpenProperty, false);
+                    dialogHost._restoreFocusDialogClose?.Focus();
+                }, TaskScheduler.FromCurrentSynchronizationContext());
 
                 return;
             }
@@ -424,7 +432,7 @@ public override void OnApplyTemplate()
                 _contentCoverGrid.MouseLeftButtonUp += ContentCoverGridOnMouseLeftButtonUp;
 
             VisualStateManager.GoToState(this, SelectState(), false);
-
+            
             base.OnApplyTemplate();
         }
 

MaterialDesignThemes.Wpf/Themes/Generic.xaml

@@ -483,9 +483,6 @@
                                 <VisualStateGroup.Transitions>
                                     <VisualTransition From="Closed" To="Open">
                                         <Storyboard>
-                                            <BooleanAnimationUsingKeyFrames Storyboard.TargetName="PART_Popup" Storyboard.TargetProperty="IsOpen">
-                                                <DiscreteBooleanKeyFrame Value="True" KeyTime="0" />
-                                            </BooleanAnimationUsingKeyFrames>
                                             <DoubleAnimationUsingKeyFrames Storyboard.TargetName="PART_ContentCoverGrid" Storyboard.TargetProperty="Opacity">
                                                 <EasingDoubleKeyFrame Value="0" KeyTime="0" />
                                                 <EasingDoubleKeyFrame Value="0.56" KeyTime="0:0:0.3">
@@ -522,10 +519,6 @@
                                     </VisualTransition>
                                     <VisualTransition From="Open" To="Closed">
                                         <Storyboard>
-                                            <BooleanAnimationUsingKeyFrames Storyboard.TargetName="PART_Popup" Storyboard.TargetProperty="IsOpen">
-                                                <DiscreteBooleanKeyFrame Value="True" KeyTime="0:0:0" />
-                                                <DiscreteBooleanKeyFrame Value="True" KeyTime="0:0:0.3" />
-                                            </BooleanAnimationUsingKeyFrames>
                                             <DoubleAnimationUsingKeyFrames Storyboard.TargetName="PART_ContentCoverGrid" Storyboard.TargetProperty="Opacity">
                                                 <EasingDoubleKeyFrame Value="0.56" KeyTime="0" />
                                                 <EasingDoubleKeyFrame Value="0" KeyTime="0:0:0.3">
@@ -566,9 +559,6 @@
                                 </VisualStateGroup.Transitions>
                                 <VisualState x:Name="Open">
                                     <Storyboard>
-                                        <BooleanAnimationUsingKeyFrames Storyboard.TargetName="PART_Popup" Storyboard.TargetProperty="IsOpen">
-                                            <DiscreteBooleanKeyFrame Value="True" KeyTime="0" />
-                                        </BooleanAnimationUsingKeyFrames>
                                         <DoubleAnimation Storyboard.TargetName="PART_ContentCoverGrid" Storyboard.TargetProperty="Opacity"
                                                          Duration="0"
                                                          To=".56" />
@@ -584,12 +574,7 @@
                                     </Storyboard>
                                 </VisualState>
                                 <VisualState x:Name="Closed">
-                                    <Storyboard>
-                                        <BooleanAnimationUsingKeyFrames Storyboard.TargetName="PART_Popup" Storyboard.TargetProperty="IsOpen">
-                                            <DiscreteBooleanKeyFrame Value="True" KeyTime="0:0:0" />
-                                            <DiscreteBooleanKeyFrame Value="False" KeyTime="0:0:0.3" />
-                                        </BooleanAnimationUsingKeyFrames>
-                                    </Storyboard>
+                                    <Storyboard />
                                 </VisualState>
                             </VisualStateGroup>
                         </VisualStateManager.VisualStateGroups>