Skip to content

Commit c4e151a

Browse files
authored
Fix for Demo app DataGrid - "Select all" checkbox not working #3032 (#3059)
* fix(MaterialDesignDemo):Datagrids select all checkbox binding (#3032) * fix(MaterialDesignDemo3):DataGrids select all checkbox binding (#3032)
1 parent 92d5cc7 commit c4e151a

File tree

4 files changed

+6
-36
lines changed

4 files changed

+6
-36
lines changed

MainDemo.Wpf/DataGrids.xaml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,22 +32,20 @@
3232
SelectedIndex="0" />
3333
</StackPanel>
3434

35+
<FrameworkElement x:Name="DataContextProxy" DataContext="{Binding}"/>
36+
3537
<smtx:XamlDisplay UniqueKey="grids_1">
3638
<DataGrid AutoGenerateColumns="False"
3739
CanUserAddRows="False"
3840
HeadersVisibility="All"
3941
ItemsSource="{Binding Items1}"
4042
SelectionUnit="{Binding ElementName=selectionUnitComboBox, Path=SelectedValue}">
41-
<DataGrid.Resources>
42-
<domain:BindingProxy x:Key="DataContextProxy" Data="{Binding}" />
43-
</DataGrid.Resources>
44-
4543
<DataGrid.Columns>
4644
<!-- by default a DataGridCheckBoxColumn will have the MaterialDesignDataGridCheckBoxColumnStyle and MaterialDesignDataGridCheckBoxColumnEditingStyle applied. See DataGridAssist.ApplyMaterialDesignColumnStyles attached property -->
4745
<DataGridCheckBoxColumn Binding="{Binding IsSelected, UpdateSourceTrigger=PropertyChanged}">
4846
<DataGridCheckBoxColumn.Header>
4947
<Border Background="Transparent">
50-
<CheckBox IsChecked="{Binding Data.IsAllItems1Selected, Source={StaticResource DataContextProxy}}" />
48+
<CheckBox IsChecked="{Binding DataContext.IsAllItems1Selected, Source={x:Reference DataContextProxy}}" />
5149
</Border>
5250
</DataGridCheckBoxColumn.Header>
5351

MainDemo.Wpf/Domain/BindingProxy.cs

Lines changed: 0 additions & 13 deletions
This file was deleted.

MaterialDesign3.Demo.Wpf/DataGrids.xaml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,22 +22,20 @@
2222
<StackPanel>
2323
<TextBlock Style="{StaticResource MaterialDesignHeadline5TextBlock}" Text="Custom Columns" />
2424

25+
<FrameworkElement x:Name="DataContextProxy" DataContext="{Binding}"/>
26+
2527
<smtx:XamlDisplay UniqueKey="grids_1">
2628
<DataGrid AutoGenerateColumns="False"
2729
CanUserAddRows="False"
2830
HeadersVisibility="All"
2931
ItemsSource="{Binding Items1}">
30-
<DataGrid.Resources>
31-
<domain:BindingProxy x:Key="DataContextProxy" Data="{Binding}" />
32-
</DataGrid.Resources>
33-
3432
<DataGrid.Columns>
3533
<DataGridCheckBoxColumn Binding="{Binding IsSelected, UpdateSourceTrigger=PropertyChanged}"
3634
EditingElementStyle="{StaticResource MaterialDesignDataGridCheckBoxColumnEditingStyle}"
3735
ElementStyle="{StaticResource MaterialDesignDataGridCheckBoxColumnStyle}">
3836
<DataGridCheckBoxColumn.Header>
3937
<Border Background="Transparent">
40-
<CheckBox IsChecked="{Binding Data.IsAllItems1Selected, Source={StaticResource DataContextProxy}}" />
38+
<CheckBox IsChecked="{Binding DataContext.IsAllItems1Selected, Source={x:Reference DataContextProxy}}" />
4139
</Border>
4240
</DataGridCheckBoxColumn.Header>
4341

MaterialDesign3.Demo.Wpf/Domain/BindingProxy.cs

Lines changed: 0 additions & 13 deletions
This file was deleted.

0 commit comments

Comments
 (0)