Rename TabScrollDirection

Author: nicolaihenriksen

src/MaterialDesignThemes.Wpf/Behaviors/Internal/TabControlHeaderScrollBehavior.cs

@@ -1,4 +1,4 @@
-using System.Diagnostics;
+using System.Diagnostics;
 using System.Windows.Media.Animation;
 using Microsoft.Xaml.Behaviors;
 
@@ -17,11 +17,11 @@ private static void CustomHorizontalOffsetChanged(DependencyObject d, Dependency
         scrollViewer.ScrollToHorizontalOffset((double)e.NewValue);
     }
 
-    public static readonly DependencyProperty TabScrollDirectionProperty =
-        DependencyProperty.RegisterAttached("TabScrollDirection", typeof(TabScrollDirection),
+    public static readonly DependencyProperty ScrollDirectionProperty =
+        DependencyProperty.RegisterAttached("ScrollDirection", typeof(TabScrollDirection),
             typeof(TabControlHeaderScrollBehavior), new PropertyMetadata(TabScrollDirection.Unknown));
-    public static TabScrollDirection GetTabScrollDirection(DependencyObject obj) => (TabScrollDirection)obj.GetValue(TabScrollDirectionProperty);
-    public static void SetTabScrollDirection(DependencyObject obj, TabScrollDirection value) => obj.SetValue(TabScrollDirectionProperty, value);
+    public static TabScrollDirection GetScrollDirection(DependencyObject obj) => (TabScrollDirection)obj.GetValue(ScrollDirectionProperty);
+    public static void SetScrollDirection(DependencyObject obj, TabScrollDirection value) => obj.SetValue(ScrollDirectionProperty, value);
 
     public TabControl TabControl
     {
@@ -75,7 +75,7 @@ private void OnTabChanged(object sender, SelectionChangedEventArgs e)
         if (e.AddedItems.Count > 0)
         {
             _desiredScrollStart = AssociatedObject.ContentHorizontalOffset;
-            SetTabScrollDirection(tabControl, (IsMovingForward() ? TabScrollDirection.Forward : TabScrollDirection.Backward));
+            SetScrollDirection(tabControl, (IsMovingForward() ? TabScrollDirection.Forward : TabScrollDirection.Backward));
         }
 
         bool IsMovingForward()

src/MaterialDesignThemes.Wpf/Internal/PaddedBringIntoViewStackPanel.cs

@@ -5,14 +5,14 @@ namespace MaterialDesignThemes.Wpf.Internal;
 
 public class PaddedBringIntoViewStackPanel : StackPanel
 {
-    public TabScrollDirection TabScrollDirection
+    public TabScrollDirection ScrollDirection
     {
-        get => (TabScrollDirection)GetValue(TabScrollDirectionProperty);
-        set => SetValue(TabScrollDirectionProperty, value);
+        get => (TabScrollDirection)GetValue(ScrollDirectionProperty);
+        set => SetValue(ScrollDirectionProperty, value);
     }
 
-    public static readonly DependencyProperty TabScrollDirectionProperty =
-        DependencyProperty.Register(nameof(TabScrollDirection), typeof(TabScrollDirection),
+    public static readonly DependencyProperty ScrollDirectionProperty =
+        DependencyProperty.Register(nameof(ScrollDirection), typeof(TabScrollDirection),
             typeof(PaddedBringIntoViewStackPanel), new PropertyMetadata(TabScrollDirection.Unknown));
 
     public double TabScrollOffset
@@ -34,8 +34,8 @@ private void OnRequestBringIntoView(object sender, RoutedEventArgs e)
         {
             e.Handled = true;
 
-            // TODO: Consider making the "TabScrollDirection" a destructive read (i.e. reset the value once it is read) to avoid leaving a Backward/Forward value that may be misinterpreted at a later stage.
-            double offset = TabScrollDirection switch {
+            // TODO: Consider making the "ScrollDirection" a destructive read (i.e. reset the value once it is read) to avoid leaving a Backward/Forward value that may be misinterpreted at a later stage.
+            double offset = ScrollDirection switch {
                 TabScrollDirection.Backward => -TabScrollOffset,
                 TabScrollDirection.Forward => TabScrollOffset,
                 _ => 0

src/MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.TabControl.xaml

@@ -43,7 +43,7 @@
             <behaviorsInternal:TabControlHeaderScrollBehavior TabControl="{Binding RelativeSource={RelativeSource TemplatedParent}}" ScrollableContent="{Binding ElementName=ScrollableContent}" />
           </b:Interaction.Behaviors>
           <internal:PaddedBringIntoViewStackPanel x:Name="ScrollableContent"
-                                                  TabScrollDirection="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=(behaviorsInternal:TabControlHeaderScrollBehavior.TabScrollDirection)}"
+                                                  ScrollDirection="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=(behaviorsInternal:TabControlHeaderScrollBehavior.ScrollDirection)}"
                                                   TabScrollOffset="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=(wpf:TabAssist.TabScrollOffset)}">
             <UniformGrid x:Name="CenteredHeaderPanel"
                                      HorizontalAlignment="{TemplateBinding HorizontalContentAlignment}"