Fixing stack overflow when the text was being set (#2312)

Author: Keboo

MainDemo.Wpf/Domain/SimpleDateValidationRule.cs

@@ -8,11 +8,10 @@ public class SimpleDateValidationRule : ValidationRule
     {
         public override ValidationResult Validate(object value, CultureInfo cultureInfo)
         {
-            DateTime time;
             return DateTime.TryParse((value ?? "").ToString(),
                 CultureInfo.CurrentCulture,
                 DateTimeStyles.AssumeLocal | DateTimeStyles.AllowWhiteSpaces,
-                out time)
+                out _)
                 ? ValidationResult.ValidResult
                 : new ValidationResult(false, "Invalid date");
         }

MaterialDesignThemes.Wpf/TimePicker.cs

@@ -77,7 +77,10 @@ private static void TextPropertyChangedCallback(DependencyObject dependencyObjec
         {
             var timePicker = (TimePicker)dependencyObject;
             if (!timePicker._isManuallyMutatingText)
+            {
                 timePicker.SetSelectedTime();
+            }
+
             if (timePicker._textBox != null)
             {
                 timePicker.UpdateTextBoxText(dependencyPropertyChangedEventArgs.NewValue as string ?? "");
@@ -173,13 +176,7 @@ public bool Is24Hours
         private static object OnCoerceIsDropDownOpen(DependencyObject d, object baseValue)
         {
             var timePicker = (TimePicker)d;
-
-            if (!timePicker.IsEnabled)
-            {
-                return false;
-            }
-
-            return baseValue;
+            return timePicker.IsEnabled ? baseValue : false;
         }
 
         /// <summary> 
@@ -326,7 +323,9 @@ private void TextBoxOnLostFocus(object sender, RoutedEventArgs routedEventArgs)
                 UpdateTextBoxTextIfNeeded(text!);
             }
             else // Invalid time, jump back to previous good time
+            {
                 SetInvalidTime();
+            }
         }
 
         private void SetInvalidTime()
@@ -352,9 +351,7 @@ private void SetInvalidTime()
         }
 
         private void TextBoxOnKeyDown(object sender, KeyEventArgs keyEventArgs)
-        {
-            keyEventArgs.Handled = ProcessKey(keyEventArgs) || keyEventArgs.Handled;
-        }
+            => keyEventArgs.Handled = ProcessKey(keyEventArgs) || keyEventArgs.Handled;
 
         private bool ProcessKey(KeyEventArgs keyEventArgs)
         {
@@ -394,19 +391,23 @@ private void TextBoxOnTextChanged(object sender, TextChangedEventArgs textChange
             if (_textBox is { } textBox &&
                 (_popup?.IsOpen == true || IsInvalidTextAllowed))
             {
+                _isManuallyMutatingText = true;
                 SetCurrentValue(TextProperty, textBox.Text);
+                _isManuallyMutatingText = false;
             }
 
             if (_popup?.IsOpen == false)
+            {
                 SetSelectedTime(true);
+            }
         }
 
         private void UpdateTextBoxText(string? text)
         {
             // Save and restore the cursor position
             if (_textBox is { } textBox)
             {
-                var caretIndex = textBox.CaretIndex;
+                int caretIndex = textBox.CaretIndex;
                 textBox.Text = text;
                 textBox.CaretIndex = caretIndex;
             }
@@ -418,26 +419,31 @@ private void UpdateTextBoxTextIfNeeded(string lastText)
             {
                 string? formattedText = DateTimeToString(SelectedTime);
                 if (formattedText != lastText)
+                {
                     UpdateTextBoxText(formattedText);
+                }
             }
         }
 
         private void SetSelectedTime(in DateTime time)
-        {
-            SetCurrentValue(SelectedTimeProperty, (SelectedTime?.Date ?? DateTime.Today).Add(time.TimeOfDay));
-        }
+            => SetCurrentValue(SelectedTimeProperty, (SelectedTime?.Date ?? DateTime.Today).Add(time.TimeOfDay));
 
         private void SetSelectedTime(bool beCautious = false)
         {
-            var currentText = _textBox?.Text;
+            string? currentText = _textBox?.Text;
             if (!string.IsNullOrEmpty(currentText))
             {
                 ParseTime(currentText!, t =>
                 {
                     if (!beCautious || DateTimeToString(t) == currentText)
+                    {
                         SetSelectedTime(t);
+                    }
+
                     if (!beCautious)
+                    {
                         UpdateTextBoxTextIfNeeded(currentText!);
+                    }
                 });
             }
             else
@@ -449,7 +455,9 @@ private void SetSelectedTime(bool beCautious = false)
         private void ParseTime(string s, Action<DateTime> successContinuation)
         {
             if (IsTimeValid(s, out DateTime time))
+            {
                 successContinuation(time);
+            }
         }
 
         private bool IsTimeValid(string s, out DateTime time)
@@ -500,7 +508,7 @@ private string DateTimeToString(DateTime datetime, DatePickerFormat format)
 
         private void PopupOnPreviewMouseLeftButtonDown(object sender, MouseButtonEventArgs mouseButtonEventArgs)
         {
-            if (!(sender is Popup popup) || popup.StaysOpen) return;
+            if (sender is not Popup popup || popup.StaysOpen) return;
 
             if (_dropDownButton?.InputHitTest(mouseButtonEventArgs.GetPosition(_dropDownButton)) != null)
             {
@@ -573,11 +581,15 @@ private void DropDownButtonOnClick(object sender, RoutedEventArgs routedEventArg
         private void TogglePopup()
         {
             if (IsDropDownOpen)
+            {
                 SetCurrentValue(IsDropDownOpenProperty, false);
+            }
             else
             {
                 if (_disablePopupReopen)
+                {
                     _disablePopupReopen = false;
+                }
                 else
                 {
                     SetSelectedTime();