fix tests and clippy

Author: ParkMyCar

src/sql-parser/Cargo.toml

@@ -15,7 +15,7 @@ bytesize = "1.3.0"
 datadriven = { version = "0.8.0", optional = true }
 enum-kinds = "0.5.1"
 itertools = "0.12.1"
-mz-ore = { path = "../ore", default-features = false, features = ["stack", "test"] }
+mz-ore = { path = "../ore", default-features = false, features = ["stack", "test", "tracing"] }
 mz-sql-lexer = { path = "../sql-lexer", default-features = false }
 phf = { version = "0.11.1", features = ["uncased"] }
 serde = { version = "1.0.219", features = ["derive"] }

src/sql-parser/tests/testdata/source

@@ -29,8 +29,8 @@ CreateConnection(CreateConnectionStatement { name: UnresolvedItemName([Ident("my
 parse-statement
 CREATE SOURCE "no_such_table"
   IN CLUSTER cdc_cluster
-  FROM SQL SERVER CONNECTION sql_server (CAPTURE INSTANCE 'no_such_mz_capture_1');
+  FROM SQL SERVER CONNECTION sql_server;
 ----
-CREATE SOURCE no_such_table IN CLUSTER cdc_cluster FROM SQL SERVER CONNECTION sql_server (CAPTURE INSTANCE = 'no_such_mz_capture_1')
+CREATE SOURCE no_such_table IN CLUSTER cdc_cluster FROM SQL SERVER CONNECTION sql_server
 =>
-CreateSource(CreateSourceStatement { name: UnresolvedItemName([Ident("no_such_table")]), in_cluster: Some(Unresolved(Ident("cdc_cluster"))), col_names: [], connection: SqlServer { connection: Name(UnresolvedItemName([Ident("sql_server")])), options: [SqlServerConfigOption { name: CaptureInstance, value: Some(Value(String("no_such_mz_capture_1"))) }] }, include_metadata: [], format: None, envelope: None, if_not_exists: false, key_constraint: None, with_options: [], external_references: None, progress_subsource: None })
+CreateSource(CreateSourceStatement { name: UnresolvedItemName([Ident("no_such_table")]), in_cluster: Some(Unresolved(Ident("cdc_cluster"))), col_names: [], connection: SqlServer { connection: Name(UnresolvedItemName([Ident("sql_server")])), options: [] }, include_metadata: [], format: None, envelope: None, if_not_exists: false, key_constraint: None, with_options: [], external_references: None, progress_subsource: None })

src/sql-server-util/src/inspect.rs

@@ -262,7 +262,7 @@ JOIN cdc.change_tables ch ON t.object_id = ch.source_object_id
                 Arc::clone(&table_name),
                 Arc::clone(&capture_instance),
             ))
-            .or_insert_with(|| Vec::default());
+            .or_default();
         columns.push(column);
     }