Skip to content

Commit 18502c3

Browse files
authored
Enable diff overflows in CI (#32068)
Follow up to #32028 to enable panics on overflow in CI. ### Checklist - [ ] This PR has adequate test coverage / QA involvement has been duly considered. ([trigger-ci for additional test/nightly runs](https://trigger-ci.dev.materialize.com/)) - [ ] This PR has an associated up-to-date [design doc](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/README.md), is a design doc ([template](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/00000000_template.md)), or is sufficiently small to not require a design. <!-- Reference the design in the description. --> - [ ] If this PR evolves [an existing `$T ⇔ Proto$T` mapping](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/command-and-response-binary-encoding.md) (possibly in a backwards-incompatible way), then it is tagged with a `T-proto` label. - [ ] If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label ([example](MaterializeInc/cloud#5021)). <!-- Ask in #team-cloud on Slack if you need help preparing the cloud PR. --> - [ ] If this PR includes major [user-facing behavior changes](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/guide-changes.md#what-changes-require-a-release-note), I have pinged the relevant PM to schedule a changelog post. --------- Signed-off-by: Moritz Hoffmann <mh@materialize.com>
1 parent c86cb3a commit 18502c3

File tree

2 files changed

+5
-20
lines changed

2 files changed

+5
-20
lines changed

misc/python/materialize/mzcompose/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ def get_default_system_parameters(
127127
"kafka_default_metadata_fetch_interval": "1s",
128128
"mysql_offset_known_interval": "1s",
129129
"force_source_table_syntax": "true" if force_source_table_syntax else "false",
130+
"ore_overflowing_behavior": "panic",
130131
"persist_batch_columnar_format": (
131132
"structured" if version > MzVersion.parse_mz("v0.135.0-dev") else "both_v2"
132133
),

test/cluster/mzcompose.py

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -863,17 +863,6 @@ def workflow_test_github_5087(c: Composition) -> None:
863863
) AS base (data2, data4, data8, diff),
864864
repeat_row(diff)
865865
);
866-
CREATE MATERIALIZED VIEW constant_wrapped_sums AS
867-
SELECT SUM(data2) AS sum2, SUM(data4) AS sum4, SUM(data8) AS sum8
868-
FROM (
869-
SELECT * FROM (
870-
VALUES (2::uint2, 2::uint4, 2::uint8, 9223372036854775807),
871-
(1::uint2, 1::uint4, 1::uint8, 1),
872-
(1::uint2, 1::uint4, 1::uint8, 1),
873-
(1::uint2, 1::uint4, 1::uint8, 1)
874-
) AS base (data2, data4, data8, diff),
875-
repeat_row(diff)
876-
);
877866
"""
878867
)
879868
c.testdrive(
@@ -931,24 +920,19 @@ def workflow_test_github_5087(c: Composition) -> None:
931920
# Test wraparound behaviors
932921
> INSERT INTO base VALUES (1, 1, 1, -1);
933922
934-
> INSERT INTO base VALUES (2, 2, 2, 9223372036854775807);
923+
>[version<14000] INSERT INTO base VALUES (2, 2, 2, 9223372036854775807);
935924
936-
> SELECT sum(data2) FROM data;
925+
>[version<14000] SELECT sum(data2) FROM data;
937926
18446744073709551614
938927
939-
> SELECT sum(data4) FROM data;
928+
>[version<14000] SELECT sum(data4) FROM data;
940929
18446744073709551614
941930
942-
> SELECT sum(data8) FROM data;
931+
>[version<14000] SELECT sum(data8) FROM data;
943932
18446744073709551614
944933
945934
> INSERT INTO base VALUES (1, 1, 1, 1), (1, 1, 1, 1), (1, 1, 1, 1);
946935
947-
# Constant-folding behavior matches for now the rendered behavior
948-
# wrt. wraparound; this can be revisited as part of database-issues#5172.
949-
> SELECT * FROM constant_wrapped_sums;
950-
1 1 18446744073709551617
951-
952936
# This causes a panic starting with v0.140.0, but not before.
953937
>[version<14000] SELECT SUM(data2) FROM data;
954938
1

0 commit comments

Comments
 (0)