Skip to content

Commit 19347ea

Browse files
committed
adjust sqllogic tests to avoid builtin comments
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
1 parent b7b9546 commit 19347ea

File tree

2 files changed

+38
-38
lines changed

2 files changed

+38
-38
lines changed

test/sqllogictest/alter-table.slt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,5 +439,5 @@ statement ok
439439
DROP TABLE t2 CASCADE;
440440

441441
query TTIT
442-
SELECT * FROM mz_internal.mz_comments;
442+
SELECT * FROM mz_internal.mz_comments WHERE id = 'u1';
443443
----

test/sqllogictest/comment.slt

Lines changed: 37 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@ statement ok
2929
COMMENT ON TABLE a IS 'foo_table';
3030

3131
query TTT
32-
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments;
32+
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments WHERE id NOT LIKE 's%';
3333
----
3434
table NULL foo_table
3535

3636
query IT
37-
SELECT objsubid, description FROM pg_description;
37+
SELECT objsubid, description FROM pg_description WHERE objoid >= 20000;
3838
----
3939
0 foo_table
4040

@@ -53,13 +53,13 @@ statement ok
5353
COMMENT ON COLUMN a.y IS 'load_bearing';
5454

5555
query TTT
56-
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments;
56+
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments WHERE id NOT LIKE 's%';
5757
----
5858
table NULL foo_table
5959
table 2 load_bearing
6060

6161
query IT
62-
SELECT objsubid, description FROM pg_description;
62+
SELECT objsubid, description FROM pg_description WHERE objoid >= 20000;
6363
----
6464
0 foo_table
6565
2 load_bearing
@@ -93,14 +93,14 @@ statement ok
9393
COMMENT ON COLUMN b.ts IS 'utc_timestamp';
9494

9595
query TTT
96-
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments;
96+
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments WHERE id NOT LIKE 's%';
9797
----
9898
table NULL foo_table
9999
table 2 load_bearing
100100
table 1 utc_timestamp
101101

102102
query IT
103-
SELECT objsubid, description FROM pg_description;
103+
SELECT objsubid, description FROM pg_description WHERE objoid >= 20000;
104104
----
105105
0 foo_table
106106
2 load_bearing
@@ -119,13 +119,13 @@ statement ok
119119
DROP TABLE a;
120120

121121
query TTT
122-
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments;
122+
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments WHERE id NOT LIKE 's%';
123123
----
124124
table NULL foo_table
125125
table 1 utc_timestamp
126126

127127
query IT
128-
SELECT objsubid, description FROM pg_description;
128+
SELECT objsubid, description FROM pg_description WHERE objoid >= 20000;
129129
----
130130
0 foo_table
131131
1 utc_timestamp
@@ -142,11 +142,11 @@ statement ok
142142
COMMENT ON COLUMN b.ts IS NULL
143143

144144
query TTT
145-
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments;
145+
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments WHERE id NOT LIKE 's%';
146146
----
147147

148148
query IT
149-
SELECT objsubid, description FROM pg_description;
149+
SELECT objsubid, description FROM pg_description WHERE objoid >= 20000;
150150
----
151151

152152
statement error unknown catalog item 'c'
@@ -173,13 +173,13 @@ statement ok
173173
COMMENT ON VIEW c IS 'this_is_a_view';
174174

175175
query TTT
176-
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments;
176+
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments WHERE id NOT LIKE 's%';
177177
----
178178
index NULL speed_up
179179
view NULL this_is_a_view
180180

181181
query IT
182-
SELECT objsubid, description FROM pg_description;
182+
SELECT objsubid, description FROM pg_description WHERE objoid >= 20000;
183183
----
184184
0 speed_up
185185
0 this_is_a_view
@@ -207,13 +207,13 @@ col_2 (empty)
207207
col_1 this_works
208208

209209
query TTT
210-
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments;
210+
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments WHERE id NOT LIKE 's%';
211211
----
212212
view 1 this_works
213213
view NULL this_is_a_view
214214

215215
query IT
216-
SELECT objsubid, description FROM pg_description;
216+
SELECT objsubid, description FROM pg_description WHERE objoid >= 20000;
217217
----
218218
1 this_works
219219
0 this_is_a_view
@@ -238,15 +238,15 @@ SELECT name, comment FROM (SHOW COLUMNS FROM mv);
238238
x comment_mat_view_col
239239

240240
query TTT
241-
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments;
241+
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments WHERE id NOT LIKE 's%';
242242
----
243243
view 1 this_works
244244
view NULL this_is_a_view
245245
materialized-view NULL mat_foo
246246
materialized-view 1 comment_mat_view_col
247247

248248
query IT
249-
SELECT objsubid, description FROM pg_description;
249+
SELECT objsubid, description FROM pg_description WHERE objoid >= 20000;
250250
----
251251
0 mat_foo
252252
1 this_works
@@ -285,11 +285,11 @@ statement ok
285285
DROP MATERIALIZED VIEW mv;
286286

287287
query TTT
288-
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments;
288+
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments WHERE id NOT LIKE 's%';
289289
----
290290

291291
query IT
292-
SELECT objsubid, description FROM pg_description;
292+
SELECT objsubid, description FROM pg_description WHERE objoid >= 20000;
293293
----
294294

295295
statement ok
@@ -313,13 +313,13 @@ statement ok
313313
COMMENT ON CLUSTER REPLICA comment_cluster.r2 IS 'second_replicator';
314314

315315
query TTT
316-
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments;
316+
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments WHERE id NOT LIKE 's%';
317317
----
318318
cluster NULL careful_now
319319
cluster-replica NULL second_replicator
320320

321321
query IT
322-
SELECT objsubid, description FROM pg_description;
322+
SELECT objsubid, description FROM pg_description WHERE objoid >= 20000;
323323
----
324324

325325
statement ok
@@ -335,7 +335,7 @@ statement ok
335335
COMMENT ON COLUMN my_webhook.body IS 'json_blob';
336336

337337
query TTT
338-
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments;
338+
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments WHERE id NOT LIKE 's%';
339339
----
340340
source 1 json_blob
341341
source NULL all_the_data
@@ -348,7 +348,7 @@ SELECT obj_description((SELECT oid FROM mz_sources WHERE name = 'my_webhook'), '
348348
all_the_data json_blob
349349

350350
query IT
351-
SELECT objsubid, description FROM pg_description;
351+
SELECT objsubid, description FROM pg_description WHERE objoid >= 20000;
352352
----
353353
1 json_blob
354354
0 all_the_data
@@ -404,7 +404,7 @@ statement ok
404404
COMMENT ON TYPE custom_type IS 'custom_type_comment';
405405

406406
query TTT
407-
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments;
407+
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments WHERE id NOT LIKE 's%';
408408
----
409409
source 1 json_blob
410410
type NULL supercool_list
@@ -436,7 +436,7 @@ statement ok
436436
COMMENT ON COLUMN custom_type.y IS 'custom_type_y_comment';
437437

438438
query TTT
439-
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments;
439+
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments WHERE id NOT LIKE 's%';
440440
----
441441
source 1 json_blob
442442
type NULL supercool_list
@@ -447,7 +447,7 @@ type 1 custom_type_x_comment
447447
type 2 custom_type_y_comment
448448

449449
query IT
450-
SELECT objsubid, description FROM pg_description;
450+
SELECT objsubid, description FROM pg_description WHERE objoid >= 20000;
451451
----
452452
1 json_blob
453453
0 all_the_data
@@ -479,7 +479,7 @@ statement ok
479479
COMMENT ON SECRET my_secret IS 'supersecret';
480480

481481
query TTT
482-
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments;
482+
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments WHERE id NOT LIKE 's%';
483483
----
484484
secret NULL supersecret
485485
type NULL supercool_list
@@ -488,7 +488,7 @@ type 1 custom_type_x_comment
488488
type 2 custom_type_y_comment
489489

490490
query IT
491-
SELECT objsubid, description FROM pg_description;
491+
SELECT objsubid, description FROM pg_description WHERE objoid >= 20000;
492492
----
493493
0 supercool_list
494494
0 custom_type_comment
@@ -529,13 +529,13 @@ statement ok
529529
DROP TYPE int4_list;
530530

531531
query TTT
532-
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments;
532+
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments WHERE id NOT LIKE 's%';
533533
----
534534
database NULL this_is_my_db
535535
schema NULL this_is_my_schema
536536

537537
query IT
538-
SELECT objsubid, description FROM pg_description;
538+
SELECT objsubid, description FROM pg_description WHERE objoid >= 20000;
539539
----
540540
0 this_is_my_schema
541541

@@ -562,12 +562,12 @@ statement ok
562562
COMMENT ON ROLE student IS 'limited_role';
563563

564564
query TTT
565-
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments;
565+
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments WHERE id NOT LIKE 's%';
566566
----
567567
role NULL limited_role
568568

569569
query IT
570-
SELECT objsubid, description FROM pg_description;
570+
SELECT objsubid, description FROM pg_description WHERE objoid >= 20000;
571571
----
572572

573573
statement ok
@@ -592,13 +592,13 @@ COMMENT ON ROLE teacher IS 'foo';
592592
COMPLETE 0
593593

594594
query TTT
595-
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments;
595+
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments WHERE id NOT LIKE 's%';
596596
----
597597
role NULL foo
598598
role NULL limited_role
599599

600600
query IT
601-
SELECT objsubid, description FROM pg_description;
601+
SELECT objsubid, description FROM pg_description WHERE objoid >= 20000;
602602
----
603603

604604
simple conn=mz_system,user=mz_system
@@ -620,11 +620,11 @@ statement ok
620620
DROP ROLE teacher;
621621

622622
query TTT
623-
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments;
623+
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments WHERE id NOT LIKE 's%';
624624
----
625625

626626
query IT
627-
SELECT objsubid, description FROM pg_description;
627+
SELECT objsubid, description FROM pg_description WHERE objoid >= 20000;
628628
----
629629

630630
statement error must be owner of DATABASE materialize
@@ -639,10 +639,10 @@ COMMENT ON DATABASE materialize IS 'main_db';
639639
COMPLETE 0
640640

641641
query TTT
642-
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments;
642+
SELECT object_type, object_sub_id, comment FROM mz_internal.mz_comments WHERE id NOT LIKE 's%';
643643
----
644644
database NULL main_db
645645

646646
query IT
647-
SELECT objsubid, description FROM pg_description;
647+
SELECT objsubid, description FROM pg_description WHERE objoid >= 20000;
648648
----

0 commit comments

Comments
 (0)