adapter: add histogram metrics for apply_catalog_implications

This adds a new HistogramVec metric 'mz_apply_catalog_implications_seconds'
to track the duration of apply_catalog_implications methods. The metric
includes a 'method' label to distinguish between:

- apply_catalog_implications
- apply_catalog_implications_inner

Author: aljoscha

src/adapter/src/coord/catalog_implications.rs

@@ -28,7 +28,7 @@
 
 use std::collections::{BTreeMap, BTreeSet};
 use std::sync::Arc;
-use std::time::Duration;
+use std::time::{Duration, Instant};
 
 use fail::fail_point;
 use itertools::Itertools;
@@ -82,6 +82,8 @@ impl Coordinator {
         ctx: Option<&mut ExecuteContext>,
         catalog_updates: Vec<ParsedStateUpdate>,
     ) -> Result<(), AdapterError> {
+        let start = Instant::now();
+
         let mut catalog_implications: BTreeMap<CatalogItemId, CatalogImplication> = BTreeMap::new();
         let mut cluster_commands: BTreeMap<ClusterId, CatalogImplication> = BTreeMap::new();
         let mut cluster_replica_commands: BTreeMap<(ClusterId, ReplicaId), CatalogImplication> =
@@ -144,6 +146,10 @@ impl Coordinator {
         )
         .await?;
 
+        self.metrics
+            .apply_catalog_implications_seconds
+            .observe(start.elapsed().as_secs_f64());
+
         Ok(())
     }
 

src/adapter/src/metrics.rs

@@ -51,6 +51,7 @@ pub struct Metrics {
     pub catalog_snapshot_seconds: HistogramVec,
     pub pgwire_recv_scheduling_delay_ms: HistogramVec,
     pub catalog_transact_seconds: HistogramVec,
+    pub apply_catalog_implications_seconds: Histogram,
 }
 
 impl Metrics {
@@ -228,6 +229,11 @@ impl Metrics {
                 help: "The time it takes to run various catalog transact methods.",
                 var_labels: ["method"],
                 buckets: histogram_seconds_buckets(0.001, 32.0),
+            )),
+            apply_catalog_implications_seconds: registry.register(metric!(
+                name: "mz_apply_catalog_implications_seconds",
+                help: "The time it takes to apply catalog implications.",
+                buckets: histogram_seconds_buckets(0.001, 32.0),
             ))
         }
     }