Skip to content

Commit 2a01a42

Browse files
committed
adapter: handle AddSecret and AlterSecret via catalog implications
This one is really a no-op, for now, because secrets are stored in the controller even _before_ the catalog transaction.
1 parent 74f4bd5 commit 2a01a42

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

src/adapter/src/coord/catalog_implications.rs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -360,18 +360,18 @@ impl Coordinator {
360360
)) => {
361361
continual_tasks_to_drop.push((catalog_id, ct.cluster_id, ct.global_id()));
362362
}
363-
CatalogImplication::Secret(CatalogImplicationKind::Added(secret)) => {
364-
tracing::debug!(?secret, "not handling AddSecret in here yet");
363+
CatalogImplication::Secret(CatalogImplicationKind::Added(_secret)) => {
364+
// No action needed: the secret payload is stored in
365+
// secrets_controller.ensure() BEFORE the catalog transaction.
366+
// By the time we see this update, the secret is already stored.
365367
}
366368
CatalogImplication::Secret(CatalogImplicationKind::Altered {
367-
prev: prev_secret,
368-
new: new_secret,
369+
prev: _prev_secret,
370+
new: _new_secret,
369371
}) => {
370-
tracing::debug!(
371-
?prev_secret,
372-
?new_secret,
373-
"not handling AlterSecret in here yet"
374-
);
372+
// No action needed: altering a secret updates the payload via
373+
// secrets_controller.ensure() without a catalog transaction,
374+
// so we shouldn't see AlterSecret updates here.
375375
}
376376
CatalogImplication::Secret(CatalogImplicationKind::Dropped(
377377
_secret,

0 commit comments

Comments
 (0)